From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from darkcity.gna.ch ([195.226.6.51]:34253 "EHLO mail.gna.ch"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1753559AbbGCBo3 (ORCPT <rfc822;stable@vger.kernel.org>);
	Thu, 2 Jul 2015 21:44:29 -0400
Subject: Re: [added to the 3.18 stable tree] drm/radeon: Add
 RADEON_INFO_VA_UNMAP_WORKING query
To: Sasha Levin <sasha.levin@oracle.com>
References: <1435873285-7148-1-git-send-email-sasha.levin@oracle.com>
 <1435873285-7148-3-git-send-email-sasha.levin@oracle.com>
Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org,
	=?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
From: =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>
Message-ID: <5595E6BA.5030405@daenzer.net>
Date: Fri, 3 Jul 2015 10:34:50 +0900
MIME-Version: 1.0
In-Reply-To: <1435873285-7148-3-git-send-email-sasha.levin@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 03.07.2015 06:40, Sasha Levin wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
> 
> This patch has been added to the 3.18 stable tree. If you have any
> objections, please let us know.
> 
> =============
> 
> This patch has been added to the 3.18 stable tree. If you have any
> objections, please let us know.

I have a concern:


> [ Upstream commit 3bc980bf19bb62007e923691fa2869ba113be895 ]
> 
> This tells userspace that it's safe to use the RADEON_VA_UNMAP operation
> of the DRM_RADEON_GEM_VA ioctl.
> 
> Cc: stable@vger.kernel.org
> (NOTE: Backporting this commit requires at least backports of commits
> 26d4d129b6042197b4cbc8341c0618f99231af2f,
> 48afbd70ac7b6aa62e8d452091023941d8085f8a and
> c29c0876ec05d51a93508a39b90b92c29ba6423d as well, otherwise using
> RADEON_VA_UNMAP runs into trouble)

AFAICT the current stable/linux-3.18.y tree has a backport of
c29c0876ec05d51a93508a39b90b92c29ba6423d, but not of
26d4d129b6042197b4cbc8341c0618f99231af2f or
48afbd70ac7b6aa62e8d452091023941d8085f8a.

This commit (3bc980bf19bb62007e923691fa2869ba113be895) must not be
backported without those other commits.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer