All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Williams <gfi8d1h02@sneakemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] board.c patch got undone
Date: Mon, 15 Mar 2004 19:47:28 -0800	[thread overview]
Message-ID: <5596-65900@sneakemail.com> (raw)

It looks like in the last wave of changes, a patch got undone:


wing % cvs diff -r1.35 board.c
Index: board.c
===================================================================
RCS file: /cvsroot/u-boot/u-boot/lib_ppc/board.c,v
retrieving revision 1.35
retrieving revision 1.36
diff -r1.35 -r1.36
877c877
< #if CONFIG_SERIAL_SOFTWARE_FIFO
---
 > #ifdef CONFIG_SERIAL_SOFTWARE_FIFO


The "#if CONFIG_SERIAL_SOFTWARE_FIFO" is the right version,
if one assumes the documentation is correct that setting
CONFIG_SERIAL_SOFTWARE_FIFO=0 causes the serial port to become
insensitive to CTS.

Perhaps it would be even better to change it to:

#if defined(CONFIG_SERIAL_SOFTWARE_FIFO) && CONFIG_SOFTWARE_FIFO>0
...
#endif

-- 
Steve Williams                "The woods are lovely, dark and deep.
steve at XXXXXXXXXX           But I have promises to keep,
http://www.XXXXXXXXXX         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."

                 reply	other threads:[~2004-03-16  3:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5596-65900@sneakemail.com \
    --to=gfi8d1h02@sneakemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.