From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAw6g-0004zx-DM for qemu-devel@nongnu.org; Fri, 03 Jul 2015 04:13:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAw6c-0006NH-27 for qemu-devel@nongnu.org; Fri, 03 Jul 2015 04:13:58 -0400 Received: from s16892447.onlinehome-server.info ([82.165.15.123]:33538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAw6b-0006M8-SE for qemu-devel@nongnu.org; Fri, 03 Jul 2015 04:13:53 -0400 Message-ID: <55964431.1040404@ilande.co.uk> Date: Fri, 03 Jul 2015 09:13:37 +0100 From: Mark Cave-Ayland MIME-Version: 1.0 References: <555B5CBC.1090709@twiddle.net> <20150519181735-mutt-send-email-mst@redhat.com> <20150520115740-mutt-send-email-mst@redhat.com> <20150520115548.GG6219@ad.nay.redhat.com> <557C46FE.1070802@ilande.co.uk> In-Reply-To: <557C46FE.1070802@ilande.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] virtio-pci msix error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Fam Zheng Cc: Richard Henderson , qemu-devel , "Michael S. Tsirkin" On 13/06/15 16:06, Mark Cave-Ayland wrote: > On 20/05/15 13:10, Peter Maydell wrote: > >> On 20 May 2015 at 12:55, Fam Zheng wrote: >>> On Wed, 05/20 11:41, Peter Maydell wrote: >>>> On 20 May 2015 at 10:58, Michael S. Tsirkin wrote: >>>>> On Tue, May 19, 2015 at 09:11:26PM +0100, Peter Maydell wrote: >>>>>> On 19 May 2015 at 20:16, Michael S. Tsirkin wrote: >>>>>>> On Tue, May 19, 2015 at 08:54:36AM -0700, Richard Henderson wrote: >>>>>>>> Re patch c7ff5482. What's the point of this error? >>>>>>>> It's going to always appear for older targets that >>>>>>>> predate such new fangled things as msix. >>>>>>>> >>>>>>>> Obviously the patch has been there a while, and it's >>>>>>>> not actually causing any problems, but today it got >>>>>>>> on my nerves... >>>>>> >>>>>>> So don't specify nvectors > 0 for these platforms then? >>>>>> >>>>>> How do you do that? I did a quick 'git grep' for nvectors >>>>>> and none of the hits are in platform-dependent code... >>>>>> >>>>>> Why can't the virtio-pci device automatically detect >>>>>> whether the PCI bus it's plugged into supports MSIx >>>>>> and just do the right thing? >>>> >>>>> I mean why does *user* specify nvectors > 0? >>>> >>>> The user isn't specifying nvectors at all. That's why >>>> the message is annoying... >>> >>> So I think it's better to fix the default for old targets? >> >> What default? No platform or PCI controller code specifies any >> default value for nvectors, and the user doesn't specify a >> value for nvectors. >> >> The only thing that tries to specify a value for nvectors >> is the virtio-*-pci device itself, which it then pointlessly >> complains that it can't set. > > Ping? I've just done an OpenBIOS test run on qemu-system-sparc64 and I'm > still seeing this message appear on the console. Any chance we can get > this fixed for 2.4? Ping again? ATB, Mark.