From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v2 3/5] drm/rockchip: vop: support plane scale Date: Fri, 03 Jul 2015 17:17:56 +0800 Message-ID: <55965344.5050502@rock-chips.com> References: <1435313249-4549-1-git-send-email-mark.yao@rock-chips.com> <1435313249-4549-4-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomasz Figa Cc: xw@rock-chips.com, zwl@rock-chips.com, "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , dri-devel , dkm@rock-chips.com, sandy.huang@rock-chips.com, "linux-arm-kernel@lists.infradead.org" List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDA35pyIMDPml6UgMTU6NDYsIFRvbWFzeiBGaWdhIHdyb3RlOgo+IEhpIE1hcmss Cj4KPiBQbGVhc2Ugc2VlIG15IGNvbW1lbnRzIGlubGluZS4KPgo+IE9uIEZyaSwgSnVuIDI2LCAy MDE1IGF0IDc6MDcgUE0sIE1hcmsgWWFvIDxtYXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4gd3JvdGU6 Cj4+IFdpbl9mdWxsIHN1cHBvcnQgMS84IHRvIDggc2NhbGUgZG93bi91cCBlbmdpbmUsIHN1cHBv cnQKPj4gYWxsIGZvcm1hdCBzY2FsZS4KPiBbc25pcF0KPgo+PiBAQCAtMzUxLDYgKzQxMiwxNSBA QCBzdGF0aWMgaW5saW5lIHZvaWQgdm9wX21hc2tfd3JpdGVfcmVsYXhlZChzdHJ1Y3Qgdm9wICp2 b3AsIHVpbnQzMl90IG9mZnNldCwKPj4gICAgICAgICAgfQo+PiAgIH0KPj4KPj4gK3N0YXRpYyBp bmxpbmUgaW50IF9nZXRfdnNraXBsaW5lcyh1aW50MzJfdCBzcmNoLCB1aW50MzJfdCBkc3RoKQo+ PiArewo+PiArICAgICAgIGlmIChzcmNoID49ICh1aW50MzJfdCkoNCAqIGRzdGggKiBNSU5fU0NM X0ZUX0FGVEVSX1ZTS0lQKSkKPj4gKyAgICAgICAgICAgICAgIHJldHVybiA0Owo+PiArICAgICAg IGVsc2UgaWYgKHNyY2ggPj0gKHVpbnQzMl90KSgyICogZHN0aCAqIE1JTl9TQ0xfRlRfQUZURVJf VlNLSVApKQo+PiArICAgICAgICAgICAgICAgcmV0dXJuIDI7Cj4+ICsgICAgICAgcmV0dXJuIDE7 Cj4gSG93IGFib3V0IHJld3JpdGluZyB0aGUgYWJvdmUgdG86Cj4KPiAjZGVmaW5lIFNDTF9NQVhf VlNLSVBMSU5FUyA0Cj4KPiB1aW50MzJfdCB2c2tpcGxpbmVzOwo+Cj4gZm9yICh2c2tpcGxpbmVz ID0gU0NMX01BWF9WU0tJUExJTkVTOyB2c2tpcGxpbmVzID4gMTsgdnNraXBsaW5lcyAvPSAyKQo+ ICAgICAgICAgIGlmIChzcmNoID49IHZza2lwbGluZXMgKiBkc3RoICogTUlOX1NDTF9GVF9BRlRF Ul9WU0tJUCkKPiAgICAgICAgICAgICAgICAgIGJyZWFrOwo+Cj4gcmV0dXJuIHZza2lwbGluZXM7 Cj4KPiBuaXQ6IEkgYmVsaWV2ZSBpdCB3b3VsZCBiZSBiZXR0ZXIgZm9yIHJlYWRhYmlsaXR5IHRv IG1vdmUgdGhpcwo+IGZ1bmN0aW9uIHRvIG90aGVyIHNjYWxlciByZWxhdGVkIGZ1bmN0aW9ucyBi ZWxvdy4KPiBuaXQ6IEkgZG9uJ3Qgc2VlIGFueSBleGlzdGluZyBmdW5jdGlvbnMgd2l0aCBuYW1l cyBzdGFydGluZyBmcm9tIF8sIHNvCj4gdG8ga2VlcCBleGlzdGluZyBjb252ZW50aW9ucywgaG93 IGFib3V0IGNhbGxpbmcgdGhlbSBzY2xfKiwgZS5nLgo+IHNjbF9nZXRfdnNraXBsaW5lcygpLgpP Swo+PiArfQo+PiArCj4+ICAgc3RhdGljIGVudW0gdm9wX2RhdGFfZm9ybWF0IHZvcF9jb252ZXJ0 X2Zvcm1hdCh1aW50MzJfdCBmb3JtYXQpCj4+ICAgewo+PiAgICAgICAgICBzd2l0Y2ggKGZvcm1h dCkgewo+PiBAQCAtNTM4LDYgKzYwOCwzMTAgQEAgc3RhdGljIHZvaWQgdm9wX2Rpc2FibGUoc3Ry dWN0IGRybV9jcnRjICpjcnRjKQo+PiAgICAgICAgICBwbV9ydW50aW1lX3B1dCh2b3AtPmRldik7 Cj4+ICAgfQo+Pgo+PiArc3RhdGljIGludCBfdm9wX2NhbF95cmdiX2xiX21vZGUoaW50IHdpZHRo KQo+PiArewo+PiArICAgICAgIGludCBsYl9tb2RlID0gTEJfUkdCXzE5MjBYNTsKPj4gKwo+PiAr ICAgICAgIGlmICh3aWR0aCA+IDI1NjApCj4+ICsgICAgICAgICAgICAgICBsYl9tb2RlID0gTEJf UkdCXzM4NDBYMjsKPj4gKyAgICAgICBlbHNlIGlmICh3aWR0aCA+IDE5MjApCj4+ICsgICAgICAg ICAgICAgICBsYl9tb2RlID0gTEJfUkdCXzI1NjBYNDsKPiBJdCB3b3VsZCBiZSBtb3JlIHJlYWRh YmxlIHRvIGFkZAo+Cj4gZWxzZQo+ICAgICAgICAgIGxiX21vZGUgPSBMQl9SR0JfMTkyMFg1Owo+ Cj4gaW5zdGVhZCBvZiBpbml0aWFsaXppbmcgdGhlIHZhcmlhYmxlIGF0IGRlY2xhcmF0aW9uIHRp bWUuCj4KT0sKPj4gKwo+PiArICAgICAgIHJldHVybiBsYl9tb2RlOwo+PiArfQo+PiArCj4+ICtz dGF0aWMgaW50IF92b3BfY2FsX2NiY3JfbGJfbW9kZShpbnQgd2lkdGgpCj4+ICt7Cj4+ICsgICAg ICAgaW50IGxiX21vZGUgPSBMQl9ZVVZfMjU2MFg4Owo+PiArCj4+ICsgICAgICAgaWYgKHdpZHRo ID4gMjU2MCkKPj4gKyAgICAgICAgICAgICAgIGxiX21vZGUgPSBMQl9SR0JfMzg0MFgyOwo+PiAr ICAgICAgIGVsc2UgaWYgKHdpZHRoID4gMTkyMCkKPj4gKyAgICAgICAgICAgICAgIGxiX21vZGUg PSBMQl9SR0JfMjU2MFg0Owo+PiArICAgICAgIGVsc2UgaWYgKHdpZHRoID4gMTI4MCkKPj4gKyAg ICAgICAgICAgICAgIGxiX21vZGUgPSBMQl9ZVVZfMzg0MFg1Owo+PiArCj4+ICsgICAgICAgcmV0 dXJuIGxiX21vZGU7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyB2b2lkIF92b3BfY2FsX3NjbF9mYWMo c3RydWN0IHZvcCAqdm9wLCBjb25zdCBzdHJ1Y3Qgdm9wX3dpbl9kYXRhICp3aW4sCj4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdWludDMyX3Qgc3JjX3csIHVpbnQzMl90IHNyY19oLCB1 aW50MzJfdCBkc3RfdywKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBk c3RfaCwgdWludDMyX3QgcGl4ZWxfZm9ybWF0KQo+PiArewo+PiArICAgICAgIHVpbnQxNl90IHly Z2JfaG9yX3NjbF9tb2RlID0gU0NBTEVfTk9ORTsKPj4gKyAgICAgICB1aW50MTZfdCB5cmdiX3Zl cl9zY2xfbW9kZSA9IFNDQUxFX05PTkU7Cj4+ICsgICAgICAgdWludDE2X3QgY2JyX2hvcl9zY2xf bW9kZSA9IFNDQUxFX05PTkU7Cj4+ICsgICAgICAgdWludDE2X3QgY2JyX3Zlcl9zY2xfbW9kZSA9 IFNDQUxFX05PTkU7Cj4+ICsgICAgICAgdWludDE2X3QgeXJnYl9oc2RfbW9kZSA9IFNDQUxFX0RP V05fQklMOwo+PiArICAgICAgIHVpbnQxNl90IGNicl9oc2RfbW9kZSA9IFNDQUxFX0RPV05fQklM Owo+PiArICAgICAgIHVpbnQxNl90IHlyZ2JfdnNkX21vZGUgPSBTQ0FMRV9ET1dOX0JJTDsKPj4g KyAgICAgICB1aW50MTZfdCBjYnJfdnNkX21vZGUgPSBTQ0FMRV9ET1dOX0JJTDsKPiBObyBjb2Rl IHNlZW1zIHRvIGJlIGFzc2lnbmluZyB0aGUgNCB2YXJpYWJsZXMgYWJvdmUuIElzIHNvbWUgY29k ZQo+IG1pc3Npbmcgb3IgdGhleSBhcmUgc2ltcGx5IGNvbnN0YW50cyBhbmQgdGhleSAoYW5kIGNv ZGUgY2hlY2tpbmcgdGhlaXIKPiB2YWx1ZXMpIGFyZSBub3QgbmVjZXNzYXJ5Pwp0aG9zZSB2YWx1 ZSBkaXJlY3RseSB3cml0ZSB0byB0aGUgdm9wIHJlZ3MsIGl0J3MgbmVjZXNzYXJ5Lgo+PiArICAg ICAgIHVpbnQxNl90IHlyZ2JfdnN1X21vZGUgPSBTQ0FMRV9VUF9CSUw7Cj4+ICsgICAgICAgdWlu dDE2X3QgY2JyX3ZzdV9tb2RlID0gU0NBTEVfVVBfQklMOwo+PiArICAgICAgIHVpbnQxNl90IHNj YWxlX3lyZ2JfeCA9IDEgPDwgU0NMX0ZUX0RFRkFVTFRfRklYUE9JTlRfU0hJRlQ7Cj4+ICsgICAg ICAgdWludDE2X3Qgc2NhbGVfeXJnYl95ID0gMSA8PCBTQ0xfRlRfREVGQVVMVF9GSVhQT0lOVF9T SElGVDsKPj4gKyAgICAgICB1aW50MTZfdCBzY2FsZV9jYmNyX3ggPSAxIDw8IFNDTF9GVF9ERUZB VUxUX0ZJWFBPSU5UX1NISUZUOwo+PiArICAgICAgIHVpbnQxNl90IHNjYWxlX2NiY3JfeSA9IDEg PDwgU0NMX0ZUX0RFRkFVTFRfRklYUE9JTlRfU0hJRlQ7Cj4+ICsgICAgICAgaW50IGhzdWIgPSBk cm1fZm9ybWF0X2hvcnpfY2hyb21hX3N1YnNhbXBsaW5nKHBpeGVsX2Zvcm1hdCk7Cj4+ICsgICAg ICAgaW50IHZzdWIgPSBkcm1fZm9ybWF0X3ZlcnRfY2hyb21hX3N1YnNhbXBsaW5nKHBpeGVsX2Zv cm1hdCk7Cj4+ICsgICAgICAgYm9vbCBpc195dXYgPSBpc195dXZfc3VwcG9ydChwaXhlbF9mb3Jt YXQpOwo+PiArICAgICAgIHVpbnQxNl90IHZzZF95cmdiX2d0NCA9IDA7Cj4+ICsgICAgICAgdWlu dDE2X3QgdnNkX3lyZ2JfZ3QyID0gMDsKPj4gKyAgICAgICB1aW50MTZfdCB2c2RfY2JyX2d0NCA9 IDA7Cj4+ICsgICAgICAgdWludDE2X3QgdnNkX2Nicl9ndDIgPSAwOwo+PiArICAgICAgIHVpbnQx Nl90IHlyZ2Jfc3JjX3cgPSBzcmNfdzsKPj4gKyAgICAgICB1aW50MTZfdCB5cmdiX3NyY19oID0g c3JjX2g7Cj4+ICsgICAgICAgdWludDE2X3QgeXJnYl9kc3RfdyA9IGRzdF93Owo+PiArICAgICAg IHVpbnQxNl90IHlyZ2JfZHN0X2ggPSBkc3RfaDsKPj4gKyAgICAgICB1aW50MTZfdCBjYmNyX3Ny Y193Owo+PiArICAgICAgIHVpbnQxNl90IGNiY3Jfc3JjX2g7Cj4+ICsgICAgICAgdWludDE2X3Qg Y2Jjcl9kc3RfdzsKPj4gKyAgICAgICB1aW50MTZfdCBjYmNyX2RzdF9oOwo+PiArICAgICAgIHVp bnQzMl90IHZkbXVsdDsKPj4gKyAgICAgICB1aW50MTZfdCBsYl9tb2RlOwo+IFRoZSBhbW91bnQg b2YgbG9jYWwgdmFyaWFibGVzIHN1Z2dlc3RzIHRoYXQgdGhpcyBmdW5jdGlvbiBuZWVkcyB0byBi ZQo+IHNwbGl0IGludG8gc2V2ZXJhbCBzbWFsbGVyIG9uZXMuCj4KPiBCeSB0aGUgd2F5LCBkbyB5 b3UgbmVlZCB0byBpbml0aWFsaXplIGFsbCBvZiB0aGVtPyBHQ0Mgd2lsbCBhdCBsZWFzdAo+IHdh cm4gKGlmIG5vdCBlcnJvciBvdXQpIGlmIGFuIHVuaXRpYWxpemVkIHZhcmlhYmxlIGlzIHJlZmVy ZW5jZWQsIHNvCj4gaXQncyBlbm91Z2ggdG8gbWFrZSBzdXJlIHRoYXQgdGhlIGNvZGUgY29ycmVj dGx5IGNvdmVycyBhbGwgYnJhbmNoCj4gcGF0aHMsIHdoaWNoIGlzIGFjdHVhbGx5IGJldHRlciBm b3IgdGhlIGNvZGUgdGhhbiB0byByZWx5IG9uIGRlZmF1bHQKPiB2YWx1ZS4KWWVhaCwgc29tZSB2 YWx1ZSBkaXJlY3RseSB3cml0ZSB0byB0aGUgdm9wLCBzb21lIHZhbHVlIGdjYyByZXBvcnQgdGhl IAp3YXJuLCBzbyBpbml0aWFsaXplIHRoZW0uCj4+ICsKPj4gKyAgICAgICBpZiAoKCh5cmdiX2Rz dF93IDw8IDMpIDw9IHlyZ2Jfc3JjX3cpIHx8Cj4+ICsgICAgICAgICAgICgoeXJnYl9kc3RfaCA8 PCAzKSA8PSB5cmdiX3NyY19oKSB8fAo+IEhtbSwgaWYgdGhpcyBpcyBlbmZvcmNpbmcgdGhlIG1h eGltdW0gZG93bnNjYWxpbmcgZmFjdG9yLCB0aGVuCj4gd291bGRuJ3QgaXQgYmUgbW9yZSByZWFk YWJsZSB0byB3cml0ZSBsaWtlIHRoaXM6Cj4KPiB5cmdiX3NyY193ID49IDggKiB5cmdiX2RzdF93 Cj4KPiBBbHNvIGlzID49IGNvcnJlY3QgaGVyZT8gSXMgdGhlIG1heGltdW0gZmFjdG9yIGxlc3Mg dGhhbiA4Pwp5cmdiX3NyY193ID49IDggKiB5cmdiX2RzdF93IG1lYW5zIHdlIGNhbid0IHNjYWxl IGRvd24gZXhjZWVkIDgsCm1lYW5zIHRoYXQgKHNyY193KTE5MjAtPihkc3RfdykyNDAgaXMgd3Jv bmcuCgo+PiArICAgICAgICAgICB5cmdiX2RzdF93ID4gMzg0MCkgewo+IEknZCBzdWdnZXN0IG1v dmluZyB0aGlzIHRvIHNlcGFyYXRlIGlmIHdpdGggZGlmZmVyZW50IGVycm9yIG1lc3NhZ2UuCj4K Pj4gKyAgICAgICAgICAgICAgIERSTV9FUlJPUigieXJnYiBzY2FsZSBleGNlZWQgOCxzcmNbJWR4 JWRdIGRzdFslZHglZF1cbiIsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgeXJnYl9zcmNf dywgeXJnYl9zcmNfaCwgeXJnYl9kc3RfdywgeXJnYl9kc3RfaCk7Cj4gSG1tLCBtYXliZSAiTWF4 aW11bSBkb3duc2NhbGluZyBmYWN0b3IgKDgpIGV4Y2VlZGVkIiBhbmQgdGhlbiBmb3IgdGhlCj4g ZGVzdGluYXRpb24gd2lkdGggY2hlY2sgIk1heGltdW0gZGVzdGluYXRpb24gd2lkdGggKDM4NDAp IGV4Y2VlZGVkIj8KT0suCj4+ICsgICAgICAgICAgICAgICByZXR1cm47Cj4+ICsgICAgICAgfQo+ PiArCj4+ICsgICAgICAgaWYgKHlyZ2Jfc3JjX3cgPCB5cmdiX2RzdF93KQo+PiArICAgICAgICAg ICAgICAgeXJnYl9ob3Jfc2NsX21vZGUgPSBTQ0FMRV9VUDsKPj4gKyAgICAgICBlbHNlIGlmICh5 cmdiX3NyY193ID4geXJnYl9kc3RfdykKPj4gKyAgICAgICAgICAgICAgIHlyZ2JfaG9yX3NjbF9t b2RlID0gU0NBTEVfRE9XTjsKPj4gKyAgICAgICBlbHNlCj4+ICsgICAgICAgICAgICAgICB5cmdi X2hvcl9zY2xfbW9kZSA9IFNDQUxFX05PTkU7Cj4gVGhpcyBsb29rcyBsaWtlIGEgZ29vZCBjYW5k aWRhdGUgZm9yIGEgaGVscGVyIGZ1bmN0aW9uOgo+Cj4gZW51bSBzY2xfbW9kZSBzY2xfZ2V0X3Nj bF9tb2RlKHVpbnQzMl90IHNyYywgdWludDMyX3QgZHN0KQo+IHsKPiAgICAgICAgICBpZiAoc3Jj IDwgZHN0KQo+ICAgICAgICAgICAgICAgICAgcmV0dXJuIFNDQUxFX1VQOwo+ICAgICAgICAgIGVs c2UgaWYgKHNyYyA+IGRzdCkKPiAgICAgICAgICAgICAgICAgIHJldHVybiBTQ0FMRV9ET1dOOwo+ ICAgICAgICAgIGVsc2UKPiAgICAgICAgICAgICAgICAgIHJldHVybiBTQ0FMRV9OT05FOwo+IH0K PgpPSwo+PiArCj4+ICsgICAgICAgaWYgKHlyZ2Jfc3JjX2ggPCB5cmdiX2RzdF9oKQo+PiArICAg ICAgICAgICAgICAgeXJnYl92ZXJfc2NsX21vZGUgPSBTQ0FMRV9VUDsKPj4gKyAgICAgICBlbHNl IGlmICh5cmdiX3NyY19oICA+IHlyZ2JfZHN0X2gpCj4+ICsgICAgICAgICAgICAgICB5cmdiX3Zl cl9zY2xfbW9kZSA9IFNDQUxFX0RPV047Cj4+ICsgICAgICAgZWxzZQo+PiArICAgICAgICAgICAg ICAgeXJnYl92ZXJfc2NsX21vZGUgPSBTQ0FMRV9OT05FOwo+IEFuZCBub3cgdGhlIGhlbHBlciBm dW5jdGlvbiBjb3VsZCBiZSB1c2VkIGhlcmUgYXMgd2VsbC4KPgo+PiArCj4+ICsgICAgICAgaWYg KGlzX3l1dikgewo+PiArICAgICAgICAgICAgICAgY2Jjcl9zcmNfdyA9IHNyY193IC8gaHN1YjsK Pj4gKyAgICAgICAgICAgICAgIGNiY3Jfc3JjX2ggPSBzcmNfaCAvIHZzdWI7Cj4+ICsgICAgICAg ICAgICAgICBjYmNyX2RzdF93ID0gZHN0X3c7Cj4+ICsgICAgICAgICAgICAgICBjYmNyX2RzdF9o ID0gZHN0X2g7Cj4+ICsgICAgICAgICAgICAgICBpZiAoKGNiY3JfZHN0X3cgPDwgMykgPD0gY2Jj cl9zcmNfdyB8fAo+PiArICAgICAgICAgICAgICAgICAgIChjYmNyX2RzdF9oIDw8IDMpIDw9IGNi Y3Jfc3JjX2ggfHwKPj4gKyAgICAgICAgICAgICAgICAgICBjYmNyX3NyY193ID4gMzg0MCB8fAo+ PiArICAgICAgICAgICAgICAgICAgIGNiY3Jfc3JjX3cgPT0gMCkKPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgRFJNX0VSUk9SKCJjYmNyIHNjYWxlIGZhaWxlZCxzcmNbJWR4JWRdIGRzdFslZHgl ZF1cbiIsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjYmNyX3NyY193LCBj YmNyX3NyY19oLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2Jjcl9kc3Rf dywgY2Jjcl9kc3RfaCk7Cj4gSSBiZWxpZXZlIHlvdSBzaG91bGQgaGF2ZSB0aG9zZSBhbHJlYWR5 IGVuZm9yY2VkIGJ5IFkgcGxhbmUuIEFsc28gaXQKPiBkb2Vzbid0IHNlZW0gcmVhc29uYWJsZSB0 byBldmVyIGdldCAwIHNyYyB3aWR0aCBhcyBhbiBhcmd1bWVudCBmb3IKPiB0aGlzIGZ1bmN0aW9u Lgo+Cj4+ICsgICAgICAgICAgICAgICBpZiAoY2Jjcl9zcmNfdyA8IGNiY3JfZHN0X3cpCj4+ICsg ICAgICAgICAgICAgICAgICAgICAgIGNicl9ob3Jfc2NsX21vZGUgPSBTQ0FMRV9VUDsKPj4gKyAg ICAgICAgICAgICAgIGVsc2UgaWYgKGNiY3Jfc3JjX3cgPiBjYmNyX2RzdF93KQo+PiArICAgICAg ICAgICAgICAgICAgICAgICBjYnJfaG9yX3NjbF9tb2RlID0gU0NBTEVfRE9XTjsKPj4gKwo+PiAr ICAgICAgICAgICAgICAgaWYgKGNiY3Jfc3JjX2ggPCBjYmNyX2RzdF9oKQo+PiArICAgICAgICAg ICAgICAgICAgICAgICBjYnJfdmVyX3NjbF9tb2RlID0gU0NBTEVfVVA7Cj4+ICsgICAgICAgICAg ICAgICBlbHNlIGlmIChjYmNyX3NyY19oID4gY2Jjcl9kc3RfaCkKPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgY2JyX3Zlcl9zY2xfbW9kZSA9IFNDQUxFX0RPV047Cj4gQXJlbid0IHRoZSBzY2xf bW9kZXMgZm9yIENiQ3IgcGxhbmVzIGFsd2F5cyB0aGUgc2FtZSBhcyBmb3IgWSBwbGFuZT8KCk5v LCBzdWNoIGFzIHNyYygxOTIwIHggMTA4MCkgLT4gZHN0KDEyODB4ODAwKSwgeXV2IGZvcm1hdCBp cyBOVjEyLgpzbyBZIHBsYW5lIGhvcml6b250YWwgYW5kIHZlcnRpY2FsIGlzIHNjYWxlIGRvd24u CgpidXQgc3JjX3cgPSAxOTIwIC8gMiA9IDk2MCA8IDEyODAKICAgICAgIHNyY19oID0gMTA4MCAv IDIgPSA1NDAgPCA4MDAuCgpTbyBDYmNyIGhvcml6b250YWwgYW5kIHZlcnRpY2FsIGlzIHNjYWxl IHVwLgo+PiArICAgICAgIH0KPj4gKyAgICAgICAvKgo+PiArICAgICAgICAqIGxpbmUgYnVmZmVy IG1vZGUKPj4gKyAgICAgICAgKi8KPj4gKyAgICAgICBpZiAoaXNfeXV2KSB7Cj4+ICsgICAgICAg ICAgICAgICBpZiAoeXJnYl9ob3Jfc2NsX21vZGUgPT0gU0NBTEVfRE9XTiAmJiB5cmdiX2RzdF93 ID4gMjU2MCkKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgbGJfbW9kZSA9IExCX1JHQl8zODQw WDI7Cj4+ICsgICAgICAgICAgICAgICBlbHNlIGlmIChjYnJfaG9yX3NjbF9tb2RlID09IFNDQUxF X0RPV04pCj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGxiX21vZGUgPSBfdm9wX2NhbF9jYmNy X2xiX21vZGUoY2Jjcl9kc3Rfdyk7Cj4+ICsgICAgICAgICAgICAgICBlbHNlCj4+ICsgICAgICAg ICAgICAgICAgICAgICAgIGxiX21vZGUgPSBfdm9wX2NhbF9jYmNyX2xiX21vZGUoY2Jjcl9zcmNf dyk7Cj4+ICsgICAgICAgfSBlbHNlIHsKPj4gKyAgICAgICAgICAgICAgIGlmICh5cmdiX2hvcl9z Y2xfbW9kZSA9PSBTQ0FMRV9ET1dOKQo+PiArICAgICAgICAgICAgICAgICAgICAgICBsYl9tb2Rl ID0gX3ZvcF9jYWxfeXJnYl9sYl9tb2RlKHlyZ2JfZHN0X3cpOwo+PiArICAgICAgICAgICAgICAg ZWxzZQo+PiArICAgICAgICAgICAgICAgICAgICAgICBsYl9tb2RlID0gX3ZvcF9jYWxfeXJnYl9s Yl9tb2RlKHlyZ2Jfc3JjX3cpOwo+PiArICAgICAgIH0KPiBJIGd1ZXNzIHRoaXMgY291bGQgYmUg bW92ZWQgaW50byBhIGhlbHBlciBmdW5jdGlvbi4KPgo+PiArCj4+ICsgICAgICAgc3dpdGNoIChs Yl9tb2RlKSB7Cj4+ICsgICAgICAgY2FzZSBMQl9ZVVZfMzg0MFg1Ogo+PiArICAgICAgIGNhc2Ug TEJfWVVWXzI1NjBYODoKPj4gKyAgICAgICBjYXNlIExCX1JHQl8xOTIwWDU6Cj4+ICsgICAgICAg Y2FzZSBMQl9SR0JfMTI4MFg4Ogo+PiArICAgICAgICAgICAgICAgeXJnYl92c3VfbW9kZSA9IFND QUxFX1VQX0JJQzsKPj4gKyAgICAgICAgICAgICAgIGNicl92c3VfbW9kZSAgPSBTQ0FMRV9VUF9C SUM7Cj4gSSBtaWdodCBiZSBvdmVybG9va2luZyBzb21ldGhpbmcsIGJ1dCBkb24ndCAgeXJnYl92 c3VfbW9kZSBhbmQKPiBjYnJfdnN1X21vZGUgYWx3YXlzIGhhdmUgdGhlIHNhbWUgdmFsdWVzPwoK SG1tLCB5cmdiX3ZzdV9tb2RlIGFuZCBjYnJfdnN1X21vZGUgbWVhbiBkaWZmZXJlbnQgdm9wIGNv bmZpZywgT0ssIEkgCnRoaW5rIGl0IGNhbiBtZXJnZQp0b2dldGhlci4KCj4+ICsgICAgICAgICAg ICAgICBicmVhazsKPj4gKyAgICAgICBjYXNlIExCX1JHQl8zODQwWDI6Cj4+ICsgICAgICAgICAg ICAgICBpZiAoeXJnYl92ZXJfc2NsX21vZGUgIT0gU0NBTEVfTk9ORSkKPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgRFJNX0VSUk9SKCJFUlJPUiA6IG5vdCBhbGxvdyB5cmdiIHZlciBzY2FsZVxu Iik7Cj4+ICsgICAgICAgICAgICAgICBpZiAoY2JyX3Zlcl9zY2xfbW9kZSAhPSBTQ0FMRV9OT05F KQo+PiArICAgICAgICAgICAgICAgICAgICAgICBEUk1fRVJST1IoIkVSUk9SIDogbm90IGFsbG93 IGNiY3IgdmVyIHNjYWxlXG4iKTsKPiBTaG91bGRuJ3QgdGhlc2UgcmV0dXJuIGVycm9yPyBBbHNv IGl0IHdvdWxkIGJlIG5pY2UgdG8gbWFrZSB0aGUgZXJyb3IKPiBtZXNzYWdlcyBtb3JlIGhlbHBm dWwuCgpPSy4KCj4+ICsgICAgICAgICAgICAgICBicmVhazsKPj4gKyAgICAgICBjYXNlIExCX1JH Ql8yNTYwWDQ6Cj4+ICsgICAgICAgICAgICAgICB5cmdiX3ZzdV9tb2RlID0gU0NBTEVfVVBfQklM Owo+PiArICAgICAgICAgICAgICAgY2JyX3ZzdV9tb2RlICA9IFNDQUxFX1VQX0JJTDsKPj4gKyAg ICAgICAgICAgICAgIGJyZWFrOwo+PiArICAgICAgIGRlZmF1bHQ6Cj4+ICsgICAgICAgICAgICAg ICBEUk1fRVJST1IoInVuc3VwcG9ydCBsYl9tb2RlOiVkXG4iLCBsYl9tb2RlKTsKPj4gKyAgICAg ICAgICAgICAgIGJyZWFrOwo+PiArICAgICAgIH0KPiBBbnl3YXksIHRoaXMgd2hvbGUgc3dpdGNo IGlzIGEgY2FuZGlkYXRlIGZvciBhIGhlbHBlciBmdW5jdGlvbi4KClRoaXMgb25seSB1c2Ugb25l IHRpbWUsIGl0J3Mgb2sgdG8gYmUgYSBoZWxwZXIgZnVuY3Rpb24/Cgo+PiArICAgICAgIC8qCj4+ ICsgICAgICAgICogKDEuMSlZUkdCIEhPUiBTQ0FMRSBGQUNUT1IKPj4gKyAgICAgICAgKi8KPj4g KyAgICAgICBzd2l0Y2ggKHlyZ2JfaG9yX3NjbF9tb2RlKSB7Cj4+ICsgICAgICAgY2FzZSBTQ0FM RV9VUDoKPj4gKyAgICAgICAgICAgICAgIHNjYWxlX3lyZ2JfeCA9IEdFVF9TQ0xfRlRfQklDKHly Z2Jfc3JjX3csIHlyZ2JfZHN0X3cpOwo+PiArICAgICAgICAgICAgICAgYnJlYWs7Cj4+ICsgICAg ICAgY2FzZSBTQ0FMRV9ET1dOOgo+PiArICAgICAgICAgICAgICAgc3dpdGNoICh5cmdiX2hzZF9t b2RlKSB7Cj4+ICsgICAgICAgICAgICAgICBjYXNlIFNDQUxFX0RPV05fQklMOgo+PiArICAgICAg ICAgICAgICAgICAgICAgICBzY2FsZV95cmdiX3ggPSBHRVRfU0NMX0ZUX0JJTElfRE4oeXJnYl9z cmNfdywKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHlyZ2JfZHN0X3cpOwo+PiArICAgICAgICAgICAgICAgICAgICAgICBicmVhazsK Pj4gKyAgICAgICAgICAgICAgIGNhc2UgU0NBTEVfRE9XTl9BVkc6Cj4+ICsgICAgICAgICAgICAg ICAgICAgICAgIHNjYWxlX3lyZ2JfeCA9IEdFVF9TQ0xfRlRfQVZSRyh5cmdiX3NyY193LCB5cmdi X2RzdF93KTsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4+ICsgICAgICAgICAg ICAgICBkZWZhdWx0Ogo+PiArICAgICAgICAgICAgICAgICAgICAgICBEUk1fRVJST1IoInVuc3Vw cG9ydCB5cmdiX2hzZF9tb2RlOiVkXG4iLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgeXJnYl9oc2RfbW9kZSk7Cj4gU2hvdWxkbid0IHRoaXMgcmV0dXJuIGFuIGVycm9yPwo+ Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+PiArICAgICAgICAgICAgICAgfQo+ PiArICAgICAgICAgICAgICAgYnJlYWs7Cj4+ICsgICAgICAgfQo+IERpdHRvLgo+Cj4+ICsKPj4g KyAgICAgICAvKgo+PiArICAgICAgICAqICgxLjIpWVJHQiBWRVIgU0NBTEUgRkFDVE9SCj4+ICsg ICAgICAgICovCj4+ICsgICAgICAgc3dpdGNoICh5cmdiX3Zlcl9zY2xfbW9kZSkgewo+PiArICAg ICAgIGNhc2UgU0NBTEVfVVA6Cj4+ICsgICAgICAgICAgICAgICBzd2l0Y2ggKHlyZ2JfdnN1X21v ZGUpIHsKPj4gKyAgICAgICAgICAgICAgIGNhc2UgU0NBTEVfVVBfQklMOgo+PiArICAgICAgICAg ICAgICAgICAgICAgICBzY2FsZV95cmdiX3kgPSBHRVRfU0NMX0ZUX0JJTElfVVAoeXJnYl9zcmNf aCwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHlyZ2JfZHN0X2gpOwo+PiArICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPj4g KyAgICAgICAgICAgICAgIGNhc2UgU0NBTEVfVVBfQklDOgo+PiArICAgICAgICAgICAgICAgICAg ICAgICBpZiAoeXJnYl9zcmNfaCA8IDMpCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgRFJNX0VSUk9SKCJ5cmdiX3NyY19oIHNob3VsZCBncmVhdGVyIHRoYW4gM1xuIik7Cj4gU2hv dWxkbid0IHRoaXMgcmV0dXJuIGFuIGVycm9yPwo+Cj4+ICsgICAgICAgICAgICAgICAgICAgICAg IHNjYWxlX3lyZ2JfeSA9IEdFVF9TQ0xfRlRfQklDKHlyZ2Jfc3JjX2gsIHlyZ2JfZHN0X2gpOwo+ PiArICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPj4gKyAgICAgICAgICAgICAgIGRlZmF1 bHQ6Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigidW5zdXBwb3J0IHlyZ2Jf dnN1X21vZGU6JWRcbiIsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB5cmdi X3ZzdV9tb2RlKTsKPiBTaG91bGRuJ3QgdGhpcyByZXR1cm4gYW4gZXJyb3I/Cj4KPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4+ICsgICAgICAgICAgICAgICB9Cj4+ICsgICAgICAg ICAgICAgICBicmVhazsKPj4gKyAgICAgICBjYXNlIFNDQUxFX0RPV046Cj4+ICsgICAgICAgICAg ICAgICBzd2l0Y2ggKHlyZ2JfdnNkX21vZGUpIHsKPj4gKyAgICAgICAgICAgICAgIGNhc2UgU0NB TEVfRE9XTl9CSUw6Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIHZkbXVsdCA9IF9nZXRfdnNr aXBsaW5lcyh5cmdiX3NyY19oLCB5cmdiX2RzdF9oKTsKPj4gKyAgICAgICAgICAgICAgICAgICAg ICAgc2NhbGVfeXJnYl95ID0gR0VUX1NDTF9GVF9CSUxJX0ROX1ZTS0lQKHlyZ2Jfc3JjX2gsCj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB5cmdiX2RzdF9oLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmRtdWx0KTsKPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgaWYgKHZkbXVsdCA9PSA0KSB7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdnNkX3lyZ2JfZ3Q0ID0gMTsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB2c2RfeXJnYl9ndDIgPSAwOwo+PiArICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2UgaWYg KHZkbXVsdCA9PSAyKSB7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdnNkX3ly Z2JfZ3Q0ID0gMDsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2c2RfeXJnYl9n dDIgPSAxOwo+PiArICAgICAgICAgICAgICAgICAgICAgICB9Cj4gSG93IGFib3V0IHNvbWV0aGlu ZyBsaWtlIHRoaXM6Cj4KPiB2c2RfeXJnYl9ndDQgPSAodmRtdWx0ID09IDQpOwo+IHZzZF95cmdi X2d0MiA9ICh2ZG11bHQgPT0gMik7CgpCdXQgSSB0aGluayBpdCdzIG5vdCBlYXN5IHRvIHJlYWQu Cgo+PiArICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPj4gKyAgICAgICAgICAgICAgIGNh c2UgU0NBTEVfRE9XTl9BVkc6Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIHNjYWxlX3lyZ2Jf eSA9IEdFVF9TQ0xfRlRfQVZSRyh5cmdiX3NyY19oLCB5cmdiX2RzdF9oKTsKPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgYnJlYWs7Cj4+ICsgICAgICAgICAgICAgICBkZWZhdWx0Ogo+PiArICAg ICAgICAgICAgICAgICAgICAgICBEUk1fRVJST1IoInVuc3VwcG9ydCB5cmdiX3ZzZF9tb2RlOiVk XG4iLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgeXJnYl92c2RfbW9kZSk7 Cj4gU2hvdWxkbid0IHRoaXMgcmV0dXJuIGFuIGVycm9yPwo+Cj4+ICsgICAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOwo+PiArICAgICAgICAgICAgICAgfQo+PiArICAgICAgICAgICAgICAgYnJl YWs7Cj4+ICsgICAgICAgfQo+IEFub3RoZXIgY2FuZGlkYXRlIGZvciBzZXBhcmF0ZSBoZWxwZXIg ZnVuY3Rpb24uCj4KPj4gKyAgICAgICAvKgo+PiArICAgICAgICAqICgyLjEpQ0JDUiBIT1IgU0NB TEUgRkFDVE9SCj4+ICsgICAgICAgICovCj4+ICsgICAgICAgc3dpdGNoIChjYnJfaG9yX3NjbF9t b2RlKSB7Cj4+ICsgICAgICAgY2FzZSBTQ0FMRV9VUDoKPj4gKyAgICAgICAgICAgICAgIHNjYWxl X2NiY3JfeCA9IEdFVF9TQ0xfRlRfQklDKGNiY3Jfc3JjX3csIGNiY3JfZHN0X3cpOwo+PiArICAg ICAgICAgICAgICAgYnJlYWs7Cj4+ICsgICAgICAgY2FzZSBTQ0FMRV9ET1dOOgo+PiArICAgICAg ICAgICAgICAgc3dpdGNoIChjYnJfaHNkX21vZGUpIHsKPj4gKyAgICAgICAgICAgICAgIGNhc2Ug U0NBTEVfRE9XTl9CSUw6Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIHNjYWxlX2NiY3JfeCA9 IEdFVF9TQ0xfRlRfQklMSV9ETihjYmNyX3NyY193LAo+PiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2Jjcl9kc3Rfdyk7Cj4+ICsgICAg ICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+PiArICAgICAgICAgICAgICAgY2FzZSBTQ0FMRV9E T1dOX0FWRzoKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgc2NhbGVfY2Jjcl94ID0gR0VUX1ND TF9GVF9BVlJHKGNiY3Jfc3JjX3csIGNiY3JfZHN0X3cpOwo+PiArICAgICAgICAgICAgICAgICAg ICAgICBicmVhazsKPj4gKyAgICAgICAgICAgICAgIGRlZmF1bHQ6Cj4+ICsgICAgICAgICAgICAg ICAgICAgICAgIERSTV9FUlJPUigidW5zdXBwb3J0IGNicl9oc2RfbW9kZTolZFxuIiwgY2JyX2hz ZF9tb2RlKTsKPiBFcnJvci4KPgo+PiArICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPj4g KyAgICAgICAgICAgICAgIH0KPj4gKyAgICAgICAgICAgICAgIGJyZWFrOwo+PiArICAgICAgIH0K PiBJc24ndCB0aGlzIHN3aXRjaCBleGFjdGx5IHRoZSBzYW1lIGFzIGZvciBZIHBsYW5lIGp1c3Qg d2l0aCBkaWZmZXJlbnQKPiB3aWR0aHMgdXNlZD8gQWxzbywgd291bGRuJ3QgdGhlIHZhbHVlcyBm b3IgQ2JDciBwbGFuZSBiZSB0aGUgc2FtZSBhcwo+IGZvciBZIHBsYW5lPwoKQnV0IENiY3IgY2Fz ZSBpcyBub3Qgc2FtZSBhcyBZIHBsYW5lIGNhc2UsICBob3cgdG8gbWVyZ2U/Cgo+PiArCj4+ICsg ICAgICAgLyoKPj4gKyAgICAgICAgKiAoMi4yKUNCQ1IgVkVSIFNDQUxFIEZBQ1RPUgo+PiArICAg ICAgICAqLwo+PiArICAgICAgIHN3aXRjaCAoY2JyX3Zlcl9zY2xfbW9kZSkgewo+PiArICAgICAg IGNhc2UgU0NBTEVfVVA6Cj4+ICsgICAgICAgICAgICAgICBzd2l0Y2ggKGNicl92c3VfbW9kZSkg ewo+PiArICAgICAgICAgICAgICAgY2FzZSBTQ0FMRV9VUF9CSUw6Cj4+ICsgICAgICAgICAgICAg ICAgICAgICAgIHNjYWxlX2NiY3JfeSA9IEdFVF9TQ0xfRlRfQklMSV9VUChjYmNyX3NyY19oLAo+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY2Jjcl9kc3RfaCk7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+PiArICAg ICAgICAgICAgICAgY2FzZSBTQ0FMRV9VUF9CSUM6Cj4+ICsgICAgICAgICAgICAgICAgICAgICAg IGlmIChjYmNyX3NyY19oIDwgMykKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBE Uk1fRVJST1IoImNiY3Jfc3JjX2ggbmVlZCBncmVhdGVyIHRoYW4gMyAhXG4iKTsKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgc2NhbGVfY2Jjcl95ID0gR0VUX1NDTF9GVF9CSUMoY2Jjcl9zcmNf aCwgY2Jjcl9kc3RfaCk7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+PiArICAg ICAgICAgICAgICAgZGVmYXVsdDoKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgRFJNX0VSUk9S KCJ1bnN1cHBvcnQgY2JyX3ZzdV9tb2RlOiVkXG4iLCBjYnJfdnN1X21vZGUpOwo+IEVycm9yLgo+ Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+PiArICAgICAgICAgICAgICAgfQo+ PiArICAgICAgICAgICAgICAgYnJlYWs7Cj4+ICsgICAgICAgY2FzZSBTQ0FMRV9ET1dOOgo+PiAr ICAgICAgICAgICAgICAgc3dpdGNoIChjYnJfdnNkX21vZGUpIHsKPj4gKyAgICAgICAgICAgICAg IGNhc2UgU0NBTEVfRE9XTl9CSUw6Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIHZkbXVsdCA9 IF9nZXRfdnNraXBsaW5lcyhjYmNyX3NyY19oLCBjYmNyX2RzdF9oKTsKPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgc2NhbGVfY2Jjcl95ID0gR0VUX1NDTF9GVF9CSUxJX0ROX1ZTS0lQKGNiY3Jf c3JjX2gsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjYmNyX2RzdF9oLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmRtdWx0KTsKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgaWYgKHZkbXVsdCA9PSA0KSB7Cj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdnNkX2Nicl9ndDQgPSAxOwo+PiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHZzZF9jYnJfZ3QyID0gMDsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgfSBl bHNlIGlmICh2ZG11bHQgPT0gMikgewo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHZzZF9jYnJfZ3Q0ID0gMDsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2c2Rf Y2JyX2d0MiA9IDE7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIH0KPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgYnJlYWs7Cj4+ICsgICAgICAgICAgICAgICBjYXNlIFNDQUxFX0RPV05fQVZH Ogo+PiArICAgICAgICAgICAgICAgICAgICAgICBzY2FsZV9jYmNyX3kgPSBHRVRfU0NMX0ZUX0FW UkcoY2Jjcl9zcmNfaCwgY2Jjcl9kc3RfaCk7Cj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGJy ZWFrOwo+PiArICAgICAgICAgICAgICAgZGVmYXVsdDoKPj4gKyAgICAgICAgICAgICAgICAgICAg ICAgRFJNX0VSUk9SKCJ1bnN1cHBvcnQgY2JyX3ZzZF9tb2RlOiVkXG4iLCBjYnJfdnNkX21vZGUp Owo+PiArICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPj4gKyAgICAgICAgICAgICAgIH0K Pj4gKyAgICAgICAgICAgICAgIGJyZWFrOwo+PiArICAgICAgIH0KPiBBZ2FpbiwgdGhpcyBsb29r cyBsaWtlIHRoZSB2YWx1ZXMgZm9yIENiQ3Igd291bGQgYmUgdGhlIHNhbWUgYXMgZm9yIFkuCj4g QXJlIHRoZXJlIGFjdHVhbGx5IGNhc2VzIHdoZW4gdGhleSBkaWZmZXI/CgpIbW0sIEFjdHVhbGx5 IHRoZSBjYmNyIGNhbGN1bGF0aW9ucyBoYXZlIHNvbWUgZGlmZmVyZW50IHdpdGggWS4KCj4+ICsK Pj4gKyAgICAgICBWT1BfU0NMX1NFVCh2b3AsIHdpbiwgeXJnYl9ob3Jfc2NsX21vZGUsIHlyZ2Jf aG9yX3NjbF9tb2RlKTsKPj4gKyAgICAgICBWT1BfU0NMX1NFVCh2b3AsIHdpbiwgeXJnYl92ZXJf c2NsX21vZGUsIHlyZ2JfdmVyX3NjbF9tb2RlKTsKPj4gKyAgICAgICBWT1BfU0NMX1NFVCh2b3As IHdpbiwgY2JyX2hvcl9zY2xfbW9kZSwgY2JyX2hvcl9zY2xfbW9kZSk7Cj4+ICsgICAgICAgVk9Q X1NDTF9TRVQodm9wLCB3aW4sIGNicl92ZXJfc2NsX21vZGUsIGNicl92ZXJfc2NsX21vZGUpOwo+ PiArICAgICAgIFZPUF9TQ0xfU0VUKHZvcCwgd2luLCBsYl9tb2RlLCBsYl9tb2RlKTsKPj4gKyAg ICAgICBWT1BfU0NMX1NFVCh2b3AsIHdpbiwgeXJnYl9oc2RfbW9kZSwgeXJnYl9oc2RfbW9kZSk7 Cj4+ICsgICAgICAgVk9QX1NDTF9TRVQodm9wLCB3aW4sIGNicl9oc2RfbW9kZSwgY2JyX2hzZF9t b2RlKTsKPj4gKyAgICAgICBWT1BfU0NMX1NFVCh2b3AsIHdpbiwgeXJnYl92c2RfbW9kZSwgeXJn Yl92c2RfbW9kZSk7Cj4+ICsgICAgICAgVk9QX1NDTF9TRVQodm9wLCB3aW4sIGNicl92c2RfbW9k ZSwgY2JyX3ZzZF9tb2RlKTsKPj4gKyAgICAgICBWT1BfU0NMX1NFVCh2b3AsIHdpbiwgeXJnYl92 c3VfbW9kZSwgeXJnYl92c3VfbW9kZSk7Cj4+ICsgICAgICAgVk9QX1NDTF9TRVQodm9wLCB3aW4s IGNicl92c3VfbW9kZSwgY2JyX3ZzdV9tb2RlKTsKPj4gKyAgICAgICBWT1BfU0NMX1NFVCh2b3As IHdpbiwgc2NhbGVfeXJnYl94LCBzY2FsZV95cmdiX3gpOwo+PiArICAgICAgIFZPUF9TQ0xfU0VU KHZvcCwgd2luLCBzY2FsZV95cmdiX3ksIHNjYWxlX3lyZ2JfeSk7Cj4+ICsgICAgICAgVk9QX1ND TF9TRVQodm9wLCB3aW4sIHZzZF95cmdiX2d0NCwgdnNkX3lyZ2JfZ3Q0KTsKPj4gKyAgICAgICBW T1BfU0NMX1NFVCh2b3AsIHdpbiwgdnNkX3lyZ2JfZ3QyLCB2c2RfeXJnYl9ndDIpOwo+PiArICAg ICAgIFZPUF9TQ0xfU0VUKHZvcCwgd2luLCBzY2FsZV9jYmNyX3gsIHNjYWxlX2NiY3JfeCk7Cj4+ ICsgICAgICAgVk9QX1NDTF9TRVQodm9wLCB3aW4sIHNjYWxlX2NiY3JfeSwgc2NhbGVfY2Jjcl95 KTsKPj4gKyAgICAgICBWT1BfU0NMX1NFVCh2b3AsIHdpbiwgdnNkX2Nicl9ndDQsIHZzZF9jYnJf Z3Q0KTsKPj4gKyAgICAgICBWT1BfU0NMX1NFVCh2b3AsIHdpbiwgdnNkX2Nicl9ndDIsIHZzZF9j YnJfZ3QyKTsKPiBJZiB5b3Ugc3BsaXQgdGhpcyBmdW5jdGlvbiBpbnRvIHNtYWxsZXIgb25lcywg eW91IHByb2JhYmx5IGRvbid0IHdhbnQKPiB0byBrZWVwIGFsbCB0aGUgd3JpdGVzIGxpa2UgaGVy ZSBpbiBvbmUgcGxhY2UsIGJ1dCByYXRoZXIgbWFrZSB0aGUKPiBzbWFsbGVyIGZ1bmN0aW9ucyB3 cml0ZSBwYXJ0aWN1bGFyIHJlZ2lzdGVycyBhZnRlciBjYWxjdWxhdGluZyB0aGVpcgo+IHZhbHVl cy4KCkhtbSwgSSB3aWxsIHRyeSB0byBkbyB0aGF0LgoKPj4gK30KPj4gKwo+PiAgIC8qCj4+ICAg ICogQ2FsbGVyIG11c3QgaG9sZCB2c3luY19tdXRleC4KPj4gICAgKi8KPj4gQEAgLTYyNCw2ICs5 OTgsOCBAQCBzdGF0aWMgaW50IHZvcF91cGRhdGVfcGxhbmVfZXZlbnQoc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4+ICAgICAgICAgICAgICAgICAgLnkyID0gY3J0Yy0+bW9kZS52ZGlzcGxheSwK Pj4gICAgICAgICAgfTsKPj4gICAgICAgICAgYm9vbCBjYW5fcG9zaXRpb24gPSBwbGFuZS0+dHlw ZSAhPSBEUk1fUExBTkVfVFlQRV9QUklNQVJZOwo+PiArICAgICAgIGludCBtaW5fc2NhbGUgPSB3 aW4tPnBoeS0+c2NsID8gMHgwMjAwMCA6IERSTV9QTEFORV9IRUxQRVJfTk9fU0NBTElORzsKPj4g KyAgICAgICBpbnQgbWF4X3NjYWxlID0gd2luLT5waHktPnNjbCA/IDB4ODAwMDAgOiBEUk1fUExB TkVfSEVMUEVSX05PX1NDQUxJTkc7Cj4gSG1tLCBJIHdvbmRlciBpZiB0aGVyZSBhcmVuJ3QgbWF5 YmUgc29tZSBoZWxwZXJzIHRvIGdlbmVyYXRlIGZpeGVkCj4gcG9pbnQgdmFsdWVzIGluIHRoZSBr ZXJuZWwgaW4gYSByZWFkYWJsZSB3YXkuIElmIG5vdCwgbWF5YmUgc29tZXRoaW5nCj4gbGlrZSB0 aGlzIHdvdWxkIGRvOgo+Cj4gI2RlZmluZSBGUkFDXzE2XzE2KG11bHQsIGRpdikgICAgKCgobXVs dCkgPDwgMTYpIC8gKGRpdikpCj4KPiBhbmQgdGhlbiB5b3Ugd291bGQganVzdCB1c2UKPgo+IEZS QUNfMTZfMTYoMSwgOCkgYW5kIEZSQUNfMTZfMTYoOCwgMSkgZm9yIG1pbiBhbmQgbWF4IHNjYWxl IHJlc3BlY3RpdmVseS4KT0suCgo+PiAgICAgICAgICBpZiAoZHJtX2Zvcm1hdF9udW1fcGxhbmVz KGZiLT5waXhlbF9mb3JtYXQpID4gMikgewo+PiAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigi dW5zdXBwb3J0IG1vcmUgdGhhbiAyIHBsYW5lIGZvcm1hdFslMDh4XVxuIiwKPj4gQEAgLTYzMyw4 ICsxMDA5LDggQEAgc3RhdGljIGludCB2b3BfdXBkYXRlX3BsYW5lX2V2ZW50KHN0cnVjdCBkcm1f cGxhbmUgKnBsYW5lLAo+Pgo+PiAgICAgICAgICByZXQgPSBkcm1fcGxhbmVfaGVscGVyX2NoZWNr X3VwZGF0ZShwbGFuZSwgY3J0YywgZmIsCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICZzcmMsICZkZXN0LCAmY2xpcCwKPj4gLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBEUk1fUExBTkVfSEVMUEVSX05PX1NDQUxJTkcsCj4+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRFJNX1BMQU5FX0hF TFBFUl9OT19TQ0FMSU5HLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIG1pbl9zY2FsZSwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBtYXhfc2NhbGUsCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGNhbl9wb3NpdGlvbiwgZmFsc2UsICZ2aXNpYmxlKTsKPj4gICAgICAgICAgaWYg KHJldCkKPj4gICAgICAgICAgICAgICAgICByZXR1cm4gcmV0Owo+PiBAQCAtNzMyLDkgKzExMDgs MTggQEAgc3RhdGljIGludCB2b3BfdXBkYXRlX3BsYW5lX2V2ZW50KHN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lLAo+PiAgICAgICAgICAgICAgICAgIFZPUF9XSU5fU0VUKHZvcCwgd2luLCB1dl92aXIs IHV2X3Zpcl9zdHJpZGUpOwo+PiAgICAgICAgICAgICAgICAgIFZPUF9XSU5fU0VUKHZvcCwgd2lu LCB1dl9tc3QsIHV2X21zdCk7Cj4+ICAgICAgICAgIH0KPj4gKwo+PiArICAgICAgIGlmICh3aW4t PnBoeS0+c2NsKQo+PiArICAgICAgICAgICAgICAgX3ZvcF9jYWxfc2NsX2ZhYyh2b3AsIHdpbiwg YWN0dWFsX3csIGFjdHVhbF9oLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBk ZXN0LngyIC0gZGVzdC54MSwgZGVzdC55MiAtIGRlc3QueTEsCj4+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGZiLT5waXhlbF9mb3JtYXQpOwo+IE1heWJlIHRoZSBmdW5jdGlvbiBj b3VsZCBiZSBuYW1lZCAidm9wX2luaXRfc2NhbGVyKCkiLgo+Ck9LCj4+ICsKPj4gICAgICAgICAg dmFsID0gKGFjdHVhbF9oIC0gMSkgPDwgMTY7Cj4+ICAgICAgICAgIHZhbCB8PSAoYWN0dWFsX3cg LSAxKSAmIDB4ZmZmZjsKPj4gICAgICAgICAgVk9QX1dJTl9TRVQodm9wLCB3aW4sIGFjdF9pbmZv LCB2YWwpOwo+PiArCj4+ICsgICAgICAgdmFsID0gKGRlc3QueTIgLSBkZXN0LnkxIC0gMSkgPDwg MTY7Cj4+ICsgICAgICAgdmFsIHw9IChkZXN0LngyIC0gZGVzdC54MSAtIDEpICYgMHhmZmZmOwo+ PiAgICAgICAgICBWT1BfV0lOX1NFVCh2b3AsIHdpbiwgZHNwX2luZm8sIHZhbCk7Cj4+ICAgICAg ICAgIHZhbCA9IChkc3Bfc3R5IC0gMSkgPDwgMTY7Cj4+ICAgICAgICAgIHZhbCB8PSAoZHNwX3N0 eCAtIDEpICYgMHhmZmZmOwo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlw L3JvY2tjaGlwX2RybV92b3AuaCBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9k cm1fdm9wLmgKPj4gaW5kZXggNjNlOWIzYS4uZWRhY2RlZSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuaAo+PiArKysgYi9kcml2ZXJzL2dw dS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5oCj4+IEBAIC0xOTgsNCArMTk4LDEwMCBA QCBlbnVtIGZhY3Rvcl9tb2RlIHsKPj4gICAgICAgICAgQUxQSEFfU1JDX0dMT0JBTCwKPj4gICB9 Owo+Pgo+PiArZW51bSBzY2FsZV9tb2RlIHsKPj4gKyAgICAgICBTQ0FMRV9OT05FID0gMHgwLAo+ PiArICAgICAgIFNDQUxFX1VQICAgPSAweDEsCj4+ICsgICAgICAgU0NBTEVfRE9XTiA9IDB4Mgo+ PiArfTsKPj4gKwo+PiArZW51bSBsYl9tb2RlIHsKPj4gKyAgICAgICBMQl9ZVVZfMzg0MFg1ID0g MHgwLAo+PiArICAgICAgIExCX1lVVl8yNTYwWDggPSAweDEsCj4+ICsgICAgICAgTEJfUkdCXzM4 NDBYMiA9IDB4MiwKPj4gKyAgICAgICBMQl9SR0JfMjU2MFg0ID0gMHgzLAo+PiArICAgICAgIExC X1JHQl8xOTIwWDUgPSAweDQsCj4+ICsgICAgICAgTEJfUkdCXzEyODBYOCA9IDB4NQo+PiArfTsK Pj4gKwo+PiArZW51bSBzYWNsZV91cF9tb2RlIHsKPj4gKyAgICAgICBTQ0FMRV9VUF9CSUwgPSAw eDAsCj4+ICsgICAgICAgU0NBTEVfVVBfQklDID0gMHgxCj4+ICt9Owo+PiArCj4+ICtlbnVtIHNj YWxlX2Rvd25fbW9kZSB7Cj4+ICsgICAgICAgU0NBTEVfRE9XTl9CSUwgPSAweDAsCj4+ICsgICAg ICAgU0NBTEVfRE9XTl9BVkcgPSAweDEKPj4gK307Cj4+ICsKPj4gKyNkZWZpbmUgQ1VCSUNfUFJF Q0lTRSAgMAo+PiArI2RlZmluZSBDVUJJQ19TUExJTkUgICAxCj4+ICsjZGVmaW5lIENVQklDX0NB VFJPTSAgIDIKPj4gKyNkZWZpbmUgQ1VCSUNfTUlUQ0hFTEwgMwo+PiArCj4+ICsjZGVmaW5lIENV QklDX01PREVfU0VMRVRJT04gICAgICBDVUJJQ19QUkVDSVNFCj4+ICsKPj4gKyNkZWZpbmUgU0NM X0ZUX0JJTElfRE5fRklYUE9JTlRfU0hJRlQgIDEyCj4+ICsjZGVmaW5lIFNDTF9GVF9CSUxJX0RO X0ZJWFBPSU5UKHgpIFwKPj4gKyAgICAgICAgICAgICAgICgoSU5UMzIpKCh4KSooMSA8PCBTQ0xf RlRfQklMSV9ETl9GSVhQT0lOVF9TSElGVCkpKQo+IHN0YXRpYyBpbmxpbmUKPgo+PiArCj4+ICsj ZGVmaW5lIFNDTF9GVF9CSUxJX1VQX0ZJWFBPSU5UX1NISUZUICAxNgo+PiArCj4+ICsjZGVmaW5l IFNDTF9GVF9BVlJHX0ZJWFBPSU5UX1NISUZUICAgICAxNgo+PiArI2RlZmluZSBTQ0xfRlRfQVZS R19GSVhQT0lOVCh4KSBcCj4+ICsgICAgICAgICAgICAgICAoKElOVDMyKSgoeCkgKiAoMSA8PCBT Q0xfRlRfQVZSR19GSVhQT0lOVF9TSElGVCkpKQo+IHN0YXRpYyBpbmxpbmUKPgo+PiArCj4+ICsj ZGVmaW5lIFNDTF9GVF9CSUNfRklYUE9JTlRfU0hJRlQgICAgICAxNgo+PiArI2RlZmluZSBTQ0xf RlRfQklDX0ZJWFBPSU5UKHgpIFwKPj4gKyAgICAgICAgICAgICAgICgoSU5UMzIpKCh4KSooMSA8 PCBTQ0xfRlRfQklDX0ZJWFBPSU5UX1NISUZUKSkpCj4gc3RhdGljIGlubGluZQo+Cj4+ICsKPj4g KyNkZWZpbmUgU0NMX0ZUX0RFRkFVTFRfRklYUE9JTlRfU0hJRlQgICAgMTIKPj4gKyNkZWZpbmUg U0NMX0ZUX1ZTREJJTF9GSVhQT0lOVF9TSElGVCAgICAgMTIKPj4gKwo+PiArI2RlZmluZSBTQ0xf Q0FMKHNyYywgZHN0LCBzaGlmdCkgXAo+PiArICAgICAgICAgICAgICAgKCgoKHNyYykgKiAyIC0g MykgPDwgKChzaGlmdCkgLSAxKSkgLyAoKGRzdCkgLSAxKSkKPj4gKyNkZWZpbmUgR0VUX1NDTF9G VF9CSUxJX0ROKHNyYywgZHN0KSBcCj4+ICsgICAgICAgICAgICAgICBTQ0xfQ0FMKHNyYywgZHN0 LCBTQ0xfRlRfQklMSV9ETl9GSVhQT0lOVF9TSElGVCkKPj4gKyNkZWZpbmUgR0VUX1NDTF9GVF9C SUxJX1VQKHNyYywgZHN0KSBcCj4+ICsgICAgICAgICAgICAgICBTQ0xfQ0FMKHNyYywgZHN0LCBT Q0xfRlRfQklMSV9VUF9GSVhQT0lOVF9TSElGVCkKPj4gKyNkZWZpbmUgR0VUX1NDTF9GVF9CSUMo c3JjLCBkc3QpIFwKPj4gKyAgICAgICAgICAgICAgIFNDTF9DQUwoc3JjLCBkc3QsIFNDTF9GVF9C SUNfRklYUE9JTlRfU0hJRlQpCj4+ICsKPj4gKyNkZWZpbmUgR0VUX1NDTF9ETl9BQ1RfSEVJR0hU KHNyY19oLCB2ZG11bHQpIFwKPj4gKyAgICAgICAgICAgICAgICgoKHNyY19oKSArICh2ZG11bHQp IC0gMSkgLyAodmRtdWx0KSkKPiBBbGwgb2YgdGhlIGZ1bmN0aW9uIG1hY3JvcyBhYm92ZTogc3Rh dGljIGlubGluZS4KPgo+PiArCj4+ICsjZGVmaW5lIE1JTl9TQ0xfRlRfQUZURVJfVlNLSVAgMQo+ PiArI2RlZmluZSBHRVRfU0NMX0ZUX0JJTElfRE5fVlNLSVAoc3JjX2gsIGRzdF9oLCB2ZG11bHQp IFwKPj4gKyAgICAgICAgICAgICAgICgoR0VUX1NDTF9ETl9BQ1RfSEVJR0hUKChzcmNfaCksICh2 ZG11bHQpKSA9PSAoZHN0X2gpKSBcCj4+ICsgICAgICAgICAgICAgICAgICAgICAgID8gKEdFVF9T Q0xfRlRfQklMSV9ETigoc3JjX2gpLCAoZHN0X2gpKS8odmRtdWx0KSkgXAo+PiArICAgICAgICAg ICAgICAgICAgICAgICA6IEdFVF9TQ0xfRlRfQklMSV9ETihHRVRfU0NMX0ROX0FDVF9IRUlHSFQo KHNyY19oKSwgXAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAodmRtdWx0KSksIChkc3RfaCkpKQo+IFN0YXRpYyBpbmxpbmUuCj4KPj4gKwo+PiArI2RlZmlu ZSBHRVRfU0NMX0ZUX0FWUkcoc3JjLCBkc3QpIFwKPj4gKyAgICAgICAgICAgICAgICgoKGRzdCkg PDwgKChTQ0xfRlRfQVZSR19GSVhQT0lOVF9TSElGVCkgKyAxKSkgXAo+PiArICAgICAgICAgICAg ICAgIC8gKDIgKiAoc3JjKSAtIDEpKQo+IFN0YXRpYyBpbmxpbmUuCj4KPj4gKwo+PiArI2RlZmlu ZSBTQ0xfQ09PUl9BQ0NfRklYUE9JTlRfU0hJRlQgICAgMTYKPj4gKyNkZWZpbmUgU0NMX0NPT1Jf QUNDX0ZJWFBPSU5UX09ORSAgICAgICgxIDw8IFNDTF9DT09SX0FDQ19GSVhQT0lOVF9TSElGVCkK Pj4gKyNkZWZpbmUgU0NMX0NPT1JfQUNDX0ZJWFBPSU5UKHgpIFwKPj4gKyAgICAgICAgICAgICAg ICgoSU5UMzIpKCh4KSooMSA8PCBTQ0xfQ09PUl9BQ0NfRklYUE9JTlRfU0hJRlQpKSkKPj4gKyNk ZWZpbmUgU0NMX0NPT1JfQUNDX0ZJWFBPSU5UX1JFVkVSVCh4KSAgICAgICAgXAo+PiArICAgICAg ICAgICAgICAgKCgoKHgpID4+IChTQ0xfQ09PUl9BQ0NfRklYUE9JTlRfU0hJRlQtMSkpICsgMSkg Pj4gMSkKPj4gKwo+PiArI2RlZmluZSBTQ0xfR0VUX0NPT1JfQUNDX0ZJWFBPSU5UKHNjYWxlLCBz aGlmdCkgIFwKPj4gKyAgICAgICAgICAgICAgICgoc2NhbGUpIDw8IChTQ0xfQ09PUl9BQ0NfRklY UE9JTlRfU0hJRlQgLSAoc2hpZnQpKSkKPj4gKyNkZWZpbmUgU0NMX0ZJTFRFUl9GVF9GSVhQT0lO VF9TSElGVCAgIDgKPj4gKyNkZWZpbmUgU0NMX0ZJTFRFUl9GVF9GSVhQT0lOVF9PTkUgICAgICgx IDw8IFNDTF9GSUxURVJfRlRfRklYUE9JTlRfU0hJRlQpCj4+ICsjZGVmaW5lIFNDTF9GSUxURVJf RlRfRklYUE9JTlQoeCkgXAo+PiArICAgICAgICAgICAgICAgKChJTlQzMikoKHgpICogKDEgPDwg U0NMX0ZJTFRFUl9GVF9GSVhQT0lOVF9TSElGVCkpKQo+PiArI2RlZmluZSBTQ0xfRklMVEVSX0ZU X0ZJWFBPSU5UX1JFVkVSVCh4KSBcCj4+ICsgICAgICAgICAgICAgICAoKCgoeCkgPj4gKFNDTF9G SUxURVJfRlRfRklYUE9JTlRfU0hJRlQgLSAxKSkgKyAxKSA+PiAxKQo+PiArCj4+ICsjZGVmaW5l IFNDTF9HRVRfRklMVEVSX0ZUX0ZJWFBPSU5UKGNhLCBzaGlmdCkgXAo+PiArICAgICAgICAgICAg ICAgKCgoY2EpID4+ICgoc2hpZnQpLVNDTF9GSUxURVJfRlRfRklYUE9JTlRfU0hJRlQpKSAmIFwK Pj4gKyAgICAgICAgICAgICAgICAoU0NMX0ZJTFRFUl9GVF9GSVhQT0lOVF9PTkUgLSAxKSkKPj4g Kwo+PiArI2RlZmluZSBTQ0xfT0ZGU0VUX0ZJWFBPSU5UX1NISUZUICAgICAgOAo+PiArI2RlZmlu ZSBTQ0xfT0ZGU0VUX0ZJWFBPSU5UKHgpIFwKPj4gKyAgICAgICAgICAgICAgICgoSU5UMzIpKCh4 KSAqICgxIDw8IFNDTF9PRkZTRVRfRklYUE9JTlRfU0hJRlQpKSkKPiBBbGwgb2YgdGhlIGZ1bmN0 aW9uIG1hY3JvcyBhYm92ZTogc3RhdGljIGlubGluZS4gVGhpcyBzaG91bGQgYWxzbyBsZXQKPiB5 b3UgcmVtb3ZlIHRoZSBjYXN0cy4Kd2hhdCB0aGUgImNhc3RzIiBtZWFuPyBXaHkgZG8geW91IHRo aW5raW5nIHRoYXQgInN0YXRpYyBpbmxpbmUiIGlzIApiZXR0ZXIgdGhhbiAiI2RlZmluZSI/Cgo+ IEJlc3QgcmVnYXJkcywKPiBUb21hc3oKPgo+Cj4KCgotLSAK77ytYXJrCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Fri, 03 Jul 2015 17:17:56 +0800 Subject: [PATCH v2 3/5] drm/rockchip: vop: support plane scale In-Reply-To: References: <1435313249-4549-1-git-send-email-mark.yao@rock-chips.com> <1435313249-4549-4-git-send-email-mark.yao@rock-chips.com> Message-ID: <55965344.5050502@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?07?03? 15:46, Tomasz Figa wrote: > Hi Mark, > > Please see my comments inline. > > On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: >> Win_full support 1/8 to 8 scale down/up engine, support >> all format scale. > [snip] > >> @@ -351,6 +412,15 @@ static inline void vop_mask_write_relaxed(struct vop *vop, uint32_t offset, >> } >> } >> >> +static inline int _get_vskiplines(uint32_t srch, uint32_t dsth) >> +{ >> + if (srch >= (uint32_t)(4 * dsth * MIN_SCL_FT_AFTER_VSKIP)) >> + return 4; >> + else if (srch >= (uint32_t)(2 * dsth * MIN_SCL_FT_AFTER_VSKIP)) >> + return 2; >> + return 1; > How about rewriting the above to: > > #define SCL_MAX_VSKIPLINES 4 > > uint32_t vskiplines; > > for (vskiplines = SCL_MAX_VSKIPLINES; vskiplines > 1; vskiplines /= 2) > if (srch >= vskiplines * dsth * MIN_SCL_FT_AFTER_VSKIP) > break; > > return vskiplines; > > nit: I believe it would be better for readability to move this > function to other scaler related functions below. > nit: I don't see any existing functions with names starting from _, so > to keep existing conventions, how about calling them scl_*, e.g. > scl_get_vskiplines(). OK >> +} >> + >> static enum vop_data_format vop_convert_format(uint32_t format) >> { >> switch (format) { >> @@ -538,6 +608,310 @@ static void vop_disable(struct drm_crtc *crtc) >> pm_runtime_put(vop->dev); >> } >> >> +static int _vop_cal_yrgb_lb_mode(int width) >> +{ >> + int lb_mode = LB_RGB_1920X5; >> + >> + if (width > 2560) >> + lb_mode = LB_RGB_3840X2; >> + else if (width > 1920) >> + lb_mode = LB_RGB_2560X4; > It would be more readable to add > > else > lb_mode = LB_RGB_1920X5; > > instead of initializing the variable at declaration time. > OK >> + >> + return lb_mode; >> +} >> + >> +static int _vop_cal_cbcr_lb_mode(int width) >> +{ >> + int lb_mode = LB_YUV_2560X8; >> + >> + if (width > 2560) >> + lb_mode = LB_RGB_3840X2; >> + else if (width > 1920) >> + lb_mode = LB_RGB_2560X4; >> + else if (width > 1280) >> + lb_mode = LB_YUV_3840X5; >> + >> + return lb_mode; >> +} >> + >> +static void _vop_cal_scl_fac(struct vop *vop, const struct vop_win_data *win, >> + uint32_t src_w, uint32_t src_h, uint32_t dst_w, >> + uint32_t dst_h, uint32_t pixel_format) >> +{ >> + uint16_t yrgb_hor_scl_mode = SCALE_NONE; >> + uint16_t yrgb_ver_scl_mode = SCALE_NONE; >> + uint16_t cbr_hor_scl_mode = SCALE_NONE; >> + uint16_t cbr_ver_scl_mode = SCALE_NONE; >> + uint16_t yrgb_hsd_mode = SCALE_DOWN_BIL; >> + uint16_t cbr_hsd_mode = SCALE_DOWN_BIL; >> + uint16_t yrgb_vsd_mode = SCALE_DOWN_BIL; >> + uint16_t cbr_vsd_mode = SCALE_DOWN_BIL; > No code seems to be assigning the 4 variables above. Is some code > missing or they are simply constants and they (and code checking their > values) are not necessary? those value directly write to the vop regs, it's necessary. >> + uint16_t yrgb_vsu_mode = SCALE_UP_BIL; >> + uint16_t cbr_vsu_mode = SCALE_UP_BIL; >> + uint16_t scale_yrgb_x = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT; >> + uint16_t scale_yrgb_y = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT; >> + uint16_t scale_cbcr_x = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT; >> + uint16_t scale_cbcr_y = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT; >> + int hsub = drm_format_horz_chroma_subsampling(pixel_format); >> + int vsub = drm_format_vert_chroma_subsampling(pixel_format); >> + bool is_yuv = is_yuv_support(pixel_format); >> + uint16_t vsd_yrgb_gt4 = 0; >> + uint16_t vsd_yrgb_gt2 = 0; >> + uint16_t vsd_cbr_gt4 = 0; >> + uint16_t vsd_cbr_gt2 = 0; >> + uint16_t yrgb_src_w = src_w; >> + uint16_t yrgb_src_h = src_h; >> + uint16_t yrgb_dst_w = dst_w; >> + uint16_t yrgb_dst_h = dst_h; >> + uint16_t cbcr_src_w; >> + uint16_t cbcr_src_h; >> + uint16_t cbcr_dst_w; >> + uint16_t cbcr_dst_h; >> + uint32_t vdmult; >> + uint16_t lb_mode; > The amount of local variables suggests that this function needs to be > split into several smaller ones. > > By the way, do you need to initialize all of them? GCC will at least > warn (if not error out) if an unitialized variable is referenced, so > it's enough to make sure that the code correctly covers all branch > paths, which is actually better for the code than to rely on default > value. Yeah, some value directly write to the vop, some value gcc report the warn, so initialize them. >> + >> + if (((yrgb_dst_w << 3) <= yrgb_src_w) || >> + ((yrgb_dst_h << 3) <= yrgb_src_h) || > Hmm, if this is enforcing the maximum downscaling factor, then > wouldn't it be more readable to write like this: > > yrgb_src_w >= 8 * yrgb_dst_w > > Also is >= correct here? Is the maximum factor less than 8? yrgb_src_w >= 8 * yrgb_dst_w means we can't scale down exceed 8, means that (src_w)1920->(dst_w)240 is wrong. >> + yrgb_dst_w > 3840) { > I'd suggest moving this to separate if with different error message. > >> + DRM_ERROR("yrgb scale exceed 8,src[%dx%d] dst[%dx%d]\n", >> + yrgb_src_w, yrgb_src_h, yrgb_dst_w, yrgb_dst_h); > Hmm, maybe "Maximum downscaling factor (8) exceeded" and then for the > destination width check "Maximum destination width (3840) exceeded"? OK. >> + return; >> + } >> + >> + if (yrgb_src_w < yrgb_dst_w) >> + yrgb_hor_scl_mode = SCALE_UP; >> + else if (yrgb_src_w > yrgb_dst_w) >> + yrgb_hor_scl_mode = SCALE_DOWN; >> + else >> + yrgb_hor_scl_mode = SCALE_NONE; > This looks like a good candidate for a helper function: > > enum scl_mode scl_get_scl_mode(uint32_t src, uint32_t dst) > { > if (src < dst) > return SCALE_UP; > else if (src > dst) > return SCALE_DOWN; > else > return SCALE_NONE; > } > OK >> + >> + if (yrgb_src_h < yrgb_dst_h) >> + yrgb_ver_scl_mode = SCALE_UP; >> + else if (yrgb_src_h > yrgb_dst_h) >> + yrgb_ver_scl_mode = SCALE_DOWN; >> + else >> + yrgb_ver_scl_mode = SCALE_NONE; > And now the helper function could be used here as well. > >> + >> + if (is_yuv) { >> + cbcr_src_w = src_w / hsub; >> + cbcr_src_h = src_h / vsub; >> + cbcr_dst_w = dst_w; >> + cbcr_dst_h = dst_h; >> + if ((cbcr_dst_w << 3) <= cbcr_src_w || >> + (cbcr_dst_h << 3) <= cbcr_src_h || >> + cbcr_src_w > 3840 || >> + cbcr_src_w == 0) >> + DRM_ERROR("cbcr scale failed,src[%dx%d] dst[%dx%d]\n", >> + cbcr_src_w, cbcr_src_h, >> + cbcr_dst_w, cbcr_dst_h); > I believe you should have those already enforced by Y plane. Also it > doesn't seem reasonable to ever get 0 src width as an argument for > this function. > >> + if (cbcr_src_w < cbcr_dst_w) >> + cbr_hor_scl_mode = SCALE_UP; >> + else if (cbcr_src_w > cbcr_dst_w) >> + cbr_hor_scl_mode = SCALE_DOWN; >> + >> + if (cbcr_src_h < cbcr_dst_h) >> + cbr_ver_scl_mode = SCALE_UP; >> + else if (cbcr_src_h > cbcr_dst_h) >> + cbr_ver_scl_mode = SCALE_DOWN; > Aren't the scl_modes for CbCr planes always the same as for Y plane? No, such as src(1920 x 1080) -> dst(1280x800), yuv format is NV12. so Y plane horizontal and vertical is scale down. but src_w = 1920 / 2 = 960 < 1280 src_h = 1080 / 2 = 540 < 800. So Cbcr horizontal and vertical is scale up. >> + } >> + /* >> + * line buffer mode >> + */ >> + if (is_yuv) { >> + if (yrgb_hor_scl_mode == SCALE_DOWN && yrgb_dst_w > 2560) >> + lb_mode = LB_RGB_3840X2; >> + else if (cbr_hor_scl_mode == SCALE_DOWN) >> + lb_mode = _vop_cal_cbcr_lb_mode(cbcr_dst_w); >> + else >> + lb_mode = _vop_cal_cbcr_lb_mode(cbcr_src_w); >> + } else { >> + if (yrgb_hor_scl_mode == SCALE_DOWN) >> + lb_mode = _vop_cal_yrgb_lb_mode(yrgb_dst_w); >> + else >> + lb_mode = _vop_cal_yrgb_lb_mode(yrgb_src_w); >> + } > I guess this could be moved into a helper function. > >> + >> + switch (lb_mode) { >> + case LB_YUV_3840X5: >> + case LB_YUV_2560X8: >> + case LB_RGB_1920X5: >> + case LB_RGB_1280X8: >> + yrgb_vsu_mode = SCALE_UP_BIC; >> + cbr_vsu_mode = SCALE_UP_BIC; > I might be overlooking something, but don't yrgb_vsu_mode and > cbr_vsu_mode always have the same values? Hmm, yrgb_vsu_mode and cbr_vsu_mode mean different vop config, OK, I think it can merge together. >> + break; >> + case LB_RGB_3840X2: >> + if (yrgb_ver_scl_mode != SCALE_NONE) >> + DRM_ERROR("ERROR : not allow yrgb ver scale\n"); >> + if (cbr_ver_scl_mode != SCALE_NONE) >> + DRM_ERROR("ERROR : not allow cbcr ver scale\n"); > Shouldn't these return error? Also it would be nice to make the error > messages more helpful. OK. >> + break; >> + case LB_RGB_2560X4: >> + yrgb_vsu_mode = SCALE_UP_BIL; >> + cbr_vsu_mode = SCALE_UP_BIL; >> + break; >> + default: >> + DRM_ERROR("unsupport lb_mode:%d\n", lb_mode); >> + break; >> + } > Anyway, this whole switch is a candidate for a helper function. This only use one time, it's ok to be a helper function? >> + /* >> + * (1.1)YRGB HOR SCALE FACTOR >> + */ >> + switch (yrgb_hor_scl_mode) { >> + case SCALE_UP: >> + scale_yrgb_x = GET_SCL_FT_BIC(yrgb_src_w, yrgb_dst_w); >> + break; >> + case SCALE_DOWN: >> + switch (yrgb_hsd_mode) { >> + case SCALE_DOWN_BIL: >> + scale_yrgb_x = GET_SCL_FT_BILI_DN(yrgb_src_w, >> + yrgb_dst_w); >> + break; >> + case SCALE_DOWN_AVG: >> + scale_yrgb_x = GET_SCL_FT_AVRG(yrgb_src_w, yrgb_dst_w); >> + break; >> + default: >> + DRM_ERROR("unsupport yrgb_hsd_mode:%d\n", >> + yrgb_hsd_mode); > Shouldn't this return an error? > >> + break; >> + } >> + break; >> + } > Ditto. > >> + >> + /* >> + * (1.2)YRGB VER SCALE FACTOR >> + */ >> + switch (yrgb_ver_scl_mode) { >> + case SCALE_UP: >> + switch (yrgb_vsu_mode) { >> + case SCALE_UP_BIL: >> + scale_yrgb_y = GET_SCL_FT_BILI_UP(yrgb_src_h, >> + yrgb_dst_h); >> + break; >> + case SCALE_UP_BIC: >> + if (yrgb_src_h < 3) >> + DRM_ERROR("yrgb_src_h should greater than 3\n"); > Shouldn't this return an error? > >> + scale_yrgb_y = GET_SCL_FT_BIC(yrgb_src_h, yrgb_dst_h); >> + break; >> + default: >> + DRM_ERROR("unsupport yrgb_vsu_mode:%d\n", >> + yrgb_vsu_mode); > Shouldn't this return an error? > >> + break; >> + } >> + break; >> + case SCALE_DOWN: >> + switch (yrgb_vsd_mode) { >> + case SCALE_DOWN_BIL: >> + vdmult = _get_vskiplines(yrgb_src_h, yrgb_dst_h); >> + scale_yrgb_y = GET_SCL_FT_BILI_DN_VSKIP(yrgb_src_h, >> + yrgb_dst_h, >> + vdmult); >> + if (vdmult == 4) { >> + vsd_yrgb_gt4 = 1; >> + vsd_yrgb_gt2 = 0; >> + } else if (vdmult == 2) { >> + vsd_yrgb_gt4 = 0; >> + vsd_yrgb_gt2 = 1; >> + } > How about something like this: > > vsd_yrgb_gt4 = (vdmult == 4); > vsd_yrgb_gt2 = (vdmult == 2); But I think it's not easy to read. >> + break; >> + case SCALE_DOWN_AVG: >> + scale_yrgb_y = GET_SCL_FT_AVRG(yrgb_src_h, yrgb_dst_h); >> + break; >> + default: >> + DRM_ERROR("unsupport yrgb_vsd_mode:%d\n", >> + yrgb_vsd_mode); > Shouldn't this return an error? > >> + break; >> + } >> + break; >> + } > Another candidate for separate helper function. > >> + /* >> + * (2.1)CBCR HOR SCALE FACTOR >> + */ >> + switch (cbr_hor_scl_mode) { >> + case SCALE_UP: >> + scale_cbcr_x = GET_SCL_FT_BIC(cbcr_src_w, cbcr_dst_w); >> + break; >> + case SCALE_DOWN: >> + switch (cbr_hsd_mode) { >> + case SCALE_DOWN_BIL: >> + scale_cbcr_x = GET_SCL_FT_BILI_DN(cbcr_src_w, >> + cbcr_dst_w); >> + break; >> + case SCALE_DOWN_AVG: >> + scale_cbcr_x = GET_SCL_FT_AVRG(cbcr_src_w, cbcr_dst_w); >> + break; >> + default: >> + DRM_ERROR("unsupport cbr_hsd_mode:%d\n", cbr_hsd_mode); > Error. > >> + break; >> + } >> + break; >> + } > Isn't this switch exactly the same as for Y plane just with different > widths used? Also, wouldn't the values for CbCr plane be the same as > for Y plane? But Cbcr case is not same as Y plane case, how to merge? >> + >> + /* >> + * (2.2)CBCR VER SCALE FACTOR >> + */ >> + switch (cbr_ver_scl_mode) { >> + case SCALE_UP: >> + switch (cbr_vsu_mode) { >> + case SCALE_UP_BIL: >> + scale_cbcr_y = GET_SCL_FT_BILI_UP(cbcr_src_h, >> + cbcr_dst_h); >> + break; >> + case SCALE_UP_BIC: >> + if (cbcr_src_h < 3) >> + DRM_ERROR("cbcr_src_h need greater than 3 !\n"); >> + scale_cbcr_y = GET_SCL_FT_BIC(cbcr_src_h, cbcr_dst_h); >> + break; >> + default: >> + DRM_ERROR("unsupport cbr_vsu_mode:%d\n", cbr_vsu_mode); > Error. > >> + break; >> + } >> + break; >> + case SCALE_DOWN: >> + switch (cbr_vsd_mode) { >> + case SCALE_DOWN_BIL: >> + vdmult = _get_vskiplines(cbcr_src_h, cbcr_dst_h); >> + scale_cbcr_y = GET_SCL_FT_BILI_DN_VSKIP(cbcr_src_h, >> + cbcr_dst_h, >> + vdmult); >> + if (vdmult == 4) { >> + vsd_cbr_gt4 = 1; >> + vsd_cbr_gt2 = 0; >> + } else if (vdmult == 2) { >> + vsd_cbr_gt4 = 0; >> + vsd_cbr_gt2 = 1; >> + } >> + break; >> + case SCALE_DOWN_AVG: >> + scale_cbcr_y = GET_SCL_FT_AVRG(cbcr_src_h, cbcr_dst_h); >> + break; >> + default: >> + DRM_ERROR("unsupport cbr_vsd_mode:%d\n", cbr_vsd_mode); >> + break; >> + } >> + break; >> + } > Again, this looks like the values for CbCr would be the same as for Y. > Are there actually cases when they differ? Hmm, Actually the cbcr calculations have some different with Y. >> + >> + VOP_SCL_SET(vop, win, yrgb_hor_scl_mode, yrgb_hor_scl_mode); >> + VOP_SCL_SET(vop, win, yrgb_ver_scl_mode, yrgb_ver_scl_mode); >> + VOP_SCL_SET(vop, win, cbr_hor_scl_mode, cbr_hor_scl_mode); >> + VOP_SCL_SET(vop, win, cbr_ver_scl_mode, cbr_ver_scl_mode); >> + VOP_SCL_SET(vop, win, lb_mode, lb_mode); >> + VOP_SCL_SET(vop, win, yrgb_hsd_mode, yrgb_hsd_mode); >> + VOP_SCL_SET(vop, win, cbr_hsd_mode, cbr_hsd_mode); >> + VOP_SCL_SET(vop, win, yrgb_vsd_mode, yrgb_vsd_mode); >> + VOP_SCL_SET(vop, win, cbr_vsd_mode, cbr_vsd_mode); >> + VOP_SCL_SET(vop, win, yrgb_vsu_mode, yrgb_vsu_mode); >> + VOP_SCL_SET(vop, win, cbr_vsu_mode, cbr_vsu_mode); >> + VOP_SCL_SET(vop, win, scale_yrgb_x, scale_yrgb_x); >> + VOP_SCL_SET(vop, win, scale_yrgb_y, scale_yrgb_y); >> + VOP_SCL_SET(vop, win, vsd_yrgb_gt4, vsd_yrgb_gt4); >> + VOP_SCL_SET(vop, win, vsd_yrgb_gt2, vsd_yrgb_gt2); >> + VOP_SCL_SET(vop, win, scale_cbcr_x, scale_cbcr_x); >> + VOP_SCL_SET(vop, win, scale_cbcr_y, scale_cbcr_y); >> + VOP_SCL_SET(vop, win, vsd_cbr_gt4, vsd_cbr_gt4); >> + VOP_SCL_SET(vop, win, vsd_cbr_gt2, vsd_cbr_gt2); > If you split this function into smaller ones, you probably don't want > to keep all the writes like here in one place, but rather make the > smaller functions write particular registers after calculating their > values. Hmm, I will try to do that. >> +} >> + >> /* >> * Caller must hold vsync_mutex. >> */ >> @@ -624,6 +998,8 @@ static int vop_update_plane_event(struct drm_plane *plane, >> .y2 = crtc->mode.vdisplay, >> }; >> bool can_position = plane->type != DRM_PLANE_TYPE_PRIMARY; >> + int min_scale = win->phy->scl ? 0x02000 : DRM_PLANE_HELPER_NO_SCALING; >> + int max_scale = win->phy->scl ? 0x80000 : DRM_PLANE_HELPER_NO_SCALING; > Hmm, I wonder if there aren't maybe some helpers to generate fixed > point values in the kernel in a readable way. If not, maybe something > like this would do: > > #define FRAC_16_16(mult, div) (((mult) << 16) / (div)) > > and then you would just use > > FRAC_16_16(1, 8) and FRAC_16_16(8, 1) for min and max scale respectively. OK. >> if (drm_format_num_planes(fb->pixel_format) > 2) { >> DRM_ERROR("unsupport more than 2 plane format[%08x]\n", >> @@ -633,8 +1009,8 @@ static int vop_update_plane_event(struct drm_plane *plane, >> >> ret = drm_plane_helper_check_update(plane, crtc, fb, >> &src, &dest, &clip, >> - DRM_PLANE_HELPER_NO_SCALING, >> - DRM_PLANE_HELPER_NO_SCALING, >> + min_scale, >> + max_scale, >> can_position, false, &visible); >> if (ret) >> return ret; >> @@ -732,9 +1108,18 @@ static int vop_update_plane_event(struct drm_plane *plane, >> VOP_WIN_SET(vop, win, uv_vir, uv_vir_stride); >> VOP_WIN_SET(vop, win, uv_mst, uv_mst); >> } >> + >> + if (win->phy->scl) >> + _vop_cal_scl_fac(vop, win, actual_w, actual_h, >> + dest.x2 - dest.x1, dest.y2 - dest.y1, >> + fb->pixel_format); > Maybe the function could be named "vop_init_scaler()". > OK >> + >> val = (actual_h - 1) << 16; >> val |= (actual_w - 1) & 0xffff; >> VOP_WIN_SET(vop, win, act_info, val); >> + >> + val = (dest.y2 - dest.y1 - 1) << 16; >> + val |= (dest.x2 - dest.x1 - 1) & 0xffff; >> VOP_WIN_SET(vop, win, dsp_info, val); >> val = (dsp_sty - 1) << 16; >> val |= (dsp_stx - 1) & 0xffff; >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h >> index 63e9b3a..edacdee 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h >> @@ -198,4 +198,100 @@ enum factor_mode { >> ALPHA_SRC_GLOBAL, >> }; >> >> +enum scale_mode { >> + SCALE_NONE = 0x0, >> + SCALE_UP = 0x1, >> + SCALE_DOWN = 0x2 >> +}; >> + >> +enum lb_mode { >> + LB_YUV_3840X5 = 0x0, >> + LB_YUV_2560X8 = 0x1, >> + LB_RGB_3840X2 = 0x2, >> + LB_RGB_2560X4 = 0x3, >> + LB_RGB_1920X5 = 0x4, >> + LB_RGB_1280X8 = 0x5 >> +}; >> + >> +enum sacle_up_mode { >> + SCALE_UP_BIL = 0x0, >> + SCALE_UP_BIC = 0x1 >> +}; >> + >> +enum scale_down_mode { >> + SCALE_DOWN_BIL = 0x0, >> + SCALE_DOWN_AVG = 0x1 >> +}; >> + >> +#define CUBIC_PRECISE 0 >> +#define CUBIC_SPLINE 1 >> +#define CUBIC_CATROM 2 >> +#define CUBIC_MITCHELL 3 >> + >> +#define CUBIC_MODE_SELETION CUBIC_PRECISE >> + >> +#define SCL_FT_BILI_DN_FIXPOINT_SHIFT 12 >> +#define SCL_FT_BILI_DN_FIXPOINT(x) \ >> + ((INT32)((x)*(1 << SCL_FT_BILI_DN_FIXPOINT_SHIFT))) > static inline > >> + >> +#define SCL_FT_BILI_UP_FIXPOINT_SHIFT 16 >> + >> +#define SCL_FT_AVRG_FIXPOINT_SHIFT 16 >> +#define SCL_FT_AVRG_FIXPOINT(x) \ >> + ((INT32)((x) * (1 << SCL_FT_AVRG_FIXPOINT_SHIFT))) > static inline > >> + >> +#define SCL_FT_BIC_FIXPOINT_SHIFT 16 >> +#define SCL_FT_BIC_FIXPOINT(x) \ >> + ((INT32)((x)*(1 << SCL_FT_BIC_FIXPOINT_SHIFT))) > static inline > >> + >> +#define SCL_FT_DEFAULT_FIXPOINT_SHIFT 12 >> +#define SCL_FT_VSDBIL_FIXPOINT_SHIFT 12 >> + >> +#define SCL_CAL(src, dst, shift) \ >> + ((((src) * 2 - 3) << ((shift) - 1)) / ((dst) - 1)) >> +#define GET_SCL_FT_BILI_DN(src, dst) \ >> + SCL_CAL(src, dst, SCL_FT_BILI_DN_FIXPOINT_SHIFT) >> +#define GET_SCL_FT_BILI_UP(src, dst) \ >> + SCL_CAL(src, dst, SCL_FT_BILI_UP_FIXPOINT_SHIFT) >> +#define GET_SCL_FT_BIC(src, dst) \ >> + SCL_CAL(src, dst, SCL_FT_BIC_FIXPOINT_SHIFT) >> + >> +#define GET_SCL_DN_ACT_HEIGHT(src_h, vdmult) \ >> + (((src_h) + (vdmult) - 1) / (vdmult)) > All of the function macros above: static inline. > >> + >> +#define MIN_SCL_FT_AFTER_VSKIP 1 >> +#define GET_SCL_FT_BILI_DN_VSKIP(src_h, dst_h, vdmult) \ >> + ((GET_SCL_DN_ACT_HEIGHT((src_h), (vdmult)) == (dst_h)) \ >> + ? (GET_SCL_FT_BILI_DN((src_h), (dst_h))/(vdmult)) \ >> + : GET_SCL_FT_BILI_DN(GET_SCL_DN_ACT_HEIGHT((src_h), \ >> + (vdmult)), (dst_h))) > Static inline. > >> + >> +#define GET_SCL_FT_AVRG(src, dst) \ >> + (((dst) << ((SCL_FT_AVRG_FIXPOINT_SHIFT) + 1)) \ >> + / (2 * (src) - 1)) > Static inline. > >> + >> +#define SCL_COOR_ACC_FIXPOINT_SHIFT 16 >> +#define SCL_COOR_ACC_FIXPOINT_ONE (1 << SCL_COOR_ACC_FIXPOINT_SHIFT) >> +#define SCL_COOR_ACC_FIXPOINT(x) \ >> + ((INT32)((x)*(1 << SCL_COOR_ACC_FIXPOINT_SHIFT))) >> +#define SCL_COOR_ACC_FIXPOINT_REVERT(x) \ >> + ((((x) >> (SCL_COOR_ACC_FIXPOINT_SHIFT-1)) + 1) >> 1) >> + >> +#define SCL_GET_COOR_ACC_FIXPOINT(scale, shift) \ >> + ((scale) << (SCL_COOR_ACC_FIXPOINT_SHIFT - (shift))) >> +#define SCL_FILTER_FT_FIXPOINT_SHIFT 8 >> +#define SCL_FILTER_FT_FIXPOINT_ONE (1 << SCL_FILTER_FT_FIXPOINT_SHIFT) >> +#define SCL_FILTER_FT_FIXPOINT(x) \ >> + ((INT32)((x) * (1 << SCL_FILTER_FT_FIXPOINT_SHIFT))) >> +#define SCL_FILTER_FT_FIXPOINT_REVERT(x) \ >> + ((((x) >> (SCL_FILTER_FT_FIXPOINT_SHIFT - 1)) + 1) >> 1) >> + >> +#define SCL_GET_FILTER_FT_FIXPOINT(ca, shift) \ >> + (((ca) >> ((shift)-SCL_FILTER_FT_FIXPOINT_SHIFT)) & \ >> + (SCL_FILTER_FT_FIXPOINT_ONE - 1)) >> + >> +#define SCL_OFFSET_FIXPOINT_SHIFT 8 >> +#define SCL_OFFSET_FIXPOINT(x) \ >> + ((INT32)((x) * (1 << SCL_OFFSET_FIXPOINT_SHIFT))) > All of the function macros above: static inline. This should also let > you remove the casts. what the "casts" mean? Why do you thinking that "static inline" is better than "#define"? > Best regards, > Tomasz > > > -- ?ark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754395AbbGCJSQ (ORCPT ); Fri, 3 Jul 2015 05:18:16 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:51639 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754754AbbGCJSF (ORCPT ); Fri, 3 Jul 2015 05:18:05 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: tfiga@chromium.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <55965344.5050502@rock-chips.com> Date: Fri, 03 Jul 2015 17:17:56 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Tomasz Figa CC: dri-devel , David Airlie , Heiko Stuebner , Daniel Kurtz , Philipp Zabel , Daniel Vetter , Rob Clark , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" , sandy.huang@rock-chips.com, dkm@rock-chips.com, zwl@rock-chips.com, xw@rock-chips.com Subject: Re: [PATCH v2 3/5] drm/rockchip: vop: support plane scale References: <1435313249-4549-1-git-send-email-mark.yao@rock-chips.com> <1435313249-4549-4-git-send-email-mark.yao@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年07月03日 15:46, Tomasz Figa wrote: > Hi Mark, > > Please see my comments inline. > > On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: >> Win_full support 1/8 to 8 scale down/up engine, support >> all format scale. > [snip] > >> @@ -351,6 +412,15 @@ static inline void vop_mask_write_relaxed(struct vop *vop, uint32_t offset, >> } >> } >> >> +static inline int _get_vskiplines(uint32_t srch, uint32_t dsth) >> +{ >> + if (srch >= (uint32_t)(4 * dsth * MIN_SCL_FT_AFTER_VSKIP)) >> + return 4; >> + else if (srch >= (uint32_t)(2 * dsth * MIN_SCL_FT_AFTER_VSKIP)) >> + return 2; >> + return 1; > How about rewriting the above to: > > #define SCL_MAX_VSKIPLINES 4 > > uint32_t vskiplines; > > for (vskiplines = SCL_MAX_VSKIPLINES; vskiplines > 1; vskiplines /= 2) > if (srch >= vskiplines * dsth * MIN_SCL_FT_AFTER_VSKIP) > break; > > return vskiplines; > > nit: I believe it would be better for readability to move this > function to other scaler related functions below. > nit: I don't see any existing functions with names starting from _, so > to keep existing conventions, how about calling them scl_*, e.g. > scl_get_vskiplines(). OK >> +} >> + >> static enum vop_data_format vop_convert_format(uint32_t format) >> { >> switch (format) { >> @@ -538,6 +608,310 @@ static void vop_disable(struct drm_crtc *crtc) >> pm_runtime_put(vop->dev); >> } >> >> +static int _vop_cal_yrgb_lb_mode(int width) >> +{ >> + int lb_mode = LB_RGB_1920X5; >> + >> + if (width > 2560) >> + lb_mode = LB_RGB_3840X2; >> + else if (width > 1920) >> + lb_mode = LB_RGB_2560X4; > It would be more readable to add > > else > lb_mode = LB_RGB_1920X5; > > instead of initializing the variable at declaration time. > OK >> + >> + return lb_mode; >> +} >> + >> +static int _vop_cal_cbcr_lb_mode(int width) >> +{ >> + int lb_mode = LB_YUV_2560X8; >> + >> + if (width > 2560) >> + lb_mode = LB_RGB_3840X2; >> + else if (width > 1920) >> + lb_mode = LB_RGB_2560X4; >> + else if (width > 1280) >> + lb_mode = LB_YUV_3840X5; >> + >> + return lb_mode; >> +} >> + >> +static void _vop_cal_scl_fac(struct vop *vop, const struct vop_win_data *win, >> + uint32_t src_w, uint32_t src_h, uint32_t dst_w, >> + uint32_t dst_h, uint32_t pixel_format) >> +{ >> + uint16_t yrgb_hor_scl_mode = SCALE_NONE; >> + uint16_t yrgb_ver_scl_mode = SCALE_NONE; >> + uint16_t cbr_hor_scl_mode = SCALE_NONE; >> + uint16_t cbr_ver_scl_mode = SCALE_NONE; >> + uint16_t yrgb_hsd_mode = SCALE_DOWN_BIL; >> + uint16_t cbr_hsd_mode = SCALE_DOWN_BIL; >> + uint16_t yrgb_vsd_mode = SCALE_DOWN_BIL; >> + uint16_t cbr_vsd_mode = SCALE_DOWN_BIL; > No code seems to be assigning the 4 variables above. Is some code > missing or they are simply constants and they (and code checking their > values) are not necessary? those value directly write to the vop regs, it's necessary. >> + uint16_t yrgb_vsu_mode = SCALE_UP_BIL; >> + uint16_t cbr_vsu_mode = SCALE_UP_BIL; >> + uint16_t scale_yrgb_x = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT; >> + uint16_t scale_yrgb_y = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT; >> + uint16_t scale_cbcr_x = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT; >> + uint16_t scale_cbcr_y = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT; >> + int hsub = drm_format_horz_chroma_subsampling(pixel_format); >> + int vsub = drm_format_vert_chroma_subsampling(pixel_format); >> + bool is_yuv = is_yuv_support(pixel_format); >> + uint16_t vsd_yrgb_gt4 = 0; >> + uint16_t vsd_yrgb_gt2 = 0; >> + uint16_t vsd_cbr_gt4 = 0; >> + uint16_t vsd_cbr_gt2 = 0; >> + uint16_t yrgb_src_w = src_w; >> + uint16_t yrgb_src_h = src_h; >> + uint16_t yrgb_dst_w = dst_w; >> + uint16_t yrgb_dst_h = dst_h; >> + uint16_t cbcr_src_w; >> + uint16_t cbcr_src_h; >> + uint16_t cbcr_dst_w; >> + uint16_t cbcr_dst_h; >> + uint32_t vdmult; >> + uint16_t lb_mode; > The amount of local variables suggests that this function needs to be > split into several smaller ones. > > By the way, do you need to initialize all of them? GCC will at least > warn (if not error out) if an unitialized variable is referenced, so > it's enough to make sure that the code correctly covers all branch > paths, which is actually better for the code than to rely on default > value. Yeah, some value directly write to the vop, some value gcc report the warn, so initialize them. >> + >> + if (((yrgb_dst_w << 3) <= yrgb_src_w) || >> + ((yrgb_dst_h << 3) <= yrgb_src_h) || > Hmm, if this is enforcing the maximum downscaling factor, then > wouldn't it be more readable to write like this: > > yrgb_src_w >= 8 * yrgb_dst_w > > Also is >= correct here? Is the maximum factor less than 8? yrgb_src_w >= 8 * yrgb_dst_w means we can't scale down exceed 8, means that (src_w)1920->(dst_w)240 is wrong. >> + yrgb_dst_w > 3840) { > I'd suggest moving this to separate if with different error message. > >> + DRM_ERROR("yrgb scale exceed 8,src[%dx%d] dst[%dx%d]\n", >> + yrgb_src_w, yrgb_src_h, yrgb_dst_w, yrgb_dst_h); > Hmm, maybe "Maximum downscaling factor (8) exceeded" and then for the > destination width check "Maximum destination width (3840) exceeded"? OK. >> + return; >> + } >> + >> + if (yrgb_src_w < yrgb_dst_w) >> + yrgb_hor_scl_mode = SCALE_UP; >> + else if (yrgb_src_w > yrgb_dst_w) >> + yrgb_hor_scl_mode = SCALE_DOWN; >> + else >> + yrgb_hor_scl_mode = SCALE_NONE; > This looks like a good candidate for a helper function: > > enum scl_mode scl_get_scl_mode(uint32_t src, uint32_t dst) > { > if (src < dst) > return SCALE_UP; > else if (src > dst) > return SCALE_DOWN; > else > return SCALE_NONE; > } > OK >> + >> + if (yrgb_src_h < yrgb_dst_h) >> + yrgb_ver_scl_mode = SCALE_UP; >> + else if (yrgb_src_h > yrgb_dst_h) >> + yrgb_ver_scl_mode = SCALE_DOWN; >> + else >> + yrgb_ver_scl_mode = SCALE_NONE; > And now the helper function could be used here as well. > >> + >> + if (is_yuv) { >> + cbcr_src_w = src_w / hsub; >> + cbcr_src_h = src_h / vsub; >> + cbcr_dst_w = dst_w; >> + cbcr_dst_h = dst_h; >> + if ((cbcr_dst_w << 3) <= cbcr_src_w || >> + (cbcr_dst_h << 3) <= cbcr_src_h || >> + cbcr_src_w > 3840 || >> + cbcr_src_w == 0) >> + DRM_ERROR("cbcr scale failed,src[%dx%d] dst[%dx%d]\n", >> + cbcr_src_w, cbcr_src_h, >> + cbcr_dst_w, cbcr_dst_h); > I believe you should have those already enforced by Y plane. Also it > doesn't seem reasonable to ever get 0 src width as an argument for > this function. > >> + if (cbcr_src_w < cbcr_dst_w) >> + cbr_hor_scl_mode = SCALE_UP; >> + else if (cbcr_src_w > cbcr_dst_w) >> + cbr_hor_scl_mode = SCALE_DOWN; >> + >> + if (cbcr_src_h < cbcr_dst_h) >> + cbr_ver_scl_mode = SCALE_UP; >> + else if (cbcr_src_h > cbcr_dst_h) >> + cbr_ver_scl_mode = SCALE_DOWN; > Aren't the scl_modes for CbCr planes always the same as for Y plane? No, such as src(1920 x 1080) -> dst(1280x800), yuv format is NV12. so Y plane horizontal and vertical is scale down. but src_w = 1920 / 2 = 960 < 1280 src_h = 1080 / 2 = 540 < 800. So Cbcr horizontal and vertical is scale up. >> + } >> + /* >> + * line buffer mode >> + */ >> + if (is_yuv) { >> + if (yrgb_hor_scl_mode == SCALE_DOWN && yrgb_dst_w > 2560) >> + lb_mode = LB_RGB_3840X2; >> + else if (cbr_hor_scl_mode == SCALE_DOWN) >> + lb_mode = _vop_cal_cbcr_lb_mode(cbcr_dst_w); >> + else >> + lb_mode = _vop_cal_cbcr_lb_mode(cbcr_src_w); >> + } else { >> + if (yrgb_hor_scl_mode == SCALE_DOWN) >> + lb_mode = _vop_cal_yrgb_lb_mode(yrgb_dst_w); >> + else >> + lb_mode = _vop_cal_yrgb_lb_mode(yrgb_src_w); >> + } > I guess this could be moved into a helper function. > >> + >> + switch (lb_mode) { >> + case LB_YUV_3840X5: >> + case LB_YUV_2560X8: >> + case LB_RGB_1920X5: >> + case LB_RGB_1280X8: >> + yrgb_vsu_mode = SCALE_UP_BIC; >> + cbr_vsu_mode = SCALE_UP_BIC; > I might be overlooking something, but don't yrgb_vsu_mode and > cbr_vsu_mode always have the same values? Hmm, yrgb_vsu_mode and cbr_vsu_mode mean different vop config, OK, I think it can merge together. >> + break; >> + case LB_RGB_3840X2: >> + if (yrgb_ver_scl_mode != SCALE_NONE) >> + DRM_ERROR("ERROR : not allow yrgb ver scale\n"); >> + if (cbr_ver_scl_mode != SCALE_NONE) >> + DRM_ERROR("ERROR : not allow cbcr ver scale\n"); > Shouldn't these return error? Also it would be nice to make the error > messages more helpful. OK. >> + break; >> + case LB_RGB_2560X4: >> + yrgb_vsu_mode = SCALE_UP_BIL; >> + cbr_vsu_mode = SCALE_UP_BIL; >> + break; >> + default: >> + DRM_ERROR("unsupport lb_mode:%d\n", lb_mode); >> + break; >> + } > Anyway, this whole switch is a candidate for a helper function. This only use one time, it's ok to be a helper function? >> + /* >> + * (1.1)YRGB HOR SCALE FACTOR >> + */ >> + switch (yrgb_hor_scl_mode) { >> + case SCALE_UP: >> + scale_yrgb_x = GET_SCL_FT_BIC(yrgb_src_w, yrgb_dst_w); >> + break; >> + case SCALE_DOWN: >> + switch (yrgb_hsd_mode) { >> + case SCALE_DOWN_BIL: >> + scale_yrgb_x = GET_SCL_FT_BILI_DN(yrgb_src_w, >> + yrgb_dst_w); >> + break; >> + case SCALE_DOWN_AVG: >> + scale_yrgb_x = GET_SCL_FT_AVRG(yrgb_src_w, yrgb_dst_w); >> + break; >> + default: >> + DRM_ERROR("unsupport yrgb_hsd_mode:%d\n", >> + yrgb_hsd_mode); > Shouldn't this return an error? > >> + break; >> + } >> + break; >> + } > Ditto. > >> + >> + /* >> + * (1.2)YRGB VER SCALE FACTOR >> + */ >> + switch (yrgb_ver_scl_mode) { >> + case SCALE_UP: >> + switch (yrgb_vsu_mode) { >> + case SCALE_UP_BIL: >> + scale_yrgb_y = GET_SCL_FT_BILI_UP(yrgb_src_h, >> + yrgb_dst_h); >> + break; >> + case SCALE_UP_BIC: >> + if (yrgb_src_h < 3) >> + DRM_ERROR("yrgb_src_h should greater than 3\n"); > Shouldn't this return an error? > >> + scale_yrgb_y = GET_SCL_FT_BIC(yrgb_src_h, yrgb_dst_h); >> + break; >> + default: >> + DRM_ERROR("unsupport yrgb_vsu_mode:%d\n", >> + yrgb_vsu_mode); > Shouldn't this return an error? > >> + break; >> + } >> + break; >> + case SCALE_DOWN: >> + switch (yrgb_vsd_mode) { >> + case SCALE_DOWN_BIL: >> + vdmult = _get_vskiplines(yrgb_src_h, yrgb_dst_h); >> + scale_yrgb_y = GET_SCL_FT_BILI_DN_VSKIP(yrgb_src_h, >> + yrgb_dst_h, >> + vdmult); >> + if (vdmult == 4) { >> + vsd_yrgb_gt4 = 1; >> + vsd_yrgb_gt2 = 0; >> + } else if (vdmult == 2) { >> + vsd_yrgb_gt4 = 0; >> + vsd_yrgb_gt2 = 1; >> + } > How about something like this: > > vsd_yrgb_gt4 = (vdmult == 4); > vsd_yrgb_gt2 = (vdmult == 2); But I think it's not easy to read. >> + break; >> + case SCALE_DOWN_AVG: >> + scale_yrgb_y = GET_SCL_FT_AVRG(yrgb_src_h, yrgb_dst_h); >> + break; >> + default: >> + DRM_ERROR("unsupport yrgb_vsd_mode:%d\n", >> + yrgb_vsd_mode); > Shouldn't this return an error? > >> + break; >> + } >> + break; >> + } > Another candidate for separate helper function. > >> + /* >> + * (2.1)CBCR HOR SCALE FACTOR >> + */ >> + switch (cbr_hor_scl_mode) { >> + case SCALE_UP: >> + scale_cbcr_x = GET_SCL_FT_BIC(cbcr_src_w, cbcr_dst_w); >> + break; >> + case SCALE_DOWN: >> + switch (cbr_hsd_mode) { >> + case SCALE_DOWN_BIL: >> + scale_cbcr_x = GET_SCL_FT_BILI_DN(cbcr_src_w, >> + cbcr_dst_w); >> + break; >> + case SCALE_DOWN_AVG: >> + scale_cbcr_x = GET_SCL_FT_AVRG(cbcr_src_w, cbcr_dst_w); >> + break; >> + default: >> + DRM_ERROR("unsupport cbr_hsd_mode:%d\n", cbr_hsd_mode); > Error. > >> + break; >> + } >> + break; >> + } > Isn't this switch exactly the same as for Y plane just with different > widths used? Also, wouldn't the values for CbCr plane be the same as > for Y plane? But Cbcr case is not same as Y plane case, how to merge? >> + >> + /* >> + * (2.2)CBCR VER SCALE FACTOR >> + */ >> + switch (cbr_ver_scl_mode) { >> + case SCALE_UP: >> + switch (cbr_vsu_mode) { >> + case SCALE_UP_BIL: >> + scale_cbcr_y = GET_SCL_FT_BILI_UP(cbcr_src_h, >> + cbcr_dst_h); >> + break; >> + case SCALE_UP_BIC: >> + if (cbcr_src_h < 3) >> + DRM_ERROR("cbcr_src_h need greater than 3 !\n"); >> + scale_cbcr_y = GET_SCL_FT_BIC(cbcr_src_h, cbcr_dst_h); >> + break; >> + default: >> + DRM_ERROR("unsupport cbr_vsu_mode:%d\n", cbr_vsu_mode); > Error. > >> + break; >> + } >> + break; >> + case SCALE_DOWN: >> + switch (cbr_vsd_mode) { >> + case SCALE_DOWN_BIL: >> + vdmult = _get_vskiplines(cbcr_src_h, cbcr_dst_h); >> + scale_cbcr_y = GET_SCL_FT_BILI_DN_VSKIP(cbcr_src_h, >> + cbcr_dst_h, >> + vdmult); >> + if (vdmult == 4) { >> + vsd_cbr_gt4 = 1; >> + vsd_cbr_gt2 = 0; >> + } else if (vdmult == 2) { >> + vsd_cbr_gt4 = 0; >> + vsd_cbr_gt2 = 1; >> + } >> + break; >> + case SCALE_DOWN_AVG: >> + scale_cbcr_y = GET_SCL_FT_AVRG(cbcr_src_h, cbcr_dst_h); >> + break; >> + default: >> + DRM_ERROR("unsupport cbr_vsd_mode:%d\n", cbr_vsd_mode); >> + break; >> + } >> + break; >> + } > Again, this looks like the values for CbCr would be the same as for Y. > Are there actually cases when they differ? Hmm, Actually the cbcr calculations have some different with Y. >> + >> + VOP_SCL_SET(vop, win, yrgb_hor_scl_mode, yrgb_hor_scl_mode); >> + VOP_SCL_SET(vop, win, yrgb_ver_scl_mode, yrgb_ver_scl_mode); >> + VOP_SCL_SET(vop, win, cbr_hor_scl_mode, cbr_hor_scl_mode); >> + VOP_SCL_SET(vop, win, cbr_ver_scl_mode, cbr_ver_scl_mode); >> + VOP_SCL_SET(vop, win, lb_mode, lb_mode); >> + VOP_SCL_SET(vop, win, yrgb_hsd_mode, yrgb_hsd_mode); >> + VOP_SCL_SET(vop, win, cbr_hsd_mode, cbr_hsd_mode); >> + VOP_SCL_SET(vop, win, yrgb_vsd_mode, yrgb_vsd_mode); >> + VOP_SCL_SET(vop, win, cbr_vsd_mode, cbr_vsd_mode); >> + VOP_SCL_SET(vop, win, yrgb_vsu_mode, yrgb_vsu_mode); >> + VOP_SCL_SET(vop, win, cbr_vsu_mode, cbr_vsu_mode); >> + VOP_SCL_SET(vop, win, scale_yrgb_x, scale_yrgb_x); >> + VOP_SCL_SET(vop, win, scale_yrgb_y, scale_yrgb_y); >> + VOP_SCL_SET(vop, win, vsd_yrgb_gt4, vsd_yrgb_gt4); >> + VOP_SCL_SET(vop, win, vsd_yrgb_gt2, vsd_yrgb_gt2); >> + VOP_SCL_SET(vop, win, scale_cbcr_x, scale_cbcr_x); >> + VOP_SCL_SET(vop, win, scale_cbcr_y, scale_cbcr_y); >> + VOP_SCL_SET(vop, win, vsd_cbr_gt4, vsd_cbr_gt4); >> + VOP_SCL_SET(vop, win, vsd_cbr_gt2, vsd_cbr_gt2); > If you split this function into smaller ones, you probably don't want > to keep all the writes like here in one place, but rather make the > smaller functions write particular registers after calculating their > values. Hmm, I will try to do that. >> +} >> + >> /* >> * Caller must hold vsync_mutex. >> */ >> @@ -624,6 +998,8 @@ static int vop_update_plane_event(struct drm_plane *plane, >> .y2 = crtc->mode.vdisplay, >> }; >> bool can_position = plane->type != DRM_PLANE_TYPE_PRIMARY; >> + int min_scale = win->phy->scl ? 0x02000 : DRM_PLANE_HELPER_NO_SCALING; >> + int max_scale = win->phy->scl ? 0x80000 : DRM_PLANE_HELPER_NO_SCALING; > Hmm, I wonder if there aren't maybe some helpers to generate fixed > point values in the kernel in a readable way. If not, maybe something > like this would do: > > #define FRAC_16_16(mult, div) (((mult) << 16) / (div)) > > and then you would just use > > FRAC_16_16(1, 8) and FRAC_16_16(8, 1) for min and max scale respectively. OK. >> if (drm_format_num_planes(fb->pixel_format) > 2) { >> DRM_ERROR("unsupport more than 2 plane format[%08x]\n", >> @@ -633,8 +1009,8 @@ static int vop_update_plane_event(struct drm_plane *plane, >> >> ret = drm_plane_helper_check_update(plane, crtc, fb, >> &src, &dest, &clip, >> - DRM_PLANE_HELPER_NO_SCALING, >> - DRM_PLANE_HELPER_NO_SCALING, >> + min_scale, >> + max_scale, >> can_position, false, &visible); >> if (ret) >> return ret; >> @@ -732,9 +1108,18 @@ static int vop_update_plane_event(struct drm_plane *plane, >> VOP_WIN_SET(vop, win, uv_vir, uv_vir_stride); >> VOP_WIN_SET(vop, win, uv_mst, uv_mst); >> } >> + >> + if (win->phy->scl) >> + _vop_cal_scl_fac(vop, win, actual_w, actual_h, >> + dest.x2 - dest.x1, dest.y2 - dest.y1, >> + fb->pixel_format); > Maybe the function could be named "vop_init_scaler()". > OK >> + >> val = (actual_h - 1) << 16; >> val |= (actual_w - 1) & 0xffff; >> VOP_WIN_SET(vop, win, act_info, val); >> + >> + val = (dest.y2 - dest.y1 - 1) << 16; >> + val |= (dest.x2 - dest.x1 - 1) & 0xffff; >> VOP_WIN_SET(vop, win, dsp_info, val); >> val = (dsp_sty - 1) << 16; >> val |= (dsp_stx - 1) & 0xffff; >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h >> index 63e9b3a..edacdee 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h >> @@ -198,4 +198,100 @@ enum factor_mode { >> ALPHA_SRC_GLOBAL, >> }; >> >> +enum scale_mode { >> + SCALE_NONE = 0x0, >> + SCALE_UP = 0x1, >> + SCALE_DOWN = 0x2 >> +}; >> + >> +enum lb_mode { >> + LB_YUV_3840X5 = 0x0, >> + LB_YUV_2560X8 = 0x1, >> + LB_RGB_3840X2 = 0x2, >> + LB_RGB_2560X4 = 0x3, >> + LB_RGB_1920X5 = 0x4, >> + LB_RGB_1280X8 = 0x5 >> +}; >> + >> +enum sacle_up_mode { >> + SCALE_UP_BIL = 0x0, >> + SCALE_UP_BIC = 0x1 >> +}; >> + >> +enum scale_down_mode { >> + SCALE_DOWN_BIL = 0x0, >> + SCALE_DOWN_AVG = 0x1 >> +}; >> + >> +#define CUBIC_PRECISE 0 >> +#define CUBIC_SPLINE 1 >> +#define CUBIC_CATROM 2 >> +#define CUBIC_MITCHELL 3 >> + >> +#define CUBIC_MODE_SELETION CUBIC_PRECISE >> + >> +#define SCL_FT_BILI_DN_FIXPOINT_SHIFT 12 >> +#define SCL_FT_BILI_DN_FIXPOINT(x) \ >> + ((INT32)((x)*(1 << SCL_FT_BILI_DN_FIXPOINT_SHIFT))) > static inline > >> + >> +#define SCL_FT_BILI_UP_FIXPOINT_SHIFT 16 >> + >> +#define SCL_FT_AVRG_FIXPOINT_SHIFT 16 >> +#define SCL_FT_AVRG_FIXPOINT(x) \ >> + ((INT32)((x) * (1 << SCL_FT_AVRG_FIXPOINT_SHIFT))) > static inline > >> + >> +#define SCL_FT_BIC_FIXPOINT_SHIFT 16 >> +#define SCL_FT_BIC_FIXPOINT(x) \ >> + ((INT32)((x)*(1 << SCL_FT_BIC_FIXPOINT_SHIFT))) > static inline > >> + >> +#define SCL_FT_DEFAULT_FIXPOINT_SHIFT 12 >> +#define SCL_FT_VSDBIL_FIXPOINT_SHIFT 12 >> + >> +#define SCL_CAL(src, dst, shift) \ >> + ((((src) * 2 - 3) << ((shift) - 1)) / ((dst) - 1)) >> +#define GET_SCL_FT_BILI_DN(src, dst) \ >> + SCL_CAL(src, dst, SCL_FT_BILI_DN_FIXPOINT_SHIFT) >> +#define GET_SCL_FT_BILI_UP(src, dst) \ >> + SCL_CAL(src, dst, SCL_FT_BILI_UP_FIXPOINT_SHIFT) >> +#define GET_SCL_FT_BIC(src, dst) \ >> + SCL_CAL(src, dst, SCL_FT_BIC_FIXPOINT_SHIFT) >> + >> +#define GET_SCL_DN_ACT_HEIGHT(src_h, vdmult) \ >> + (((src_h) + (vdmult) - 1) / (vdmult)) > All of the function macros above: static inline. > >> + >> +#define MIN_SCL_FT_AFTER_VSKIP 1 >> +#define GET_SCL_FT_BILI_DN_VSKIP(src_h, dst_h, vdmult) \ >> + ((GET_SCL_DN_ACT_HEIGHT((src_h), (vdmult)) == (dst_h)) \ >> + ? (GET_SCL_FT_BILI_DN((src_h), (dst_h))/(vdmult)) \ >> + : GET_SCL_FT_BILI_DN(GET_SCL_DN_ACT_HEIGHT((src_h), \ >> + (vdmult)), (dst_h))) > Static inline. > >> + >> +#define GET_SCL_FT_AVRG(src, dst) \ >> + (((dst) << ((SCL_FT_AVRG_FIXPOINT_SHIFT) + 1)) \ >> + / (2 * (src) - 1)) > Static inline. > >> + >> +#define SCL_COOR_ACC_FIXPOINT_SHIFT 16 >> +#define SCL_COOR_ACC_FIXPOINT_ONE (1 << SCL_COOR_ACC_FIXPOINT_SHIFT) >> +#define SCL_COOR_ACC_FIXPOINT(x) \ >> + ((INT32)((x)*(1 << SCL_COOR_ACC_FIXPOINT_SHIFT))) >> +#define SCL_COOR_ACC_FIXPOINT_REVERT(x) \ >> + ((((x) >> (SCL_COOR_ACC_FIXPOINT_SHIFT-1)) + 1) >> 1) >> + >> +#define SCL_GET_COOR_ACC_FIXPOINT(scale, shift) \ >> + ((scale) << (SCL_COOR_ACC_FIXPOINT_SHIFT - (shift))) >> +#define SCL_FILTER_FT_FIXPOINT_SHIFT 8 >> +#define SCL_FILTER_FT_FIXPOINT_ONE (1 << SCL_FILTER_FT_FIXPOINT_SHIFT) >> +#define SCL_FILTER_FT_FIXPOINT(x) \ >> + ((INT32)((x) * (1 << SCL_FILTER_FT_FIXPOINT_SHIFT))) >> +#define SCL_FILTER_FT_FIXPOINT_REVERT(x) \ >> + ((((x) >> (SCL_FILTER_FT_FIXPOINT_SHIFT - 1)) + 1) >> 1) >> + >> +#define SCL_GET_FILTER_FT_FIXPOINT(ca, shift) \ >> + (((ca) >> ((shift)-SCL_FILTER_FT_FIXPOINT_SHIFT)) & \ >> + (SCL_FILTER_FT_FIXPOINT_ONE - 1)) >> + >> +#define SCL_OFFSET_FIXPOINT_SHIFT 8 >> +#define SCL_OFFSET_FIXPOINT(x) \ >> + ((INT32)((x) * (1 << SCL_OFFSET_FIXPOINT_SHIFT))) > All of the function macros above: static inline. This should also let > you remove the casts. what the "casts" mean? Why do you thinking that "static inline" is better than "#define"? > Best regards, > Tomasz > > > -- Ｍark