From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Christian_K=F6nig?= Date: Fri, 03 Jul 2015 09:38:10 +0000 Subject: Re: [patch] drm/radeon: fix underflow in r600_cp_dispatch_texture() Message-Id: <55965802.3080705@amd.com> List-Id: References: <20150703085428.GB11901@mwanda> In-Reply-To: <20150703085428.GB11901@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Dan Carpenter , Alex Deucher Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org On 03.07.2015 10:54, Dan Carpenter wrote: > The "if (pass_size > buf->total)" can underflow so I have changed the > type of size and pass_size to unsigned to avoid this problem. > > Signed-off-by: Dan Carpenter Reviewed-by: Christian K=F6nig > --- > This code is on the way out, but whatever. I may as well send this > patch since I already wrote the patch. Yeah, indeed but it will still take a while until we can really remove it. Well, maybe it's time to give it a try. Regards, Christian. > > diff --git a/drivers/gpu/drm/radeon/r600_cp.c b/drivers/gpu/drm/radeon/r6= 00_cp.c > index 09e3f39..98f9ada 100644 > --- a/drivers/gpu/drm/radeon/r600_cp.c > +++ b/drivers/gpu/drm/radeon/r600_cp.c > @@ -2483,7 +2483,7 @@ int r600_cp_dispatch_texture(struct drm_device *dev, > struct drm_buf *buf; > u32 *buffer; > const u8 __user *data; > - int size, pass_size; > + unsigned int size, pass_size; > u64 src_offset, dst_offset; > =20 > if (!radeon_check_offset(dev_priv, tex->offset)) { -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Christian_K=F6nig?= Subject: Re: [patch] drm/radeon: fix underflow in r600_cp_dispatch_texture() Date: Fri, 3 Jul 2015 11:38:10 +0200 Message-ID: <55965802.3080705@amd.com> References: <20150703085428.GB11901@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0113.outbound.protection.outlook.com [157.56.111.113]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78AB46ED35 for ; Fri, 3 Jul 2015 02:38:18 -0700 (PDT) In-Reply-To: <20150703085428.GB11901@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , Alex Deucher Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMDMuMDcuMjAxNSAxMDo1NCwgRGFuIENhcnBlbnRlciB3cm90ZToKPiBUaGUgImlmIChwYXNz X3NpemUgPiBidWYtPnRvdGFsKSIgY2FuIHVuZGVyZmxvdyBzbyBJIGhhdmUgY2hhbmdlZCB0aGUK PiB0eXBlIG9mIHNpemUgYW5kIHBhc3Nfc2l6ZSB0byB1bnNpZ25lZCB0byBhdm9pZCB0aGlzIHBy b2JsZW0uCj4KPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9y YWNsZS5jb20+CgpSZXZpZXdlZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5p Z0BhbWQuY29tPgoKPiAtLS0KPiBUaGlzIGNvZGUgaXMgb24gdGhlIHdheSBvdXQsIGJ1dCB3aGF0 ZXZlci4gIEkgbWF5IGFzIHdlbGwgc2VuZCB0aGlzCj4gcGF0Y2ggc2luY2UgSSBhbHJlYWR5IHdy b3RlIHRoZSBwYXRjaC4KClllYWgsIGluZGVlZCBidXQgaXQgd2lsbCBzdGlsbCB0YWtlIGEgd2hp bGUgdW50aWwgd2UgY2FuIHJlYWxseSByZW1vdmUgaXQuCgpXZWxsLCBtYXliZSBpdCdzIHRpbWUg dG8gZ2l2ZSBpdCBhIHRyeS4KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yNjAwX2NwLmMgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9u L3I2MDBfY3AuYwo+IGluZGV4IDA5ZTNmMzkuLjk4ZjlhZGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL3JhZGVvbi9yNjAwX2NwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9u L3I2MDBfY3AuYwo+IEBAIC0yNDgzLDcgKzI0ODMsNyBAQCBpbnQgcjYwMF9jcF9kaXNwYXRjaF90 ZXh0dXJlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gICAJc3RydWN0IGRybV9idWYgKmJ1ZjsK PiAgIAl1MzIgKmJ1ZmZlcjsKPiAgIAljb25zdCB1OCBfX3VzZXIgKmRhdGE7Cj4gLQlpbnQgc2l6 ZSwgcGFzc19zaXplOwo+ICsJdW5zaWduZWQgaW50IHNpemUsIHBhc3Nfc2l6ZTsKPiAgIAl1NjQg c3JjX29mZnNldCwgZHN0X29mZnNldDsKPiAgIAo+ICAgCWlmICghcmFkZW9uX2NoZWNrX29mZnNl dChkZXZfcHJpdiwgdGV4LT5vZmZzZXQpKSB7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=