From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] drm: remove redundant code form drm_ioc32.c Date: Fri, 03 Jul 2015 13:59:41 +0300 Message-ID: <55966B1D.4020704@linux.intel.com> References: <1435742677-14158-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20150702073218.GB23343@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id ECA2A6E2D2 for ; Fri, 3 Jul 2015 03:59:42 -0700 (PDT) In-Reply-To: <20150702073218.GB23343@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@linux.ie, dri-devel@lists.freedesktop.org, open list List-Id: dri-devel@lists.freedesktop.org CgpPbiAwNy8wMi8yMDE1IDEwOjMyIEFNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IE9uIFdlZCwg SnVsIDAxLCAyMDE1IGF0IDEyOjI0OjM3UE0gKzAzMDAsIEphcmtrbyBTYWtraW5lbiB3cm90ZToK Pj4gVGhlIGNvbXBhdCBpb2N0bCBoYW5kbGVyIGVuZHMgdXAgY2FsbGluZyBhY2Nlc3Nfb2soKSB0 d2ljZTogZmlyc3QKPj4gaW5kaXJlY3RseSBpbnNpZGUgY29tcGF0X2FsbG9jX3VzZXJfc3BhY2Uo KSBhbmQgdGhlbiBhZnRlciByZXR1cm5pbmcKPj4gZnJvbSB0aGF0IGZ1bmN0aW9uLiBUaGlzIHBh dGNoIGZpeGVzIGlzc3VlLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBKYXJra28gU2Fra2luZW4gPGph cmtrby5zYWtraW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQXBwbGllZCB0byB0b3BpYy9kcm0tbWlz YywgdGhhbmtzLiBCdHcgaXMgdGhpcyBnZW5lcmF0ZWQgd2l0aCBzb21lIGNvY2NpCj4gc2NyaXB0 IG9yIG5vdD8KCk5vcGUuIEkganVzdCBidW1wZWQgaW50byB0aGlzIHdoZW4gd29ya2luZyBvbiBv bmUgeWV0LXRvLWJlLXB1Ymxpc2hlZApkcml2ZXIgb24gYSBjb21wbGV0ZWx5IGRpZmZlcmVudCBh cmVhIGFuZCB3YXMgY29tcGFyaW5nIGNvbXBhdCBpb2N0bApoYW5kbGVycy4KCj4gLURhbmllbAo+ Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1faW9jMzIuYyB8IDU1ICsrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAy NiBpbnNlcnRpb25zKCspLCAyOSBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9kcm1faW9jMzIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faW9jMzIuYwo+PiBp bmRleCBhYThiYmI0Li43N2I2M2U3IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2lvYzMyLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9pb2MzMi5jCj4+IEBAIC05Myw3 ICs5Myw3IEBAIHN0YXRpYyBpbnQgY29tcGF0X2RybV92ZXJzaW9uKHN0cnVjdCBmaWxlICpmaWxl LCB1bnNpZ25lZCBpbnQgY21kLAo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+ICAgCj4+ICAgCXZl cnNpb24gPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShzaXplb2YoKnZlcnNpb24pKTsKPj4gLQlp ZiAoIWFjY2Vzc19vayhWRVJJRllfV1JJVEUsIHZlcnNpb24sIHNpemVvZigqdmVyc2lvbikpKQo+ PiArCWlmICghdmVyc2lvbikKPj4gICAJCXJldHVybiAtRUZBVUxUOwo+PiAgIAlpZiAoX19wdXRf dXNlcih2MzIubmFtZV9sZW4sICZ2ZXJzaW9uLT5uYW1lX2xlbikKPj4gICAJICAgIHx8IF9fcHV0 X3VzZXIoKHZvaWQgX191c2VyICopKHVuc2lnbmVkIGxvbmcpdjMyLm5hbWUsCj4+IEBAIC0xNDAs NyArMTQwLDcgQEAgc3RhdGljIGludCBjb21wYXRfZHJtX2dldHVuaXF1ZShzdHJ1Y3QgZmlsZSAq ZmlsZSwgdW5zaWduZWQgaW50IGNtZCwKPj4gICAJCXJldHVybiAtRUZBVUxUOwo+PiAgIAo+PiAg IAl1ID0gY29tcGF0X2FsbG9jX3VzZXJfc3BhY2Uoc2l6ZW9mKCp1KSk7Cj4+IC0JaWYgKCFhY2Nl c3Nfb2soVkVSSUZZX1dSSVRFLCB1LCBzaXplb2YoKnUpKSkKPj4gKwlpZiAoIXUpCj4+ICAgCQly ZXR1cm4gLUVGQVVMVDsKPj4gICAJaWYgKF9fcHV0X3VzZXIodXEzMi51bmlxdWVfbGVuLCAmdS0+ dW5pcXVlX2xlbikKPj4gICAJICAgIHx8IF9fcHV0X3VzZXIoKHZvaWQgX191c2VyICopKHVuc2ln bmVkIGxvbmcpdXEzMi51bmlxdWUsCj4+IEBAIC0xNjgsNyArMTY4LDcgQEAgc3RhdGljIGludCBj b21wYXRfZHJtX3NldHVuaXF1ZShzdHJ1Y3QgZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50IGNtZCwK Pj4gICAJCXJldHVybiAtRUZBVUxUOwo+PiAgIAo+PiAgIAl1ID0gY29tcGF0X2FsbG9jX3VzZXJf c3BhY2Uoc2l6ZW9mKCp1KSk7Cj4+IC0JaWYgKCFhY2Nlc3Nfb2soVkVSSUZZX1dSSVRFLCB1LCBz aXplb2YoKnUpKSkKPj4gKwlpZiAoIXUpCj4+ICAgCQlyZXR1cm4gLUVGQVVMVDsKPj4gICAJaWYg KF9fcHV0X3VzZXIodXEzMi51bmlxdWVfbGVuLCAmdS0+dW5pcXVlX2xlbikKPj4gICAJICAgIHx8 IF9fcHV0X3VzZXIoKHZvaWQgX191c2VyICopKHVuc2lnbmVkIGxvbmcpdXEzMi51bmlxdWUsCj4+ IEBAIC0yMDAsNyArMjAwLDcgQEAgc3RhdGljIGludCBjb21wYXRfZHJtX2dldG1hcChzdHJ1Y3Qg ZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50IGNtZCwKPj4gICAJCXJldHVybiAtRUZBVUxUOwo+PiAg IAo+PiAgIAltYXAgPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShzaXplb2YoKm1hcCkpOwo+PiAt CWlmICghYWNjZXNzX29rKFZFUklGWV9XUklURSwgbWFwLCBzaXplb2YoKm1hcCkpKQo+PiArCWlm ICghbWFwKQo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+ICAgCWlmIChfX3B1dF91c2VyKGlkeCwg Jm1hcC0+b2Zmc2V0KSkKPj4gICAJCXJldHVybiAtRUZBVUxUOwo+PiBAQCAtMjM3LDcgKzIzNyw3 IEBAIHN0YXRpYyBpbnQgY29tcGF0X2RybV9hZGRtYXAoc3RydWN0IGZpbGUgKmZpbGUsIHVuc2ln bmVkIGludCBjbWQsCj4+ICAgCQlyZXR1cm4gLUVGQVVMVDsKPj4gICAKPj4gICAJbWFwID0gY29t cGF0X2FsbG9jX3VzZXJfc3BhY2Uoc2l6ZW9mKCptYXApKTsKPj4gLQlpZiAoIWFjY2Vzc19vayhW RVJJRllfV1JJVEUsIG1hcCwgc2l6ZW9mKCptYXApKSkKPj4gKwlpZiAoIW1hcCkKPj4gICAJCXJl dHVybiAtRUZBVUxUOwo+PiAgIAlpZiAoX19wdXRfdXNlcihtMzIub2Zmc2V0LCAmbWFwLT5vZmZz ZXQpCj4+ICAgCSAgICB8fCBfX3B1dF91c2VyKG0zMi5zaXplLCAmbWFwLT5zaXplKQo+PiBAQCAt Mjc3LDcgKzI3Nyw3IEBAIHN0YXRpYyBpbnQgY29tcGF0X2RybV9ybW1hcChzdHJ1Y3QgZmlsZSAq ZmlsZSwgdW5zaWduZWQgaW50IGNtZCwKPj4gICAJCXJldHVybiAtRUZBVUxUOwo+PiAgIAo+PiAg IAltYXAgPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShzaXplb2YoKm1hcCkpOwo+PiAtCWlmICgh YWNjZXNzX29rKFZFUklGWV9XUklURSwgbWFwLCBzaXplb2YoKm1hcCkpKQo+PiArCWlmICghbWFw KQo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+ICAgCWlmIChfX3B1dF91c2VyKCh2b2lkICopKHVu c2lnbmVkIGxvbmcpaGFuZGxlLCAmbWFwLT5oYW5kbGUpKQo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7 Cj4+IEBAIC0zMDYsNyArMzA2LDcgQEAgc3RhdGljIGludCBjb21wYXRfZHJtX2dldGNsaWVudChz dHJ1Y3QgZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50IGNtZCwKPj4gICAJCXJldHVybiAtRUZBVUxU Owo+PiAgIAo+PiAgIAljbGllbnQgPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShzaXplb2YoKmNs aWVudCkpOwo+PiAtCWlmICghYWNjZXNzX29rKFZFUklGWV9XUklURSwgY2xpZW50LCBzaXplb2Yo KmNsaWVudCkpKQo+PiArCWlmICghY2xpZW50KQo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+ICAg CWlmIChfX3B1dF91c2VyKGlkeCwgJmNsaWVudC0+aWR4KSkKPj4gICAJCXJldHVybiAtRUZBVUxU Owo+PiBAQCAtMzQ1LDcgKzM0NSw3IEBAIHN0YXRpYyBpbnQgY29tcGF0X2RybV9nZXRzdGF0cyhz dHJ1Y3QgZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50IGNtZCwKPj4gICAJaW50IGksIGVycjsKPj4g ICAKPj4gICAJc3RhdHMgPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShzaXplb2YoKnN0YXRzKSk7 Cj4+IC0JaWYgKCFhY2Nlc3Nfb2soVkVSSUZZX1dSSVRFLCBzdGF0cywgc2l6ZW9mKCpzdGF0cykp KQo+PiArCWlmICghc3RhdHMpCj4+ICAgCQlyZXR1cm4gLUVGQVVMVDsKPj4gICAKPj4gICAJZXJy ID0gZHJtX2lvY3RsKGZpbGUsIERSTV9JT0NUTF9HRVRfU1RBVFMsICh1bnNpZ25lZCBsb25nKXN0 YXRzKTsKPj4gQEAgLTM4Miw4ICszODIsNyBAQCBzdGF0aWMgaW50IGNvbXBhdF9kcm1fYWRkYnVm cyhzdHJ1Y3QgZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50IGNtZCwKPj4gICAJdW5zaWduZWQgbG9u ZyBhZ3Bfc3RhcnQ7Cj4+ICAgCj4+ICAgCWJ1ZiA9IGNvbXBhdF9hbGxvY191c2VyX3NwYWNlKHNp emVvZigqYnVmKSk7Cj4+IC0JaWYgKCFhY2Nlc3Nfb2soVkVSSUZZX1dSSVRFLCBidWYsIHNpemVv ZigqYnVmKSkKPj4gLQkgICAgfHwgIWFjY2Vzc19vayhWRVJJRllfV1JJVEUsIGFyZ3AsIHNpemVv ZigqYXJncCkpKQo+PiArCWlmICghYnVmIHx8ICFhcmdwKQo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7 Cj4+ICAgCj4+ICAgCWlmIChfX2NvcHlfaW5fdXNlcihidWYsIGFyZ3AsIG9mZnNldG9mKGRybV9i dWZfZGVzYzMyX3QsIGFncF9zdGFydCkpCj4+IEBAIC00MTQsNyArNDEzLDcgQEAgc3RhdGljIGlu dCBjb21wYXRfZHJtX21hcmtidWZzKHN0cnVjdCBmaWxlICpmaWxlLCB1bnNpZ25lZCBpbnQgY21k LAo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+ICAgCj4+ICAgCWJ1ZiA9IGNvbXBhdF9hbGxvY191 c2VyX3NwYWNlKHNpemVvZigqYnVmKSk7Cj4+IC0JaWYgKCFhY2Nlc3Nfb2soVkVSSUZZX1dSSVRF LCBidWYsIHNpemVvZigqYnVmKSkpCj4+ICsJaWYgKCFidWYpCj4+ICAgCQlyZXR1cm4gLUVGQVVM VDsKPj4gICAKPj4gICAJaWYgKF9fcHV0X3VzZXIoYjMyLnNpemUsICZidWYtPnNpemUpCj4+IEBA IC00NTUsNyArNDU0LDcgQEAgc3RhdGljIGludCBjb21wYXRfZHJtX2luZm9idWZzKHN0cnVjdCBm aWxlICpmaWxlLCB1bnNpZ25lZCBpbnQgY21kLAo+PiAgIAo+PiAgIAluYnl0ZXMgPSBzaXplb2Yo KnJlcXVlc3QpICsgY291bnQgKiBzaXplb2Yoc3RydWN0IGRybV9idWZfZGVzYyk7Cj4+ICAgCXJl cXVlc3QgPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShuYnl0ZXMpOwo+PiAtCWlmICghYWNjZXNz X29rKFZFUklGWV9XUklURSwgcmVxdWVzdCwgbmJ5dGVzKSkKPj4gKwlpZiAoIXJlcXVlc3QpCj4+ ICAgCQlyZXR1cm4gLUVGQVVMVDsKPj4gICAJbGlzdCA9IChzdHJ1Y3QgZHJtX2J1Zl9kZXNjICop IChyZXF1ZXN0ICsgMSk7Cj4+ICAgCj4+IEBAIC01MTYsNyArNTE1LDcgQEAgc3RhdGljIGludCBj b21wYXRfZHJtX21hcGJ1ZnMoc3RydWN0IGZpbGUgKmZpbGUsIHVuc2lnbmVkIGludCBjbWQsCj4+ ICAgCQlyZXR1cm4gLUVJTlZBTDsKPj4gICAJbmJ5dGVzID0gc2l6ZW9mKCpyZXF1ZXN0KSArIGNv dW50ICogc2l6ZW9mKHN0cnVjdCBkcm1fYnVmX3B1Yik7Cj4+ICAgCXJlcXVlc3QgPSBjb21wYXRf YWxsb2NfdXNlcl9zcGFjZShuYnl0ZXMpOwo+PiAtCWlmICghYWNjZXNzX29rKFZFUklGWV9XUklU RSwgcmVxdWVzdCwgbmJ5dGVzKSkKPj4gKwlpZiAoIXJlcXVlc3QpCj4+ICAgCQlyZXR1cm4gLUVG QVVMVDsKPj4gICAJbGlzdCA9IChzdHJ1Y3QgZHJtX2J1Zl9wdWIgKikgKHJlcXVlc3QgKyAxKTsK Pj4gICAKPj4gQEAgLTU2Myw3ICs1NjIsNyBAQCBzdGF0aWMgaW50IGNvbXBhdF9kcm1fZnJlZWJ1 ZnMoc3RydWN0IGZpbGUgKmZpbGUsIHVuc2lnbmVkIGludCBjbWQsCj4+ICAgCQlyZXR1cm4gLUVG QVVMVDsKPj4gICAKPj4gICAJcmVxdWVzdCA9IGNvbXBhdF9hbGxvY191c2VyX3NwYWNlKHNpemVv ZigqcmVxdWVzdCkpOwo+PiAtCWlmICghYWNjZXNzX29rKFZFUklGWV9XUklURSwgcmVxdWVzdCwg c2l6ZW9mKCpyZXF1ZXN0KSkpCj4+ICsJaWYgKCFyZXF1ZXN0KQo+PiAgIAkJcmV0dXJuIC1FRkFV TFQ7Cj4+ICAgCWlmIChfX3B1dF91c2VyKHJlcTMyLmNvdW50LCAmcmVxdWVzdC0+Y291bnQpCj4+ ICAgCSAgICB8fCBfX3B1dF91c2VyKChpbnQgX191c2VyICopKHVuc2lnbmVkIGxvbmcpcmVxMzIu bGlzdCwKPj4gQEAgLTU4OSw3ICs1ODgsNyBAQCBzdGF0aWMgaW50IGNvbXBhdF9kcm1fc2V0c2Fy ZWFjdHgoc3RydWN0IGZpbGUgKmZpbGUsIHVuc2lnbmVkIGludCBjbWQsCj4+ICAgCQlyZXR1cm4g LUVGQVVMVDsKPj4gICAKPj4gICAJcmVxdWVzdCA9IGNvbXBhdF9hbGxvY191c2VyX3NwYWNlKHNp emVvZigqcmVxdWVzdCkpOwo+PiAtCWlmICghYWNjZXNzX29rKFZFUklGWV9XUklURSwgcmVxdWVz dCwgc2l6ZW9mKCpyZXF1ZXN0KSkpCj4+ICsJaWYgKCFyZXF1ZXN0KQo+PiAgIAkJcmV0dXJuIC1F RkFVTFQ7Cj4+ICAgCWlmIChfX3B1dF91c2VyKHJlcTMyLmN0eF9pZCwgJnJlcXVlc3QtPmN0eF9p ZCkKPj4gICAJICAgIHx8IF9fcHV0X3VzZXIoKHZvaWQgKikodW5zaWduZWQgbG9uZylyZXEzMi5o YW5kbGUsCj4+IEBAIC02MTMsNyArNjEyLDcgQEAgc3RhdGljIGludCBjb21wYXRfZHJtX2dldHNh cmVhY3R4KHN0cnVjdCBmaWxlICpmaWxlLCB1bnNpZ25lZCBpbnQgY21kLAo+PiAgIAkJcmV0dXJu IC1FRkFVTFQ7Cj4+ICAgCj4+ICAgCXJlcXVlc3QgPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShz aXplb2YoKnJlcXVlc3QpKTsKPj4gLQlpZiAoIWFjY2Vzc19vayhWRVJJRllfV1JJVEUsIHJlcXVl c3QsIHNpemVvZigqcmVxdWVzdCkpKQo+PiArCWlmICghcmVxdWVzdCkKPj4gICAJCXJldHVybiAt RUZBVUxUOwo+PiAgIAlpZiAoX19wdXRfdXNlcihjdHhfaWQsICZyZXF1ZXN0LT5jdHhfaWQpKQo+ PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+IEBAIC02NDYsNyArNjQ1LDcgQEAgc3RhdGljIGludCBj b21wYXRfZHJtX3Jlc2N0eChzdHJ1Y3QgZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50IGNtZCwKPj4g ICAJCXJldHVybiAtRUZBVUxUOwo+PiAgIAo+PiAgIAlyZXMgPSBjb21wYXRfYWxsb2NfdXNlcl9z cGFjZShzaXplb2YoKnJlcykpOwo+PiAtCWlmICghYWNjZXNzX29rKFZFUklGWV9XUklURSwgcmVz LCBzaXplb2YoKnJlcykpKQo+PiArCWlmICghcmVzKQo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+ ICAgCWlmIChfX3B1dF91c2VyKHJlczMyLmNvdW50LCAmcmVzLT5jb3VudCkKPj4gICAJICAgIHx8 IF9fcHV0X3VzZXIoKHN0cnVjdCBkcm1fY3R4IF9fdXNlciAqKSAodW5zaWduZWQgbG9uZylyZXMz Mi5jb250ZXh0cywKPj4gQEAgLTY4OSw3ICs2ODgsNyBAQCBzdGF0aWMgaW50IGNvbXBhdF9kcm1f ZG1hKHN0cnVjdCBmaWxlICpmaWxlLCB1bnNpZ25lZCBpbnQgY21kLAo+PiAgIAkJcmV0dXJuIC1F RkFVTFQ7Cj4+ICAgCj4+ICAgCWQgPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShzaXplb2YoKmQp KTsKPj4gLQlpZiAoIWFjY2Vzc19vayhWRVJJRllfV1JJVEUsIGQsIHNpemVvZigqZCkpKQo+PiAr CWlmICghZCkKPj4gICAJCXJldHVybiAtRUZBVUxUOwo+PiAgIAo+PiAgIAlpZiAoX19wdXRfdXNl cihkMzIuY29udGV4dCwgJmQtPmNvbnRleHQpCj4+IEBAIC03NjQsNyArNzYzLDcgQEAgc3RhdGlj IGludCBjb21wYXRfZHJtX2FncF9pbmZvKHN0cnVjdCBmaWxlICpmaWxlLCB1bnNpZ25lZCBpbnQg Y21kLAo+PiAgIAlpbnQgZXJyOwo+PiAgIAo+PiAgIAlpbmZvID0gY29tcGF0X2FsbG9jX3VzZXJf c3BhY2Uoc2l6ZW9mKCppbmZvKSk7Cj4+IC0JaWYgKCFhY2Nlc3Nfb2soVkVSSUZZX1dSSVRFLCBp bmZvLCBzaXplb2YoKmluZm8pKSkKPj4gKwlpZiAoIWluZm8pCj4+ICAgCQlyZXR1cm4gLUVGQVVM VDsKPj4gICAKPj4gICAJZXJyID0gZHJtX2lvY3RsKGZpbGUsIERSTV9JT0NUTF9BR1BfSU5GTywg KHVuc2lnbmVkIGxvbmcpaW5mbyk7Cj4+IEBAIC04MDcsNyArODA2LDcgQEAgc3RhdGljIGludCBj b21wYXRfZHJtX2FncF9hbGxvYyhzdHJ1Y3QgZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50IGNtZCwK Pj4gICAJCXJldHVybiAtRUZBVUxUOwo+PiAgIAo+PiAgIAlyZXF1ZXN0ID0gY29tcGF0X2FsbG9j X3VzZXJfc3BhY2Uoc2l6ZW9mKCpyZXF1ZXN0KSk7Cj4+IC0JaWYgKCFhY2Nlc3Nfb2soVkVSSUZZ X1dSSVRFLCByZXF1ZXN0LCBzaXplb2YoKnJlcXVlc3QpKQo+PiArCWlmICghcmVxdWVzdAo+PiAg IAkgICAgfHwgX19wdXRfdXNlcihyZXEzMi5zaXplLCAmcmVxdWVzdC0+c2l6ZSkKPj4gICAJICAg IHx8IF9fcHV0X3VzZXIocmVxMzIudHlwZSwgJnJlcXVlc3QtPnR5cGUpKQo+PiAgIAkJcmV0dXJu IC1FRkFVTFQ7Cj4+IEBAIC04MzQsNyArODMzLDcgQEAgc3RhdGljIGludCBjb21wYXRfZHJtX2Fn cF9mcmVlKHN0cnVjdCBmaWxlICpmaWxlLCB1bnNpZ25lZCBpbnQgY21kLAo+PiAgIAl1MzIgaGFu ZGxlOwo+PiAgIAo+PiAgIAlyZXF1ZXN0ID0gY29tcGF0X2FsbG9jX3VzZXJfc3BhY2Uoc2l6ZW9m KCpyZXF1ZXN0KSk7Cj4+IC0JaWYgKCFhY2Nlc3Nfb2soVkVSSUZZX1dSSVRFLCByZXF1ZXN0LCBz aXplb2YoKnJlcXVlc3QpKQo+PiArCWlmICghcmVxdWVzdAo+PiAgIAkgICAgfHwgZ2V0X3VzZXIo aGFuZGxlLCAmYXJncC0+aGFuZGxlKQo+PiAgIAkgICAgfHwgX19wdXRfdXNlcihoYW5kbGUsICZy ZXF1ZXN0LT5oYW5kbGUpKQo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+IEBAIC04NTgsNyArODU3 LDcgQEAgc3RhdGljIGludCBjb21wYXRfZHJtX2FncF9iaW5kKHN0cnVjdCBmaWxlICpmaWxlLCB1 bnNpZ25lZCBpbnQgY21kLAo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+ICAgCj4+ICAgCXJlcXVl c3QgPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShzaXplb2YoKnJlcXVlc3QpKTsKPj4gLQlpZiAo IWFjY2Vzc19vayhWRVJJRllfV1JJVEUsIHJlcXVlc3QsIHNpemVvZigqcmVxdWVzdCkpCj4+ICsJ aWYgKCFyZXF1ZXN0Cj4+ICAgCSAgICB8fCBfX3B1dF91c2VyKHJlcTMyLmhhbmRsZSwgJnJlcXVl c3QtPmhhbmRsZSkKPj4gICAJICAgIHx8IF9fcHV0X3VzZXIocmVxMzIub2Zmc2V0LCAmcmVxdWVz dC0+b2Zmc2V0KSkKPj4gICAJCXJldHVybiAtRUZBVUxUOwo+PiBAQCAtODc0LDcgKzg3Myw3IEBA IHN0YXRpYyBpbnQgY29tcGF0X2RybV9hZ3BfdW5iaW5kKHN0cnVjdCBmaWxlICpmaWxlLCB1bnNp Z25lZCBpbnQgY21kLAo+PiAgIAl1MzIgaGFuZGxlOwo+PiAgIAo+PiAgIAlyZXF1ZXN0ID0gY29t cGF0X2FsbG9jX3VzZXJfc3BhY2Uoc2l6ZW9mKCpyZXF1ZXN0KSk7Cj4+IC0JaWYgKCFhY2Nlc3Nf b2soVkVSSUZZX1dSSVRFLCByZXF1ZXN0LCBzaXplb2YoKnJlcXVlc3QpKQo+PiArCWlmICghcmVx dWVzdAo+PiAgIAkgICAgfHwgZ2V0X3VzZXIoaGFuZGxlLCAmYXJncC0+aGFuZGxlKQo+PiAgIAkg ICAgfHwgX19wdXRfdXNlcihoYW5kbGUsICZyZXF1ZXN0LT5oYW5kbGUpKQo+PiAgIAkJcmV0dXJu IC1FRkFVTFQ7Cj4+IEBAIC04OTcsOCArODk2LDcgQEAgc3RhdGljIGludCBjb21wYXRfZHJtX3Nn X2FsbG9jKHN0cnVjdCBmaWxlICpmaWxlLCB1bnNpZ25lZCBpbnQgY21kLAo+PiAgIAl1bnNpZ25l ZCBsb25nIHg7Cj4+ICAgCj4+ICAgCXJlcXVlc3QgPSBjb21wYXRfYWxsb2NfdXNlcl9zcGFjZShz aXplb2YoKnJlcXVlc3QpKTsKPj4gLQlpZiAoIWFjY2Vzc19vayhWRVJJRllfV1JJVEUsIHJlcXVl c3QsIHNpemVvZigqcmVxdWVzdCkpCj4+IC0JICAgIHx8ICFhY2Nlc3Nfb2soVkVSSUZZX1dSSVRF LCBhcmdwLCBzaXplb2YoKmFyZ3ApKQo+PiArCWlmICghcmVxdWVzdCB8fCAhYXJncAo+PiAgIAkg ICAgfHwgX19nZXRfdXNlcih4LCAmYXJncC0+c2l6ZSkKPj4gICAJICAgIHx8IF9fcHV0X3VzZXIo eCwgJnJlcXVlc3QtPnNpemUpKQo+PiAgIAkJcmV0dXJuIC1FRkFVTFQ7Cj4+IEBAIC05MjMsOCAr OTIxLDcgQEAgc3RhdGljIGludCBjb21wYXRfZHJtX3NnX2ZyZWUoc3RydWN0IGZpbGUgKmZpbGUs IHVuc2lnbmVkIGludCBjbWQsCj4+ICAgCXVuc2lnbmVkIGxvbmcgeDsKPj4gICAKPj4gICAJcmVx dWVzdCA9IGNvbXBhdF9hbGxvY191c2VyX3NwYWNlKHNpemVvZigqcmVxdWVzdCkpOwo+PiAtCWlm ICghYWNjZXNzX29rKFZFUklGWV9XUklURSwgcmVxdWVzdCwgc2l6ZW9mKCpyZXF1ZXN0KSkKPj4g LQkgICAgfHwgIWFjY2Vzc19vayhWRVJJRllfV1JJVEUsIGFyZ3AsIHNpemVvZigqYXJncCkpCj4+ ICsJaWYgKCFyZXF1ZXN0IHx8ICFhcmdwCj4+ICAgCSAgICB8fCBfX2dldF91c2VyKHgsICZhcmdw LT5oYW5kbGUpCj4+ICAgCSAgICB8fCBfX3B1dF91c2VyKHggPDwgUEFHRV9TSElGVCwgJnJlcXVl c3QtPmhhbmRsZSkpCj4+ICAgCQlyZXR1cm4gLUVGQVVMVDsKPj4gQEAgLTk1Miw3ICs5NDksNyBA QCBzdGF0aWMgaW50IGNvbXBhdF9kcm1fdXBkYXRlX2RyYXcoc3RydWN0IGZpbGUgKmZpbGUsIHVu c2lnbmVkIGludCBjbWQsCj4+ICAgCQlyZXR1cm4gLUVGQVVMVDsKPj4gICAKPj4gICAJcmVxdWVz dCA9IGNvbXBhdF9hbGxvY191c2VyX3NwYWNlKHNpemVvZigqcmVxdWVzdCkpOwo+PiAtCWlmICgh YWNjZXNzX29rKFZFUklGWV9XUklURSwgcmVxdWVzdCwgc2l6ZW9mKCpyZXF1ZXN0KSkgfHwKPj4g KwlpZiAoIXJlcXVlc3QgfHwKPj4gICAJICAgIF9fcHV0X3VzZXIodXBkYXRlMzIuaGFuZGxlLCAm cmVxdWVzdC0+aGFuZGxlKSB8fAo+PiAgIAkgICAgX19wdXRfdXNlcih1cGRhdGUzMi50eXBlLCAm cmVxdWVzdC0+dHlwZSkgfHwKPj4gICAJICAgIF9fcHV0X3VzZXIodXBkYXRlMzIubnVtLCAmcmVx dWVzdC0+bnVtKSB8fAo+PiBAQCAtOTk0LDcgKzk5MSw3IEBAIHN0YXRpYyBpbnQgY29tcGF0X2Ry bV93YWl0X3ZibGFuayhzdHJ1Y3QgZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50IGNtZCwKPj4gICAJ CXJldHVybiAtRUZBVUxUOwo+PiAgIAo+PiAgIAlyZXF1ZXN0ID0gY29tcGF0X2FsbG9jX3VzZXJf c3BhY2Uoc2l6ZW9mKCpyZXF1ZXN0KSk7Cj4+IC0JaWYgKCFhY2Nlc3Nfb2soVkVSSUZZX1dSSVRF LCByZXF1ZXN0LCBzaXplb2YoKnJlcXVlc3QpKQo+PiArCWlmICghcmVxdWVzdAo+PiAgIAkgICAg fHwgX19wdXRfdXNlcihyZXEzMi5yZXF1ZXN0LnR5cGUsICZyZXF1ZXN0LT5yZXF1ZXN0LnR5cGUp Cj4+ICAgCSAgICB8fCBfX3B1dF91c2VyKHJlcTMyLnJlcXVlc3Quc2VxdWVuY2UsICZyZXF1ZXN0 LT5yZXF1ZXN0LnNlcXVlbmNlKQo+PiAgIAkgICAgfHwgX19wdXRfdXNlcihyZXEzMi5yZXF1ZXN0 LnNpZ25hbCwgJnJlcXVlc3QtPnJlcXVlc3Quc2lnbmFsKSkKPj4gLS0gCj4+IDIuMS40Cj4+Cj4+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IGRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKPj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCi9K YXJra28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754746AbbGCK7v (ORCPT ); Fri, 3 Jul 2015 06:59:51 -0400 Received: from mga01.intel.com ([192.55.52.88]:3657 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755052AbbGCK7n (ORCPT ); Fri, 3 Jul 2015 06:59:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,399,1432623600"; d="scan'208";a="739979358" Message-ID: <55966B1D.4020704@linux.intel.com> Date: Fri, 03 Jul 2015 13:59:41 +0300 From: Jarkko Sakkinen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: airlied@linux.ie, dri-devel@lists.freedesktop.org, open list Subject: Re: [PATCH] drm: remove redundant code form drm_ioc32.c References: <1435742677-14158-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20150702073218.GB23343@phenom.ffwll.local> In-Reply-To: <20150702073218.GB23343@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2015 10:32 AM, Daniel Vetter wrote: > On Wed, Jul 01, 2015 at 12:24:37PM +0300, Jarkko Sakkinen wrote: >> The compat ioctl handler ends up calling access_ok() twice: first >> indirectly inside compat_alloc_user_space() and then after returning >> from that function. This patch fixes issue. >> >> Signed-off-by: Jarkko Sakkinen > Applied to topic/drm-misc, thanks. Btw is this generated with some cocci > script or not? Nope. I just bumped into this when working on one yet-to-be-published driver on a completely different area and was comparing compat ioctl handlers. > -Daniel > >> --- >> drivers/gpu/drm/drm_ioc32.c | 55 +++++++++++++++++++++------------------------ >> 1 file changed, 26 insertions(+), 29 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c >> index aa8bbb4..77b63e7 100644 >> --- a/drivers/gpu/drm/drm_ioc32.c >> +++ b/drivers/gpu/drm/drm_ioc32.c >> @@ -93,7 +93,7 @@ static int compat_drm_version(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> version = compat_alloc_user_space(sizeof(*version)); >> - if (!access_ok(VERIFY_WRITE, version, sizeof(*version))) >> + if (!version) >> return -EFAULT; >> if (__put_user(v32.name_len, &version->name_len) >> || __put_user((void __user *)(unsigned long)v32.name, >> @@ -140,7 +140,7 @@ static int compat_drm_getunique(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> u = compat_alloc_user_space(sizeof(*u)); >> - if (!access_ok(VERIFY_WRITE, u, sizeof(*u))) >> + if (!u) >> return -EFAULT; >> if (__put_user(uq32.unique_len, &u->unique_len) >> || __put_user((void __user *)(unsigned long)uq32.unique, >> @@ -168,7 +168,7 @@ static int compat_drm_setunique(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> u = compat_alloc_user_space(sizeof(*u)); >> - if (!access_ok(VERIFY_WRITE, u, sizeof(*u))) >> + if (!u) >> return -EFAULT; >> if (__put_user(uq32.unique_len, &u->unique_len) >> || __put_user((void __user *)(unsigned long)uq32.unique, >> @@ -200,7 +200,7 @@ static int compat_drm_getmap(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> map = compat_alloc_user_space(sizeof(*map)); >> - if (!access_ok(VERIFY_WRITE, map, sizeof(*map))) >> + if (!map) >> return -EFAULT; >> if (__put_user(idx, &map->offset)) >> return -EFAULT; >> @@ -237,7 +237,7 @@ static int compat_drm_addmap(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> map = compat_alloc_user_space(sizeof(*map)); >> - if (!access_ok(VERIFY_WRITE, map, sizeof(*map))) >> + if (!map) >> return -EFAULT; >> if (__put_user(m32.offset, &map->offset) >> || __put_user(m32.size, &map->size) >> @@ -277,7 +277,7 @@ static int compat_drm_rmmap(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> map = compat_alloc_user_space(sizeof(*map)); >> - if (!access_ok(VERIFY_WRITE, map, sizeof(*map))) >> + if (!map) >> return -EFAULT; >> if (__put_user((void *)(unsigned long)handle, &map->handle)) >> return -EFAULT; >> @@ -306,7 +306,7 @@ static int compat_drm_getclient(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> client = compat_alloc_user_space(sizeof(*client)); >> - if (!access_ok(VERIFY_WRITE, client, sizeof(*client))) >> + if (!client) >> return -EFAULT; >> if (__put_user(idx, &client->idx)) >> return -EFAULT; >> @@ -345,7 +345,7 @@ static int compat_drm_getstats(struct file *file, unsigned int cmd, >> int i, err; >> >> stats = compat_alloc_user_space(sizeof(*stats)); >> - if (!access_ok(VERIFY_WRITE, stats, sizeof(*stats))) >> + if (!stats) >> return -EFAULT; >> >> err = drm_ioctl(file, DRM_IOCTL_GET_STATS, (unsigned long)stats); >> @@ -382,8 +382,7 @@ static int compat_drm_addbufs(struct file *file, unsigned int cmd, >> unsigned long agp_start; >> >> buf = compat_alloc_user_space(sizeof(*buf)); >> - if (!access_ok(VERIFY_WRITE, buf, sizeof(*buf)) >> - || !access_ok(VERIFY_WRITE, argp, sizeof(*argp))) >> + if (!buf || !argp) >> return -EFAULT; >> >> if (__copy_in_user(buf, argp, offsetof(drm_buf_desc32_t, agp_start)) >> @@ -414,7 +413,7 @@ static int compat_drm_markbufs(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> buf = compat_alloc_user_space(sizeof(*buf)); >> - if (!access_ok(VERIFY_WRITE, buf, sizeof(*buf))) >> + if (!buf) >> return -EFAULT; >> >> if (__put_user(b32.size, &buf->size) >> @@ -455,7 +454,7 @@ static int compat_drm_infobufs(struct file *file, unsigned int cmd, >> >> nbytes = sizeof(*request) + count * sizeof(struct drm_buf_desc); >> request = compat_alloc_user_space(nbytes); >> - if (!access_ok(VERIFY_WRITE, request, nbytes)) >> + if (!request) >> return -EFAULT; >> list = (struct drm_buf_desc *) (request + 1); >> >> @@ -516,7 +515,7 @@ static int compat_drm_mapbufs(struct file *file, unsigned int cmd, >> return -EINVAL; >> nbytes = sizeof(*request) + count * sizeof(struct drm_buf_pub); >> request = compat_alloc_user_space(nbytes); >> - if (!access_ok(VERIFY_WRITE, request, nbytes)) >> + if (!request) >> return -EFAULT; >> list = (struct drm_buf_pub *) (request + 1); >> >> @@ -563,7 +562,7 @@ static int compat_drm_freebufs(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request))) >> + if (!request) >> return -EFAULT; >> if (__put_user(req32.count, &request->count) >> || __put_user((int __user *)(unsigned long)req32.list, >> @@ -589,7 +588,7 @@ static int compat_drm_setsareactx(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request))) >> + if (!request) >> return -EFAULT; >> if (__put_user(req32.ctx_id, &request->ctx_id) >> || __put_user((void *)(unsigned long)req32.handle, >> @@ -613,7 +612,7 @@ static int compat_drm_getsareactx(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request))) >> + if (!request) >> return -EFAULT; >> if (__put_user(ctx_id, &request->ctx_id)) >> return -EFAULT; >> @@ -646,7 +645,7 @@ static int compat_drm_resctx(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> res = compat_alloc_user_space(sizeof(*res)); >> - if (!access_ok(VERIFY_WRITE, res, sizeof(*res))) >> + if (!res) >> return -EFAULT; >> if (__put_user(res32.count, &res->count) >> || __put_user((struct drm_ctx __user *) (unsigned long)res32.contexts, >> @@ -689,7 +688,7 @@ static int compat_drm_dma(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> d = compat_alloc_user_space(sizeof(*d)); >> - if (!access_ok(VERIFY_WRITE, d, sizeof(*d))) >> + if (!d) >> return -EFAULT; >> >> if (__put_user(d32.context, &d->context) >> @@ -764,7 +763,7 @@ static int compat_drm_agp_info(struct file *file, unsigned int cmd, >> int err; >> >> info = compat_alloc_user_space(sizeof(*info)); >> - if (!access_ok(VERIFY_WRITE, info, sizeof(*info))) >> + if (!info) >> return -EFAULT; >> >> err = drm_ioctl(file, DRM_IOCTL_AGP_INFO, (unsigned long)info); >> @@ -807,7 +806,7 @@ static int compat_drm_agp_alloc(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request)) >> + if (!request >> || __put_user(req32.size, &request->size) >> || __put_user(req32.type, &request->type)) >> return -EFAULT; >> @@ -834,7 +833,7 @@ static int compat_drm_agp_free(struct file *file, unsigned int cmd, >> u32 handle; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request)) >> + if (!request >> || get_user(handle, &argp->handle) >> || __put_user(handle, &request->handle)) >> return -EFAULT; >> @@ -858,7 +857,7 @@ static int compat_drm_agp_bind(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request)) >> + if (!request >> || __put_user(req32.handle, &request->handle) >> || __put_user(req32.offset, &request->offset)) >> return -EFAULT; >> @@ -874,7 +873,7 @@ static int compat_drm_agp_unbind(struct file *file, unsigned int cmd, >> u32 handle; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request)) >> + if (!request >> || get_user(handle, &argp->handle) >> || __put_user(handle, &request->handle)) >> return -EFAULT; >> @@ -897,8 +896,7 @@ static int compat_drm_sg_alloc(struct file *file, unsigned int cmd, >> unsigned long x; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request)) >> - || !access_ok(VERIFY_WRITE, argp, sizeof(*argp)) >> + if (!request || !argp >> || __get_user(x, &argp->size) >> || __put_user(x, &request->size)) >> return -EFAULT; >> @@ -923,8 +921,7 @@ static int compat_drm_sg_free(struct file *file, unsigned int cmd, >> unsigned long x; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request)) >> - || !access_ok(VERIFY_WRITE, argp, sizeof(*argp)) >> + if (!request || !argp >> || __get_user(x, &argp->handle) >> || __put_user(x << PAGE_SHIFT, &request->handle)) >> return -EFAULT; >> @@ -952,7 +949,7 @@ static int compat_drm_update_draw(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request)) || >> + if (!request || >> __put_user(update32.handle, &request->handle) || >> __put_user(update32.type, &request->type) || >> __put_user(update32.num, &request->num) || >> @@ -994,7 +991,7 @@ static int compat_drm_wait_vblank(struct file *file, unsigned int cmd, >> return -EFAULT; >> >> request = compat_alloc_user_space(sizeof(*request)); >> - if (!access_ok(VERIFY_WRITE, request, sizeof(*request)) >> + if (!request >> || __put_user(req32.request.type, &request->request.type) >> || __put_user(req32.request.sequence, &request->request.sequence) >> || __put_user(req32.request.signal, &request->request.signal)) >> -- >> 2.1.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel /Jarkko