From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755130AbbGCNgz (ORCPT ); Fri, 3 Jul 2015 09:36:55 -0400 Received: from mga11.intel.com ([192.55.52.93]:2825 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755177AbbGCNgs (ORCPT ); Fri, 3 Jul 2015 09:36:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,400,1432623600"; d="scan'208";a="722394682" Message-ID: <559690AE.5050507@linux.intel.com> Date: Fri, 03 Jul 2015 16:39:58 +0300 From: Mathias Nyman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Reyad Attiyat , Mathias Nyman CC: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg transfers References: <1435863269-2872-1-git-send-email-reyad.attiyat@gmail.com> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.07.2015 22:00, Reyad Attiyat wrote: > This version of the patch changes last_trb varible name to > last_trb_num and fixes code style. I have also added a td to the urb > td array. This now gets prepared properl,y with prepare_transfer(), > and is handled correctly when transferred and completed. It only calls > the urb completion callback once as there is a check in finish_td() to > ensure that all td's have been received. > > If you think I should change anything else please let me know. > > Thank you, > Reyad Attiyat > > On Thu, Jul 2, 2015 at 1:54 PM, Reyad Attiyat wrote: >> This commit checks for the URB_ZERO_PACKET flag and creates an extra >> zero-length td if the urb transfer length is a multiple of the endpoint's >> max packet length. >> >> Signed-off-by: Reyad Attiyat >> --- Looks good, Thank you I assume it works with your wireless card? I'll go on a two weeks vacation starting now, but after that I'll send it forward. (it should go to usb-next and reach 4.3 kernel anyway) -Mathias