Re: [PATCH] state: fix range check on uint8 and uint32 variables

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1112 bytes --]

On 07/03/2015 04:07 PM, Marc Kleine-Budde wrote:
> The patch "8bfd06f073c8 state: uint8: add range check for uint8" as applied not
> correctly to the repository. It was supposed to change the state_uint8_create()
> function:
> 
> |  static struct state_variable *state_uint8_create(struct state *state,
> |
> |  	su32 = xzalloc(sizeof(*su32));
> |
> | -	param = dev_add_param_int(&state->dev, name, state_set_dirty,
> | -				  NULL, &su32->value, "%u", state);
> | +	param = dev_add_param_int(&state->dev, name, state_uint8_set,
> | +				  NULL, &su32->value, "%u", su32);
> 
> but the state_uint32_create() was changed instead, which leads to broken range
> checks on uint32 variables and no range checks on uint8. This patch fixes the
> problem.

Doh! I forgot the second part to the patch - will send v2.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox