From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v5 10/16] x86/hvm: only call hvm_io_assist()
	from hvm_wait_for_io()
Date: Fri, 3 Jul 2015 16:03:10 +0100
Message-ID: <5596A42E.2080602@citrix.com>
References: <1435669558-5421-1-git-send-email-paul.durrant@citrix.com>
	<1435669558-5421-11-git-send-email-paul.durrant@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=619030a5f=Andrew.Cooper3@citrix.com>)
	id 1ZB2Um-0005u3-1T
	for xen-devel@lists.xenproject.org; Fri, 03 Jul 2015 15:03:16 +0000
In-Reply-To: <1435669558-5421-11-git-send-email-paul.durrant@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Paul Durrant <paul.durrant@citrix.com>, xen-devel@lists.xenproject.org
Cc: Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 30/06/15 14:05, Paul Durrant wrote:
> diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c
> index 11b6028..f84f7c5 100644
> --- a/xen/arch/x86/hvm/intercept.c
> +++ b/xen/arch/x86/hvm/intercept.c
> @@ -119,8 +119,8 @@ static const struct hvm_io_ops portio_ops = {
>      .write = hvm_portio_write
>  };
>  
> -static int hvm_process_io_intercept(const struct hvm_io_handler *handler,
> -                                    ioreq_t *p)
> +int hvm_process_io_intercept(const struct hvm_io_handler *handler,
> +                             ioreq_t *p)

Again, I would suggest introducing this as a global function straight
away, to reduce the eventual churn.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>