From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
Christoph Hellwig <hch@infradead.org>,
Sagi Grimberg <sagig@mellanox.com>
Cc: "target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH RFC] target: Use scsi helpers to build the sense data correctly
Date: Sun, 5 Jul 2015 10:00:53 +0300 [thread overview]
Message-ID: <5598D625.5090900@dev.mellanox.co.il> (raw)
In-Reply-To: <55980055.3010007@sandisk.com>
On 7/4/2015 6:48 PM, Bart Van Assche wrote:
>>> Bart, any chance you could resend them?
>>>
>>
>> Bart, would you prefer to re-send your changes on top of v1 of this one?
>> It should be easy enough.
>>
>> The modification needed is that struct sense_info needs a desc_format
>> bool to indicate if the sense data is constructed in a descriptor
>> format sense data or not.
>
> Hello Sagi,
>
> Since Christoph asked you to rework your patch, let's start with the
> patches about which there is no discussion. I will post the first two
> patches referred to above next week. The third patch referred to by
> Christoph needs more thought before I can send it upstream.
OK, I converted my patch to apply over your patches. If you don't mind,
I will post them together with my patch so Nic won't need to handle the
dependencies?
Sagi.
prev parent reply other threads:[~2015-07-05 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 15:05 [PATCH RFC] target: Use scsi helpers to build the sense data correctly Sagi Grimberg
2015-07-03 16:12 ` Christoph Hellwig
2015-07-04 10:48 ` Sagi Grimberg
2015-07-04 15:48 ` Bart Van Assche
2015-07-05 7:00 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5598D625.5090900@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.