All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Handle NW DETACH and ME DETACH
Date: Sun, 05 Jul 2015 05:53:09 -0500	[thread overview]
Message-ID: <55990C95.6040205@gmail.com> (raw)
In-Reply-To: <1435913014-22733-1-git-send-email-marko.sulejic@hale.at>

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Hi Marko,

On 07/03/2015 03:43 AM, Marko Sulejic wrote:
> From: August Mayer <august.mayer@hale.at>
>
>   * According to the Telit AT reference, NW DETACH and ME DETACH
>     imply network deactivation.

Can you please include some description of why this patch is needed? 
E.g. what exceptional conditions is this supposed to be taking care of. 
  If it is Telit specific, then it should be behind logic testing for 
the TELIT vendor quirk.

Also, do realize that PPP session will be terminated by via LCP or by 
using the NO CARRIER final result code.  This logic is (in theory at 
least) redundant.

Regards,
-Denis

      reply	other threads:[~2015-07-05 10:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-03  8:43 [PATCH] Handle NW DETACH and ME DETACH Marko Sulejic
2015-07-05 10:53 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55990C95.6040205@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.