All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Tomasz Duszynski <tduszyns@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: pressure: ms5611: remove IIO_CHAN_INFO_SCALE from mask
Date: Sun, 05 Jul 2015 14:31:56 +0100	[thread overview]
Message-ID: <559931CC.4030809@kernel.org> (raw)
In-Reply-To: <1435085148-12404-1-git-send-email-tduszyns@gmail.com>

On 23/06/15 19:45, Tomasz Duszynski wrote:
> IIO_CHAN_INFO_SCALE is useful whenever conversion to standard units is done
> in userspace. In this case conversion is handled by driver so this bit
> is unnecessary.
> 
> Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
Applied to the togreg branch of iio.git

Thanks,
> ---
>  drivers/iio/pressure/ms5611_core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/pressure/ms5611_core.c b/drivers/iio/pressure/ms5611_core.c
> index e42c853..1109513 100644
> --- a/drivers/iio/pressure/ms5611_core.c
> +++ b/drivers/iio/pressure/ms5611_core.c
> @@ -163,13 +163,11 @@ static int ms5611_read_raw(struct iio_dev *indio_dev,
>  static const struct iio_chan_spec ms5611_channels[] = {
>  	{
>  		.type = IIO_PRESSURE,
> -		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) |
> -			BIT(IIO_CHAN_INFO_SCALE)
> +		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED),
>  	},
>  	{
>  		.type = IIO_TEMP,
> -		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) |
> -			BIT(IIO_CHAN_INFO_SCALE)
> +		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED),
>  	}
>  };
>  
> 


      parent reply	other threads:[~2015-07-05 13:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 18:45 [PATCH 1/2] iio: pressure: ms5611: remove IIO_CHAN_INFO_SCALE from mask Tomasz Duszynski
2015-06-23 18:45 ` [PATCH 2/2] iio: pressure: ms5611: add support for MS5607 temperature and pressure sensor Tomasz Duszynski
2015-07-05 13:35   ` Jonathan Cameron
2015-07-05 13:31 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559931CC.4030809@kernel.org \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=tduszyns@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.