Re: [Qemu-devel] [PATCH 1/2] arm_mptimer: Fix timer shutdown and mode change

[Dmitry Osipenko <digetx@gmail.com>]

06.07.2015 00:19, Peter Crosthwaite пишет:
> On Sun, Jul 5, 2015 at 8:39 AM, Dmitry Osipenko <digetx@gmail.com> wrote:
>> Timer, running in periodic mode, can't be stopped or coming one-shot
>> tick won't be canceled because timer control code just doesn't handle
>> timer disabling. Fix it by deleting the timer if enable bit isn't set.
>>
> You don't need to itemize one-shot and periodic separately, disabling
> the running timer just doesn't work universally.
>

Fair enough.


>> Timer won't start periodic ticking if ONE-SHOT -> PERIODIC mode change
>> happened after one-shot tick was completed. Fix it by starting ticking
>> only if the timer isn't ticking right now.
>>
>
> Needs some grammar work. Try:
>
> The running timer can't be stopped because timer control code just
> doesn't handle disabling the timer. Fix it by deleting the timer if
> the enable bit is cleared.
>
> The timer won't start periodic ticking if a ONE-SHOT -> PERIODIC mode
> change happens after a one-shot tick was completed. Fix it by
> re-starting ticking if the timer isn't ticking right now.
>
> Otherwise:
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
> Regards,
> Peter
>

Sounds good, I'll pick it. Thanks.

-- 
Dmitry