From: Hannes Reinecke <hare@suse.de>
To: Sagi Grimberg <sagig@mellanox.com>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v1 1/3] target: Inline transport_get_sense_codes()
Date: Mon, 06 Jul 2015 08:04:57 +0200 [thread overview]
Message-ID: <559A1A89.2090904@suse.de> (raw)
In-Reply-To: <1436081471-667-2-git-send-email-sagig@mellanox.com>
On 07/05/2015 09:31 AM, Sagi Grimberg wrote:
> From: Bart Van Assche <bart.vanassche@sandisk.com>
>
> Inline this function in its call site since it performs a trivial
> task and since it is only called once.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> ---
> drivers/target/target_core_transport.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-07-06 6:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 7:31 [PATCH v1 0/3] Target sense data handling modifications Sagi Grimberg
2015-07-05 7:31 ` [PATCH v1 1/3] target: Inline transport_get_sense_codes() Sagi Grimberg
2015-07-06 6:04 ` Hannes Reinecke [this message]
2015-07-05 7:31 ` [PATCH v1 2/3] target: Split transport_send_check_condition_and_sense() Sagi Grimberg
2015-07-06 6:06 ` Hannes Reinecke
2015-07-05 7:31 ` [PATCH v1 3/3] target: Use scsi helpers to build the sense data correctly Sagi Grimberg
2015-07-06 6:08 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559A1A89.2090904@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.