From: Sudeep Holla <sudeep.holla@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_fdt: save fdtaddr in hex format
Date: Mon, 06 Jul 2015 09:47:03 +0100 [thread overview]
Message-ID: <559A4087.5040500@arm.com> (raw)
In-Reply-To: <CAPnjgZ1c_0OzxKXitLdYHzm+EckHZJ5U16jLWLHjAN=rmTSoAQ@mail.gmail.com>
Hi Simon,
On 04/07/15 00:06, Simon Glass wrote:
> Hi Sudeep,
>
> On 3 July 2015 at 11:29, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> Commit 90fbee3e4051 ("cmd_fdt: Actually fix fdt command in sandbox")
>> changed the format(from hex address to unsigned long) in which "fdtaddr"
>> is saved . However do_fdt continues reads the "fdtaddr" assuming it to
>> be in hex format. This may lead to fdt being either loaded or attempted
>> to load at erroneous address generating fault if the address is out of
>> memory.
>>
>> This patch changes back the format to hex while saving the "fdtaddr"
>> as it was done before.
>>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Hua Yanghao <huayanghao@gmail.com>
>> Cc: Heiko Schocher <hs@denx.de>
>> ---
>> common/cmd_fdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Hi,
>>
>> You will see my signoff missing and it's intentional as I officially
>> can't contribute to Uboot. I found this issue and it's been there for a
>> while now, so thought of atleast reporting it(with a patch). So if anyone
>> can review and submit this or any appropriate fix that would be great.
>> I see this issue on vexpress TC2.
>
> We can't take this without a sign-off - what stops you from adding it exactly?
>
Unfortunately it's not in the list of legally approved projects I can
contribute. So I am bound not to do so legally.
Hi Linus,
Since you did a lot work on vexpress/Juno quite recently on ARM's
request, can you cook up a similar patch to fix the above mentioned
issue if that's OK for you ?
Regards,
Sudeep
next prev parent reply other threads:[~2015-07-06 8:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 17:29 [U-Boot] [PATCH] cmd_fdt: save fdtaddr in hex format Sudeep Holla
2015-07-03 23:06 ` Simon Glass
2015-07-06 8:47 ` Sudeep Holla [this message]
2015-07-10 16:18 ` Sudeep Holla
2015-07-10 23:08 ` Simon Glass
2015-07-16 13:26 ` Linus Walleij
2015-07-16 16:34 ` Simon Glass
2015-07-20 13:25 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559A4087.5040500@arm.com \
--to=sudeep.holla@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.