Re: [Qemu-devel] [PATCH] target-ppc: fix hugepage support when using memory-backend-file

[Alexander Graf <agraf@suse.de>]

On 07/03/15 09:18, David Gibson wrote:
> On Thu, Jul 02, 2015 at 03:46:14PM -0500, Michael Roth wrote:
>> Current PPC code relies on -mem-path being used in order for
>> hugepage support to be detected. With the introduction of
>> MemoryBackendFile we can now handle this via:
>>    -object memory-file-backend,mem-path=...,id=hugemem0 \
>>    -numa node,id=mem0,memdev=hugemem0
>>
>> Management tools like libvirt treat the 2 approaches as
>> interchangeable in some cases, which can lead to user-visible
>> regressions even for previously supported guest configurations.
>>
>> Fix these by also iterating through any configured memory
>> backends that may be backed by hugepages.
>>
>> Since the old code assumed hugepages always backed the entirety
>> of guest memory, play it safe an pick the minimum across the
>> max pages sizes for all backends, even ones that aren't backed
>> by hugepages.
>>
>> Cc: qemu-stable@nongnu.org
>> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>

Thanks, applied to ppc-next.


Alex