Re: [PATCH v2] libxl: Make local_initiate_attach more rational

[George Dunlap <george.dunlap@eu.citrix.com>]

On 07/03/2015 03:28 PM, Ian Campbell wrote:
> On Thu, 2015-07-02 at 19:55 +0200, Roger Pau Monné wrote:
>> El 02/07/15 a les 19.42, George Dunlap ha escrit:
>>> There are a lot of paths through
>>> libxl__device_disk_local_initiate_attach(), but they all really boil
>>> down to one thing: Can we just access the file directly, or do we need
>>> to attach it?
>>>
>>> The requirements for direct access are fairly simple:
>>> * Is this local (as opposed to a driver domain)?
>>> * Is this a raw format (as opposed to cooked)?
>>> * Does this have no scripts associated with it?
>>>
>>> If it meets all those requirements, we can access it directly;
>>> otherwise we need to attach it.
>>>
>>> This fixes a bug where bootloader execution fails for disks with
>>> hotplug scripts.
>>>
>>> This should fix a theoretical bug when using a qdisk backend in a
>>> driver domain. (Not tested.)
>>>
>>> Based on a patch by Roger Pau Monne <roger.pau@citrix.com>.
>>>
>>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>>
>> LGTM
>>
>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Hmm, this one seems somehow not to build because now ctx isn't used
anywhere.

I'm going to re-send this in a bit as part of a longer series switching
to blktap -- I'll take the liberty to retain both of your Acks.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel