From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@plumgrid.com>,
John Fastabend <john.fastabend@gmail.com>,
Eric Dumazet <edumazet@gmail.com>
Subject: Re: [PATCH v3 net-next 7/7] net_sched: act_mirred: remove spinlock in fast path
Date: Mon, 06 Jul 2015 08:53:43 -0400 [thread overview]
Message-ID: <559A7A57.2000803@mojatatu.com> (raw)
In-Reply-To: <1436185089-18268-8-git-send-email-edumazet@google.com>
On 07/06/15 08:18, Eric Dumazet wrote:
> Like act_gact, act_mirred can be lockless in packet processing
>
> 1) Use percpu stats
> 2) update lastuse only every clock tick to avoid false sharing
> 3) use rcu to protect tcfm_dev
> 4) Remove spinlock usage, as it is no longer needed.
>
> Next step : add multi queue capability to ifb device
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Looks good to me ;->
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cant wait for the multi queue ifb.
cheers,
jamal
next prev parent reply other threads:[~2015-07-06 12:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 12:18 [PATCH v3 net-next 0/7] net_sched: act: lockless operation Eric Dumazet
2015-07-06 12:18 ` [PATCH v3 net-next 1/7] net: sched: extend percpu stats helpers Eric Dumazet
2015-07-06 18:34 ` Alexei Starovoitov
2015-07-06 12:18 ` [PATCH v3 net-next 2/7] net: sched: add percpu stats to actions Eric Dumazet
2015-07-06 12:18 ` [PATCH v3 net-next 3/7] net_sched: act_gact: make tcfg_pval non zero Eric Dumazet
2015-07-06 12:18 ` [PATCH v3 net-next 4/7] net_sched: act_gact: use a separate packet counters for gact_determ() Eric Dumazet
2015-07-06 12:18 ` [PATCH v3 net-next 5/7] net_sched: act_gact: read tcfg_ptype once Eric Dumazet
2015-07-06 12:18 ` [PATCH v3 net-next 6/7] net_sched: act_gact: remove spinlock in fast path Eric Dumazet
2015-07-06 12:18 ` [PATCH v3 net-next 7/7] net_sched: act_mirred: " Eric Dumazet
2015-07-06 12:53 ` Jamal Hadi Salim [this message]
2015-07-06 14:56 ` Eric Dumazet
2015-07-06 18:24 ` Eric Dumazet
2015-07-06 18:29 ` Alexei Starovoitov
2015-07-08 20:50 ` [PATCH v3 net-next 0/7] net_sched: act: lockless operation David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559A7A57.2000803@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=edumazet@gmail.com \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.