From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753869AbbGFPbU (ORCPT ); Mon, 6 Jul 2015 11:31:20 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:34125 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753828AbbGFPbP (ORCPT ); Mon, 6 Jul 2015 11:31:15 -0400 Message-ID: <559A9F41.4050705@gmail.com> Date: Mon, 06 Jul 2015 09:31:13 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Adrian Hunter , Arnaldo Carvalho de Melo CC: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH] perf record: Let user have timestamps with per-thread recording References: <1436183461-1918-1-git-send-email-adrian.hunter@intel.com> In-Reply-To: <1436183461-1918-1-git-send-email-adrian.hunter@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/6/15 5:51 AM, Adrian Hunter wrote: > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 6be3c01ff6f8..ec98e5b4e14e 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -707,7 +707,8 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts) > */ > if (opts->sample_time && > (!perf_missing_features.sample_id_all && > - (!opts->no_inherit || target__has_cpu(&opts->target) || per_cpu))) > + (!opts->no_inherit || target__has_cpu(&opts->target) || per_cpu || > + opts->sample_time_set))) > perf_evsel__set_sample_bit(evsel, TIME); > > if (opts->raw_samples && !evsel->no_aux_samples) { > Why is the sample_time_set even needed? If a user or a command asks for sample time the bit should be set. This seems crazy that underlying code is ignoring the request.