From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH v2] x86/vm_event: toggle singlestep from vm_event response Date: Tue, 7 Jul 2015 09:26:23 +0300 Message-ID: <559B710F.6040909@bitdefender.com> References: <1435673482-10674-1-git-send-email-tlengyel@novetta.com> <5592A51E.1050200@citrix.com> <559ABA50020000780008CD3A@mail.emea.novell.com> <559AC0D3020000780008CDFD@mail.emea.novell.com> <559AB4E7.1040506@bitdefender.com> <559B8BB5020000780008D166@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <559B8BB5020000780008D166@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: keir@xen.org, Ian Campbell , Andrew Cooper , Xen-devel , stefano.stabellini@citrix.com, Tamas Lengyel List-Id: xen-devel@lists.xenproject.org On 07/07/2015 09:20 AM, Jan Beulich wrote: >>>> On 06.07.15 at 19:03, wrote: >> I don't mind just having the comment for now, so for what it's worth I >> stand by my ack. >> >> Having said that (and with the understading that it is beyond the scope >> of this patch), a way to validate things like these is a good idea. I >> wonder if, in a future patch, we could not have ./configure detect these >> things and simply disable the relevant VM_EVENT_FLAG constants with >> #if(n)defs, for example. That way, you wouldn't be able to compile code >> that wouldn't work silently on platforms where that is the case. > > I don't follow: Are you saying this assuming that everyone would > configure and build on the target system? I.e. are you leaving > distros completely out of consideration? I was, as also pointed out by Andrew. Tamas has, in the meantime, submitted a patch doing this the right way (adding the ability to query hypervisor capabilities). Thanks, Razvan