From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH 2/3] drm/ttm: fix object deallocation to properly fill in the page pool. Date: Tue, 7 Jul 2015 15:39:29 +0900 Message-ID: <559B7421.50101@daenzer.net> References: <1407901926-24516-1-git-send-email-j.glisse@gmail.com> <1407901926-24516-3-git-send-email-j.glisse@gmail.com> <559A4641.1000408@daenzer.net> <20150706161025.GA3489@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 5392B6E13D for ; Mon, 6 Jul 2015 23:39:37 -0700 (PDT) In-Reply-To: <20150706161025.GA3489@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jerome Glisse Cc: Thomas Hellstrom , Jack.Xiao@amd.com, dri-devel@lists.freedesktop.org, Konrad Rzeszutek Wilk List-Id: dri-devel@lists.freedesktop.org T24gMDcuMDcuMjAxNSAwMToxMCwgSmVyb21lIEdsaXNzZSB3cm90ZToKPiBPbiBNb24sIEp1bCAw NiwgMjAxNSBhdCAwNjoxMToyOVBNICswOTAwLCBNaWNoZWwgRMOkbnplciB3cm90ZToKPj4KPj4g SGkgSsOpcsO0bWUsCj4+Cj4+IE9uIDEzLjA4LjIwMTQgMTI6NTIsIErDqXLDtG1lIEdsaXNzZSB3 cm90ZToKPj4+IEZyb206IErDqXLDtG1lIEdsaXNzZSA8amdsaXNzZUByZWRoYXQuY29tPgo+Pj4K Pj4+IEN1cnJlbnQgY29kZSBuZXZlciBhbGxvd2VkIHRoZSBwYWdlIHBvb2wgdG8gYWN0dWFseSBm aWxsIGluIGFueXdheS4gVGhpcyBmaXgKPj4+IGl0IGFuZCBhbHNvIGFsbG93IGl0IHRvIGdyb3cg b3ZlciBpdHMgbGltaXQgdW50aWwgaXQgZ3JvdyBiZXlvbmQgdGhlIGJhdGNoCj4+PiBzaXplIGZv ciBhbGxvY2F0aW9uIGFuZCBkZWFsbG9jYXRpb24uCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogSsOp csO0bWUgR2xpc3NlIDxqZ2xpc3NlQHJlZGhhdC5jb20+Cj4+PiBSZXZpZXdlZC1ieTogTWFyaW8g S2xlaW5lciA8bWFyaW8ua2xlaW5lci5kZUBnbWFpbC5jb20+Cj4+PiBUZXN0ZWQtYnk6IE1pY2hl bCBEw6RuemVyIDxtaWNoZWxAZGFlbnplci5uZXQ+Cj4+PiBDYzogVGhvbWFzIEhlbGxzdHJvbSA8 dGhlbGxzdHJvbUB2bXdhcmUuY29tPgo+Pj4gQ2M6IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29u cmFkLndpbGtAb3JhY2xlLmNvbT4KPj4+IC0tLQo+Pj4gIGRyaXZlcnMvZ3B1L2RybS90dG0vdHRt X3BhZ2VfYWxsb2NfZG1hLmMgfCA5ICsrLS0tLS0tLQo+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS90dG0vdHRtX3BhZ2VfYWxsb2NfZG1hLmMgYi9kcml2ZXJzL2dwdS9kcm0vdHRtL3R0 bV9wYWdlX2FsbG9jX2RtYS5jCj4+PiBpbmRleCBjOTZkYjQzLi5hMDc2ZmYzIDEwMDY0NAo+Pj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fcGFnZV9hbGxvY19kbWEuYwo+Pj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fcGFnZV9hbGxvY19kbWEuYwo+Pj4gQEAgLTk1MywxNCAr OTUzLDkgQEAgdm9pZCB0dG1fZG1hX3VucG9wdWxhdGUoc3RydWN0IHR0bV9kbWFfdHQgKnR0bV9k bWEsIHN0cnVjdCBkZXZpY2UgKmRldikKPj4+ICAJfSBlbHNlIHsKPj4+ICAJCXBvb2wtPm5wYWdl c19mcmVlICs9IGNvdW50Owo+Pj4gIAkJbGlzdF9zcGxpY2UoJnR0bV9kbWEtPnBhZ2VzX2xpc3Qs ICZwb29sLT5mcmVlX2xpc3QpOwo+Pj4gLQkJbnBhZ2VzID0gY291bnQ7Cj4+PiAtCQlpZiAocG9v bC0+bnBhZ2VzX2ZyZWUgPiBfbWFuYWdlci0+b3B0aW9ucy5tYXhfc2l6ZSkgewo+Pj4gKwkJaWYg KHBvb2wtPm5wYWdlc19mcmVlID49IChfbWFuYWdlci0+b3B0aW9ucy5tYXhfc2l6ZSArCj4+PiAr CQkJCQkgIE5VTV9QQUdFU19UT19BTExPQykpCj4+PiAgCQkJbnBhZ2VzID0gcG9vbC0+bnBhZ2Vz X2ZyZWUgLSBfbWFuYWdlci0+b3B0aW9ucy5tYXhfc2l6ZTsKPj4+IC0JCQkvKiBmcmVlIGF0IGxl YXN0IE5VTV9QQUdFU19UT19BTExPQyBudW1iZXIgb2YgcGFnZXMKPj4+IC0JCQkgKiB0byByZWR1 Y2UgY2FsbHMgdG8gc2V0X21lbW9yeV93YiAqLwo+Pj4gLQkJCWlmIChucGFnZXMgPCBOVU1fUEFH RVNfVE9fQUxMT0MpCj4+PiAtCQkJCW5wYWdlcyA9IE5VTV9QQUdFU19UT19BTExPQzsKPj4+IC0J CX0KPj4+ICAJfQo+Pj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZwb29sLT5sb2NrLCBpcnFf ZmxhZ3MpOwo+Pj4gIAo+Pj4KPj4KPj4gQ29sbGVhZ3VlcyBvZiBtaW5lIGhhdmUgbWVhc3VyZWQg c2lnbmlmaWNhbnQgcGVyZm9ybWFuY2UgZ2FpbnMgZm9yIHNvbWUKPj4gd29ya2xvYWRzIHdpdGgg dGhpcyBwYXRjaC4gV2l0aG91dCBpdCwgYSBsb3Qgb2YgQ1BVIGN5Y2xlcyBhcmUgc3BlbnQKPj4g Y2hhbmdpbmcgdGhlIGNhY2hpbmcgYXR0cmlidXRlcyBvZiBwYWdlcyBvbiBhbGxvY2F0aW9uLgo+ Pgo+PiBOb3RlIHRoYXQgdGhlIHBlcmZvcm1hbmNlIGVmZmVjdCBzZWVtcyB0byBtb3N0bHkgZGlz YXBwZWFyIHdoZW4gYXBwbHlpbmcKPj4gcGF0Y2ggMSBhcyB3ZWxsLCBzbyBhcHBhcmVudGx5IDY0 TUIgaXMgdG9vIHNtYWxsIGZvciB0aGUgbWF4IHBvb2wgc2l6ZS4KPj4KPj4gSXMgdGhlcmUgYW55 IGNoYW5jZSB0aGlzIHBhdGNoIGNvdWxkIGJlIGFwcGxpZWQgd2l0aG91dCB0aGUKPj4gY29udHJv dmVyc2lhbCBwYXRjaCAzPyBJZiBub3QsIGRvIHlvdSBoYXZlIGlkZWFzIGZvciBhZGRyZXNzaW5n IHRoZQo+PiBjb25jZXJucyByYWlzZWQgYWdhaW5zdCBwYXRjaCAzPwo+IAo+IFdhaG91LCBub3cg aSBuZWVkIHRvIGZpbmQgdGhlIGtleXMgdG8gdGhlIERlTG9yZWFuIHRvIHRyYXZlbCBiYWNrIGlu IHRpbWUuCj4gCj4gVGhpcyBwYXRjaCBpcyBhIGZpeCBhbmQgc2hvdWxkIGJlIGFwcGxpZWQgd2l0 aG91dCAxIG9yIDMuIEJlY2F1c2UgdG9kYXkKPiBiYXNpY2x5IHRoZSBwb29sIGlzIGFsd2F5cyBl bXB0aWVkIGFuZCBuZXZlciBmaWxsIHVwLiBCdXQgYXMgVGhvbWFzIHBvaW50ZWQKPiBvdXQgdGhl cmUgaXMgYWxyZWFkeSBiaXQgdG9vIG11Y2ggcG9vbCBhY2Nyb3NzIHRoZSBzdGFjay4gUHJvcGVy IHNvbHV0aW9uCj4gd291bGQgYmUgdG8gd29yayBzb21ldGhpbmcgaW5zaWRlIHRoZSBtbSBsZXZl bCBvciB0aGUgYXJjaGl0ZWN0dXJlIChpIGFzc3VtZQo+IEFNRCBpcyBtb3N0bHkgaW50ZXJlc3Rl ZCBpbiB4ODYgb24gdGhhdCBmcm9udCkuCj4gCj4gSGVyZSB0aGUgd2hvbGUgaXNzdWUgaXMgcmVh bGx5IGFib3V0IGFsbG9jYXRpbmcgcGFnZSB3aXRoIFdDL1VDIGNhY2hlCj4gcHJvcGVydGllcy4g Q2hhbmdpbmcgY2FjaGUgcHJvcGVydGllcyBvbiBwYWdlIGlzIHJlYWxseSBjb3N0bHkgb24gc2V2 ZXJhbAo+IGxldmVsLCBsaWtlIHRoZSBrZXJuZWwgbmVlZHMgdG8gYnJlYWsgdGhlIGh1Z2UgbGlu ZWFyIG1hcHBpbmcgYW5kIHBvcHVsYXRlCj4gbG93ZXIgbGV2ZWwgdG8gcmVtYXAgdGhlIHBhZ2Ug d2l0aCBwcm9wZXIgY2FjaGUgYXR0cmlidXRlIGluc2lkZSB0aGUga2VybmVsCj4gbWFwcGluZy4K PiAKPiBBcyBmYXIgYXMgaSByZW1lbWJlciB0aGUga2VybmVsIG5ldmVyIGdvZXMgYmFjayB0byBo dWdlIHBhZ2UgbWFwcGluZyB3aGVuCj4gcmVzdG9yaW5nIHBhZ2UgY2FjaGUgYXR0cmlidXRlLCB3 aGljaCBtZWFuaW5nIHRoYXQgbGl0dGxlIGJ5IGxpdHRlIHdpdGgKPiB1cHRpbWUgeW91IGxvb3Nl IHRoZSB3aG9sZSBodWdlIHBhZ2UgbWFwcGluZyBiZW5lZml0IGZvciBldmVyeXRoaW5nIGFuZCB5 b3UKPiB3YXN0ZSBtb3JlIG1lbW9yeS4KClRoYXQgc291bmRzIHByZXR0eSBiYWQsIGJ1dCB0aGlz IHBhdGNoIG1pZ2h0IGFjdHVhbGx5IGhlbHAgYSBsaXR0bGUgZm9yCnRoYXQgYnkgcmVkdWNpbmcg dGhlIGFtb3VudCBvZiBodWdlIHBhZ2UgbWFwcGluZ3MgdGhhdCBuZWVkIHRvIGJlIGJyb2tlbiB1 cD8KCgo+IEluIG1lYW50aW1lIGkgdGhpbmsgd2UgbmVlZCB0byBhcHBseSB0aGlzIHBhdGNoIGFz IGl0IGlzIHJlYWxseSBhIGZpeCB0bwo+IG1ha2UgdGhlIGNvZGUgYWN0dWFsbHkgZG8gd2hhdCB0 aGUgY29tbWVudCBhbmQgZGVzaWduIHByZXRlbmRzIGl0IGRvZXMuCgpJIGFncmVlLgoKQlRXLCBt YXliZSBpdCBzaG91bGQgYmUgc3BsaXQgdXAgaW50byB0aGUgYWN0dWFsIGZpeCAocmVtb3Zpbmcg dGhlCm5wYWdlcyBhc3NpZ25tZW50KSBhbmQgdGhlIE5VTV9QQUdFU19UT19BTExPQyByZWxhdGVk IHNpbXBsaWZpY2F0aW9uPwoKCi0tIApFYXJ0aGxpbmcgTWljaGVsIETDpG56ZXIgICAgICAgICAg ICAgICB8ICAgICAgICAgICAgICAgaHR0cDovL3d3dy5hbWQuY29tCkxpYnJlIHNvZnR3YXJlIGVu dGh1c2lhc3QgICAgICAgICAgICAgfCAgICAgICAgICAgICBNZXNhIGFuZCBYIGRldmVsb3Blcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=