Re: [RFC PATCH v3 17/18] xen/arm: ITS: Generate ITS node for Dom0

[Julien Grall <julien.grall@citrix.com>]

Hi,

On 07/07/2015 06:31, Vijay Kilari wrote:
> On Mon, Jun 29, 2015 at 6:36 PM, Ian Campbell <ian.campbell@citrix.com> wrote:
>> On Mon, 2015-06-22 at 17:31 +0530, vijay.kilari@gmail.com wrote:
>
>>>
>>> +int its_make_dt_node(const struct domain *d,
>>> +                     const struct dt_device_node *node, void *fdt)
>>> +{
>>> +    struct its_node *its;
>>> +    const struct dt_device_node *gic;
>>> +    const void *compatible = NULL;
>>> +    u32 len;
>>> +    __be32 *new_cells, *tmp;
>>> +    int res = 0;
>>> +
>>> +    /* Will pass only first ITS node info */
>>> +    /* TODO: Handle multi node */
>>> +    its = list_first_entry(&its_nodes, struct its_node, entry);
>>
>> I think this should be done at the top level by not walking all children
>> and by blacklisting all ITS nodes to be replaced by our own.
>
>     I have added TODO for multinode.
> For now, I plan to support only single ITS node. I don't have
> platform support right now to test multinode

I'm not sure to understand what you want to support multi-node here...

This function is used to create the ITS node for DOM0. From the design 
document, guest domain only sees a single node.

Blacklisted ITS node in the top level function is just one line (you 
have to give the compatible string)>

Regards,

-- 
Julien Grall