From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH 3/6] Input: pixcir_i2c_ts - allow using with GPIO expanders Date: Tue, 7 Jul 2015 13:55:44 +0300 Message-ID: <559BB030.2000804@ti.com> References: <1436229011-29655-1-git-send-email-dmitry.torokhov@gmail.com> <1436229011-29655-3-git-send-email-dmitry.torokhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436229011-29655-3-git-send-email-dmitry.torokhov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov , linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On 07/07/15 03:30, Dmitry Torokhov wrote: > We are using threaded interrupt handler and thus are allowed to sleep. > Let's switch over to gpiod_get_value_cansleep() so that we do not get > ugly warnings in case GPIO controller might sleep when accessing GPIO. > > Signed-off-by: Dmitry Torokhov Acked-by: Roger Quadros cheers, -roger > --- > drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c > index 9093aa9..8965d7c 100644 > --- a/drivers/input/touchscreen/pixcir_i2c_ts.c > +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c > @@ -171,7 +171,7 @@ static irqreturn_t pixcir_ts_isr(int irq, void *dev_id) > /* report it */ > pixcir_ts_report(tsdata, &report); > > - if (gpiod_get_value(tsdata->gpio_attb)) { > + if (gpiod_get_value_cansleep(tsdata->gpio_attb)) { > if (report.num_touches) { > /* > * Last report with no finger up? > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757209AbbGGKzy (ORCPT ); Tue, 7 Jul 2015 06:55:54 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:54537 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753819AbbGGKzr (ORCPT ); Tue, 7 Jul 2015 06:55:47 -0400 Message-ID: <559BB030.2000804@ti.com> Date: Tue, 7 Jul 2015 13:55:44 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dmitry Torokhov , CC: Subject: Re: [PATCH 3/6] Input: pixcir_i2c_ts - allow using with GPIO expanders References: <1436229011-29655-1-git-send-email-dmitry.torokhov@gmail.com> <1436229011-29655-3-git-send-email-dmitry.torokhov@gmail.com> In-Reply-To: <1436229011-29655-3-git-send-email-dmitry.torokhov@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/15 03:30, Dmitry Torokhov wrote: > We are using threaded interrupt handler and thus are allowed to sleep. > Let's switch over to gpiod_get_value_cansleep() so that we do not get > ugly warnings in case GPIO controller might sleep when accessing GPIO. > > Signed-off-by: Dmitry Torokhov Acked-by: Roger Quadros cheers, -roger > --- > drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c > index 9093aa9..8965d7c 100644 > --- a/drivers/input/touchscreen/pixcir_i2c_ts.c > +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c > @@ -171,7 +171,7 @@ static irqreturn_t pixcir_ts_isr(int irq, void *dev_id) > /* report it */ > pixcir_ts_report(tsdata, &report); > > - if (gpiod_get_value(tsdata->gpio_attb)) { > + if (gpiod_get_value_cansleep(tsdata->gpio_attb)) { > if (report.num_touches) { > /* > * Last report with no finger up? >