From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jennifer Herbert Subject: Re: [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage() Date: Tue, 7 Jul 2015 17:13:18 +0100 Message-ID: <559BFA9E.5050109@citrix.com> References: <1436284103-25551-1-git-send-email-Jennifer.Herbert@citrix.com> <559BF57C.1050608@citrix.com> <21915.63680.659291.919081@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21915.63680.659291.919081@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Andrew Cooper Cc: stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/07/15 17:05, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()"): >> On 07/07/15 16:48, Jennifer Herbert wrote: >>> + else >>> + fprintf(lg-f, "[localtime_r failed: %d] ", errno); >> lg->f ? > I didn't spot this. I guess the patch wasn't build-tested... > Not sure what happened there - something was built tested, but I presumably without this patch. Sorry about that. -jenny