From: Randy Dunlap <rdunlap@infradead.org>
To: David Binderman <dcb314@hotmail.com>,
Johnny Kim <johnny.kim@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>,
"dean.lee@atmel.com" <dean.lee@atmel.com>,
Chris Park <chris.park@atmel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?
Date: Tue, 07 Jul 2015 10:22:13 -0700 [thread overview]
Message-ID: <559C0AC5.20801@infradead.org> (raw)
In-Reply-To: <DUB128-W333766FA47F8690AEA26469C920@phx.gbl>
On 07/07/15 04:19, David Binderman wrote:
> Hello there,
>
> [linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874]: (style) A pointer can not be negative so it is either pointless or an error to check if it is.
>
> Source code is
>
> if (wilc_mac_thread < 0) {
>
> but
>
> struct task_struct *wilc_mac_thread;
#include <linux/err.h>
if (IS_ERR(wilc_mac_thread)) {
--
~Randy
next prev parent reply other threads:[~2015-07-07 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 11:19 linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ? David Binderman
2015-07-07 17:22 ` Randy Dunlap [this message]
2015-07-08 0:56 ` Kim, Johnny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559C0AC5.20801@infradead.org \
--to=rdunlap@infradead.org \
--cc=chris.park@atmel.com \
--cc=dcb314@hotmail.com \
--cc=dean.lee@atmel.com \
--cc=johnny.kim@atmel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.