From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43376)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1ZCXGN-0003aE-2X
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 14:06:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1ZCXGJ-0001Ml-HK
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 14:06:35 -0400
Received: from relay.parallels.com ([195.214.232.42]:53857)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den-lists@parallels.com>) id 1ZCXGJ-0001KK-9G
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 14:06:31 -0400
Message-ID: <559C1521.6030306@parallels.com>
Date: Tue, 7 Jul 2015 21:06:25 +0300
From: "Denis V. Lunev" <den-lists@parallels.com>
MIME-Version: 1.0
References: <CAFEAcA__-AizO=OYKG3Cc5MGhX7vg1TahTLT+=LDVr-=qQif5Q@mail.gmail.com>
	<1436289212-14756-1-git-send-email-okrishtal@parallels.com>
In-Reply-To: <1436289212-14756-1-git-send-email-okrishtal@parallels.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Olga Krishtal <okrishtal@parallels.com>
Cc: peter.maydell@linaro.org, den@paralles.com, qemu-devel@nongnu.org

On 07/07/15 20:13, Olga Krishtal wrote:
> Peter, can you try this patch on your system?
>
> In mingw older than mingw64-headers-4.0.2-1.el7.noarch
> header ntddscsi.h can be found in include/ddk, however
> compiler does not look there. This breaks the compilation.
>
> The patch adds this directory in QEMU_INCLUDES.
>
> Signed-off-by: Olga Krishtal <okrishtal@parallels.com>
> ---
>   configure | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 52cfe18..ada8895 100755
> --- a/configure
> +++ b/configure
> @@ -3763,7 +3763,6 @@ if test "$usb_redir" != "no" ; then
>           usb_redir="no"
>       fi
>   fi
> -
>   ##########################################
>   # check if we have VSS SDK headers for win
>
> @@ -3820,6 +3819,14 @@ if test "$mingw32" = "yes" -a "$guest_agent" != "no" -a "$guest_agent_with_vss"
>   fi
>
>   ##########################################
> +# mingw package on Linux is quite different with different versions. ntddscsi.h
> +# can be found sys-root/mingw/include and in sys-root/mingw/include/ddk
> +# Add ddk directory to lookup path automatically
> +if test "$mingw32" = "yes" -a "$guest_agent" != "no"; then
> +  QEMU_INCLUDES="$QEMU_INCLUDES -I`$cc -print-sysroot`/mingw/include/ddk"
> +fi
> +
> +##########################################
>   # Guest agent Window MSI  package
>
>   if test "$guest_agent" != yes; then
>

actually this is a dirty hack, but we want to
know whether additional include directory help or not.
If this helps, we could think how to avoid extra
configuration option and ifdef in the code.

Den