From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher J. Morrone Date: Tue, 07 Jul 2015 12:57:38 -0700 Subject: [lustre-devel] [PATCH] [PATCH] staging/lustre: Remove unused MDS_CLOSE_CLEANUP define In-Reply-To: <20150707153234.GA1872@lusbld01.us.cray.com> References: <20150707153234.GA1872@lusbld01.us.cray.com> Message-ID: <559C2F32.5040104@llnl.gov> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lustre-devel@lists.lustre.org Unless there is code in this client that explicitly prevents it from connecting with a pre-2.4.0 server, perhaps this flag should not be removed. Chris On 07/07/2015 08:32 AM, Ben Evans wrote: > Previously, MDS_CLOSE_CLEANUP was used to detect file closing, > due to eviction. This flag is no longer used. > > Signed-off-by: Aurelien Degremont > Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677 > Reviewed-on: http://review.whamcloud.com/7195 > Reviewed-by: Andreas Dilger > Reviewed-by: Jinshan Xiong > Reviewed-by: John L. Hammond > Reviewed-by: Fan Yong > Reviewed-by: Oleg Drokin > Signed-off-by: Ben Evans > --- > .../lustre/lustre/include/lustre/lustre_idl.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h > index 4d72d6e..bea70cb 100644 > --- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h > +++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h > @@ -2390,7 +2390,7 @@ enum mds_op_bias { > MDS_PERM_BYPASS = 1 << 3, > MDS_SOM = 1 << 4, > MDS_QUOTA_IGNORE = 1 << 5, > - MDS_CLOSE_CLEANUP = 1 << 6, > + /* MDS_CLOSE_CLEANUP = 1 << 6, obsolete since 2.4.0 */ > MDS_KEEP_ORPHAN = 1 << 7, > MDS_RECOV_OPEN = 1 << 8, > MDS_DATA_MODIFIED = 1 << 9, >