From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v8 11/12] eal: Consolidate
 pci_map/unmap_device() of linuxapp and bsdapp
Date: Wed, 08 Jul 2015 11:42:58 +0900
Message-ID: <559C8E32.3070808@igel.co.jp>
References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp>	<1436163861-3025-1-git-send-email-mukawa@igel.co.jp>	<1436163861-3025-12-git-send-email-mukawa@igel.co.jp>
 <CALwxeUse35k41OfLg+rX3CYcOT9guNv+mYgEBrkm=jC-=BKxnQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: David Marchand <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com
 [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id 37D535A5D
 for <dev@dpdk.org>; Wed,  8 Jul 2015 04:43:02 +0200 (CEST)
Received: by pdrg1 with SMTP id g1so5085230pdr.2
 for <dev@dpdk.org>; Tue, 07 Jul 2015 19:43:01 -0700 (PDT)
In-Reply-To: <CALwxeUse35k41OfLg+rX3CYcOT9guNv+mYgEBrkm=jC-=BKxnQ@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/07/07 17:06, David Marchand wrote:
> On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa <mukawa@igel.co.jp
> <mailto:mukawa@igel.co.jp>> wrote:
>
>     From: "Tetsuya.Mukawa" <mukawa@igel.co.jp <mailto:mukawa@igel.co.jp>>
>
>     The patch consolidates below functions, and implemented in common
>     eal code.
>      - pci_map_device()
>      - pci_unmap_device()
>
>     Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp
>     <mailto:mukawa@igel.co.jp>>
>     ---
>      lib/librte_eal/bsdapp/eal/eal_pci.c     |  3 ++
>      lib/librte_eal/common/eal_common_pci.c  | 57
>     +++++++++++++++++++++++++++++++++
>      lib/librte_eal/common/eal_private.h     | 19 +++++++++++
>      lib/librte_eal/common/include/rte_pci.h |  1 +
>      lib/librte_eal/linuxapp/eal/eal_pci.c   | 53
>     ------------------------------
>      lib/librte_ether/rte_ethdev.c           |  2 ++
>      6 files changed, 82 insertions(+), 53 deletions(-)
>
>     diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
>     b/lib/librte_eal/bsdapp/eal/eal_pci.c
>     index f85fc1e..a27dca3 100644
>     --- a/lib/librte_eal/bsdapp/eal/eal_pci.c
>     +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
>     @@ -240,6 +240,9 @@ pci_scan_one(int dev_pci_fd, struct pci_conf
>     *conf)
>             /* FreeBSD has no NUMA support (yet) */
>             dev->numa_node = 0;
>
>     +       /* FreeBSD has only one pass through driver */
>     +       dev->kdrv = RTE_KDRV_NIC_UIO;
>     +
>
>
> Do we need a new define for this ?
>
> I know this is not really part of this patchset, but this kdrv should
> just disappear.

Could I make sure this?
It seems 'struct rte_pci_device' still has kdrv member, also my patch
defines RTE_KDRV_NIC_UIO like below.

--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib/librte_eal/common/include/rte_pci.h
@@ -149,6 +149,7 @@ enum rte_kernel_driver {
 	RTE_KDRV_IGB_UIO,
 	RTE_KDRV_VFIO,
 	RTE_KDRV_UIO_GENERIC,
+	RTE_KDRV_NIC_UIO,
 };

Do you mean kdrv member will disappear in next DPDK release?

Tetsuya

>
>
> -- 
> David Marchand