diff for duplicates of <559CB8EC.1090008@wanadoo.fr> diff --git a/a/1.txt b/N1/1.txt index 005d1a0..f4c178d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -Le 07/07/2015 19:04, Khalid Aziz a écrit : +Le 07/07/2015 19:04, Khalid Aziz a écrit : > On 07/07/2015 02:45 AM, Frans Klaver wrote: >> On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET >> <christophe.jaillet@wanadoo.fr> wrote: @@ -39,9 +39,10 @@ Le 07/07/2015 19:04, Khalid Aziz a écrit : > strncmp would indeed be a better way to clean this up. Also, further > down in the same routine: > -> if (FPT_scamInfo[match].state = ID_UNUSED) { +> if (FPT_scamInfo[match].state == ID_UNUSED) { > for (k = 0; k < ID_STRING_LENGTH; k++) { -> FPT_scamInfo[match].id_string[k] > p_id_string[k]; +> FPT_scamInfo[match].id_string[k] = +> p_id_string[k]; > } > > @@ -70,7 +71,8 @@ examples, things could be much more readable if not limited to 50 chars per line, or so. 1357 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1357> FPT_sccbMgrTbl <http://lxr.free-electrons.com/ident?i=FPT_sccbMgrTbl>[thisCard][id <http://lxr.free-electrons.com/ident?i=id> * 2 + -1358 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1358> i <http://lxr.free-electrons.com/ident?i=i>].TarStatus |1359 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1359> SYNC_SUPPORTED <http://lxr.free-electrons.com/ident?i=SYNC_SUPPORTED>; +1358 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1358> i <http://lxr.free-electrons.com/ident?i=i>].TarStatus |= +1359 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1359> SYNC_SUPPORTED <http://lxr.free-electrons.com/ident?i=SYNC_SUPPORTED>; or @@ -98,7 +100,8 @@ or 4871 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4871> [FPT_sccbMgrTbl <http://lxr.free-electrons.com/ident?i=FPT_sccbMgrTbl> 4872 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4872> [p_card][currSCCB-> 4873 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4873> TargID]. -4874 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4874> LunDiscQ_Idx[0]] 4875 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4875> NULL <http://lxr.free-electrons.com/ident?i=NULL>; +4874 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4874> LunDiscQ_Idx[0]] = +4875 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4875> NULL <http://lxr.free-electrons.com/ident?i=NULL>; 4876 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4876> } diff --git a/a/content_digest b/N1/content_digest index 778803b..1983806 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0559C06B4.2010808@gonehiking.org\0" "From\0Christophe JAILLET <christophe.jaillet@wanadoo.fr>\0" "Subject\0Re: [PATCH] [SCSI] FlashPoint: optimize string comparison\0" - "Date\0Wed, 08 Jul 2015 05:45:16 +0000\0" + "Date\0Wed, 08 Jul 2015 07:45:16 +0200\0" "To\0Khalid Aziz <khalid@gonehiking.org>" " Frans Klaver <fransklaver@gmail.com>\0" "Cc\0JBottomley@odin.com" @@ -12,7 +12,7 @@ " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" - "Le 07/07/2015 19:04, Khalid Aziz a \303\203\302\251crit :\n" + "Le 07/07/2015 19:04, Khalid Aziz a \303\251crit :\n" "> On 07/07/2015 02:45 AM, Frans Klaver wrote:\n" ">> On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET\n" ">> <christophe.jaillet@wanadoo.fr> wrote:\n" @@ -53,9 +53,10 @@ "> strncmp would indeed be a better way to clean this up. Also, further \n" "> down in the same routine:\n" ">\n" - "> if (FPT_scamInfo[match].state = ID_UNUSED) {\n" + "> if (FPT_scamInfo[match].state == ID_UNUSED) {\n" "> for (k = 0; k < ID_STRING_LENGTH; k++) {\n" - "> FPT_scamInfo[match].id_string[k] > p_id_string[k];\n" + "> FPT_scamInfo[match].id_string[k] =\n" + "> p_id_string[k];\n" "> }\n" ">\n" ">\n" @@ -84,7 +85,8 @@ "per line, or so.\n" "\n" "1357 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1357> FPT_sccbMgrTbl <http://lxr.free-electrons.com/ident?i=FPT_sccbMgrTbl>[thisCard][id <http://lxr.free-electrons.com/ident?i=id> * 2 +\n" - "1358 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1358> i <http://lxr.free-electrons.com/ident?i=i>].TarStatus |1359 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1359> SYNC_SUPPORTED <http://lxr.free-electrons.com/ident?i=SYNC_SUPPORTED>;\n" + "1358 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1358> i <http://lxr.free-electrons.com/ident?i=i>].TarStatus |=\n" + "1359 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1359> SYNC_SUPPORTED <http://lxr.free-electrons.com/ident?i=SYNC_SUPPORTED>;\n" "\n" "or\n" "\n" @@ -112,7 +114,8 @@ "4871 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4871> [FPT_sccbMgrTbl <http://lxr.free-electrons.com/ident?i=FPT_sccbMgrTbl>\n" "4872 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4872> [p_card][currSCCB->\n" "4873 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4873> TargID].\n" - "4874 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4874> LunDiscQ_Idx[0]] 4875 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4875> NULL <http://lxr.free-electrons.com/ident?i=NULL>;\n" + "4874 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4874> LunDiscQ_Idx[0]] =\n" + "4875 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4875> NULL <http://lxr.free-electrons.com/ident?i=NULL>;\n" "4876 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4876> }\n" "\n" "\n" @@ -127,4 +130,4 @@ "the body of a message to majordomo@vger.kernel.org\n" More majordomo info at http://vger.kernel.org/majordomo-info.html -8f366c2f167b098eb91744514d91db309f12f0d9f56a0a842188e3a6c213d503 +058cb3e57be842289eb4b5ebe53c062c99f3a1982129eaf188cee64a5dec65ff
diff --git a/a/1.txt b/N2/1.txt index 005d1a0..5c8cd65 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,4 +1,4 @@ -Le 07/07/2015 19:04, Khalid Aziz a écrit : +Le 07/07/2015 19:04, Khalid Aziz a écrit : > On 07/07/2015 02:45 AM, Frans Klaver wrote: >> On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET >> <christophe.jaillet@wanadoo.fr> wrote: @@ -39,9 +39,10 @@ Le 07/07/2015 19:04, Khalid Aziz a écrit : > strncmp would indeed be a better way to clean this up. Also, further > down in the same routine: > -> if (FPT_scamInfo[match].state = ID_UNUSED) { +> if (FPT_scamInfo[match].state == ID_UNUSED) { > for (k = 0; k < ID_STRING_LENGTH; k++) { -> FPT_scamInfo[match].id_string[k] > p_id_string[k]; +> FPT_scamInfo[match].id_string[k] = +> p_id_string[k]; > } > > @@ -70,7 +71,8 @@ examples, things could be much more readable if not limited to 50 chars per line, or so. 1357 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1357> FPT_sccbMgrTbl <http://lxr.free-electrons.com/ident?i=FPT_sccbMgrTbl>[thisCard][id <http://lxr.free-electrons.com/ident?i=id> * 2 + -1358 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1358> i <http://lxr.free-electrons.com/ident?i=i>].TarStatus |1359 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1359> SYNC_SUPPORTED <http://lxr.free-electrons.com/ident?i=SYNC_SUPPORTED>; +1358 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1358> i <http://lxr.free-electrons.com/ident?i=i>].TarStatus |= +1359 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1359> SYNC_SUPPORTED <http://lxr.free-electrons.com/ident?i=SYNC_SUPPORTED>; or @@ -98,7 +100,8 @@ or 4871 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4871> [FPT_sccbMgrTbl <http://lxr.free-electrons.com/ident?i=FPT_sccbMgrTbl> 4872 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4872> [p_card][currSCCB-> 4873 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4873> TargID]. -4874 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4874> LunDiscQ_Idx[0]] 4875 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4875> NULL <http://lxr.free-electrons.com/ident?i=NULL>; +4874 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4874> LunDiscQ_Idx[0]] = +4875 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4875> NULL <http://lxr.free-electrons.com/ident?i=NULL>; 4876 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4876> } @@ -108,7 +111,3 @@ changes that could break the code. Best regards, CJ --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 778803b..3cf8971 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\0559C06B4.2010808@gonehiking.org\0" "From\0Christophe JAILLET <christophe.jaillet@wanadoo.fr>\0" "Subject\0Re: [PATCH] [SCSI] FlashPoint: optimize string comparison\0" - "Date\0Wed, 08 Jul 2015 05:45:16 +0000\0" + "Date\0Wed, 08 Jul 2015 07:45:16 +0200\0" "To\0Khalid Aziz <khalid@gonehiking.org>" " Frans Klaver <fransklaver@gmail.com>\0" "Cc\0JBottomley@odin.com" @@ -12,7 +12,7 @@ " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" - "Le 07/07/2015 19:04, Khalid Aziz a \303\203\302\251crit :\n" + "Le 07/07/2015 19:04, Khalid Aziz a \303\251crit :\n" "> On 07/07/2015 02:45 AM, Frans Klaver wrote:\n" ">> On Tue, Jul 7, 2015 at 7:39 AM, Christophe JAILLET\n" ">> <christophe.jaillet@wanadoo.fr> wrote:\n" @@ -53,9 +53,10 @@ "> strncmp would indeed be a better way to clean this up. Also, further \n" "> down in the same routine:\n" ">\n" - "> if (FPT_scamInfo[match].state = ID_UNUSED) {\n" + "> if (FPT_scamInfo[match].state == ID_UNUSED) {\n" "> for (k = 0; k < ID_STRING_LENGTH; k++) {\n" - "> FPT_scamInfo[match].id_string[k] > p_id_string[k];\n" + "> FPT_scamInfo[match].id_string[k] =\n" + "> p_id_string[k];\n" "> }\n" ">\n" ">\n" @@ -84,7 +85,8 @@ "per line, or so.\n" "\n" "1357 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1357> FPT_sccbMgrTbl <http://lxr.free-electrons.com/ident?i=FPT_sccbMgrTbl>[thisCard][id <http://lxr.free-electrons.com/ident?i=id> * 2 +\n" - "1358 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1358> i <http://lxr.free-electrons.com/ident?i=i>].TarStatus |1359 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1359> SYNC_SUPPORTED <http://lxr.free-electrons.com/ident?i=SYNC_SUPPORTED>;\n" + "1358 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1358> i <http://lxr.free-electrons.com/ident?i=i>].TarStatus |=\n" + "1359 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L1359> SYNC_SUPPORTED <http://lxr.free-electrons.com/ident?i=SYNC_SUPPORTED>;\n" "\n" "or\n" "\n" @@ -112,7 +114,8 @@ "4871 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4871> [FPT_sccbMgrTbl <http://lxr.free-electrons.com/ident?i=FPT_sccbMgrTbl>\n" "4872 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4872> [p_card][currSCCB->\n" "4873 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4873> TargID].\n" - "4874 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4874> LunDiscQ_Idx[0]] 4875 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4875> NULL <http://lxr.free-electrons.com/ident?i=NULL>;\n" + "4874 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4874> LunDiscQ_Idx[0]] =\n" + "4875 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4875> NULL <http://lxr.free-electrons.com/ident?i=NULL>;\n" "4876 <http://lxr.free-electrons.com/source/drivers/scsi/FlashPoint.c#L4876> }\n" "\n" "\n" @@ -121,10 +124,6 @@ "changes that could break the code.\n" "\n" "Best regards,\n" - "CJ\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + CJ -8f366c2f167b098eb91744514d91db309f12f0d9f56a0a842188e3a6c213d503 +d62e634f8f0b30f08a778c5b6a87792d2c1e2e575a04812358375630a5a71c12
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.