From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v8 11/12] eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp Date: Wed, 08 Jul 2015 17:50:07 +0900 Message-ID: <559CE43F.1080701@igel.co.jp> References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp> <559C8E32.3070808@igel.co.jp> <1698963.eCjHRZebdj@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 29F682A5E for ; Wed, 8 Jul 2015 10:50:12 +0200 (CEST) Received: by pdbep18 with SMTP id ep18so142056031pdb.1 for ; Wed, 08 Jul 2015 01:50:11 -0700 (PDT) In-Reply-To: <1698963.eCjHRZebdj@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2015/07/08 17:27, Thomas Monjalon wrote: > 2015-07-08 11:42, Tetsuya Mukawa: >> On 2015/07/07 17:06, David Marchand wrote: >>> On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa >> + /* FreeBSD has only one pass through driver */ >>> + dev->kdrv = RTE_KDRV_NIC_UIO; >>> + >>> >>> Do we need a new define for this ? >>> >>> I know this is not really part of this patchset, but this kdrv should >>> just disappear. >> Do you mean kdrv member will disappear in next DPDK release? > No, it is not (yet) planned to be removed. > But David thinks it shouldn't be part of the public API. > So, as David said, this comment is not really related to your patch. > It may be addressed separately. > Please Tetsuya, go ahead with the v9. > Thanks Thanks, I've got it. Tetsuya