From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Christoph Hellwig <hch@infradead.org>,
Sagi Grimberg <sagig@mellanox.com>
Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v3 5/5] target: Fix wrong setting of sense format for PI errors
Date: Wed, 8 Jul 2015 13:36:04 +0300 [thread overview]
Message-ID: <559CFD14.9090803@dev.mellanox.co.il> (raw)
In-Reply-To: <20150708101931.GD14466@infradead.org>
On 7/8/2015 1:19 PM, Christoph Hellwig wrote:
> On Mon, Jul 06, 2015 at 04:15:08PM +0300, Sagi Grimberg wrote:
>> PI errors should be reported in a descriptor format sense data.
>> Fix that by adding a desc_format flag to struct sense_info and pass
>> it to scsi_build_sense_buffer() to do the right thing.
>
> Do we really need the additional flag? We only need the descriptor
> sense format because we add the sector information. So just checking
> for that should be enough, especially when paired with a comment
> explaining that logic in the source file.
We don't have any other information today, but sector is not the only
information that is requires a descriptor format, so maybe it will be a
bit awkward to condition the descriptor format on the sector info?
next prev parent reply other threads:[~2015-07-08 10:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 13:15 [PATCH v3 0/5] Target sense data handling modifications Sagi Grimberg
2015-07-06 13:15 ` [PATCH v3 1/5] target: Inline transport_get_sense_codes() Sagi Grimberg
2015-07-06 13:15 ` [PATCH v3 2/5] target: Split transport_send_check_condition_and_sense() Sagi Grimberg
2015-07-08 10:15 ` Christoph Hellwig
2015-07-08 10:24 ` Sagi Grimberg
2015-07-06 13:15 ` [PATCH v3 3/5] scsi: Move sense handling routines to scsi_common Sagi Grimberg
2015-07-06 15:25 ` Bart Van Assche
2015-07-08 10:16 ` Christoph Hellwig
2015-07-06 13:15 ` [PATCH v3 4/5] target: Use scsi helpers to build the sense data correctly Sagi Grimberg
2015-07-08 10:17 ` Christoph Hellwig
2015-07-08 10:23 ` Sagi Grimberg
2015-07-06 13:15 ` [PATCH v3 5/5] target: Fix wrong setting of sense format for PI errors Sagi Grimberg
2015-07-06 15:28 ` Bart Van Assche
2015-07-06 16:14 ` Sagi Grimberg
2015-07-06 16:22 ` Bart Van Assche
2015-07-08 10:19 ` Christoph Hellwig
2015-07-08 10:36 ` Sagi Grimberg [this message]
2015-07-08 10:49 ` Christoph Hellwig
2015-07-08 10:59 ` Hannes Reinecke
2015-07-08 11:14 ` Sagi Grimberg
2015-07-08 12:59 ` Sagi Grimberg
2015-07-08 11:44 ` Christoph Hellwig
2015-07-08 12:02 ` Sagi Grimberg
2015-07-06 22:51 ` [PATCH v3 0/5] Target sense data handling modifications Nicholas A. Bellinger
2015-07-07 6:18 ` Sagi Grimberg
2015-07-07 6:48 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559CFD14.9090803@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.