Re: [PATCH V4 3/3] xen/vm_event: Deny register writes if refused by vm_event reply

[Razvan Cojocaru <rcojocaru@bitdefender.com>]

On 07/08/2015 03:18 PM, Lengyel, Tamas wrote:
> 
> 
> On Wed, Jul 8, 2015 at 6:22 AM, Razvan Cojocaru
> <rcojocaru@bitdefender.com <mailto:rcojocaru@bitdefender.com>> wrote:
> 
>     Deny register writes if a vm_client subscribed to mov_to_msr or
>     control register write events forbids them. Currently supported for
>     MSR, CR0, CR3 and CR4 events.
> 
>     Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com
>     <mailto:rcojocaru@bitdefender.com>>
>     Acked-by: George Dunlap <george.dunlap@eu.citrix.com
>     <mailto:george.dunlap@eu.citrix.com>>
>     Acked-by: Jan Beulich <jbeulich@suse.com <mailto:jbeulich@suse.com>>
> 
>     ---
>     Changes since V3:
>      - Renamed MEM_ACCESS_FLAG_DENY to VM_EVENT_FLAG_DENY (and fixed
>        the bit shift appropriately).
>      - Moved the DENY vm_event response logic from p2m.c to newly
>        added dedicated files for vm_event handling, as suggested
>        by Tamas Lengyel.
> 
> 
> This looks good to me. It will have to be rebased on staging once the
> other series is merged as couple things will conflict. If this series
> lands first however, the newly added asm/vm_event files lack the
> required license header.
> 
> With that:
> Acked-by: Tamas K Lengyel <tlengyel@novetta.com>

Thanks Tamas!

Are the license headers required? I just tried to make the change as
small as possible, and looking at the other headers (for example in
xen/include/asm-arm), at least half of them have no license header. I'm
guessing this is something we'd now like to start correcting in new patches?


Thanks,
Razvan