From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH V4 3/3] xen/vm_event: Deny register writes
 if refused by vm_event reply
Date: Wed, 8 Jul 2015 15:26:03 +0300
Message-ID: <559D16DB.5090403@bitdefender.com>
References: <1436350970-4987-1-git-send-email-rcojocaru@bitdefender.com>
	<1436350970-4987-4-git-send-email-rcojocaru@bitdefender.com>
	<CAD33N+71-ha+8hz8EkS=F9dRotvG8hMpcx9c1=M3E3eVPxCLVA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAD33N+71-ha+8hz8EkS=F9dRotvG8hMpcx9c1=M3E3eVPxCLVA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Lengyel, Tamas" <tlengyel@novetta.com>
Cc: Jun Nakajima <jun.nakajima@intel.com>, Wei Liu <wei.liu2@citrix.com>, kevin.tian@intel.com, keir@xen.org, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, eddie.dong@intel.com, Xen-devel <xen-devel@lists.xen.org>, Aravind.Gopalakrishnan@amd.com, Jan Beulich <jbeulich@suse.com>, suravee.suthikulpanit@amd.com, boris.ostrovsky@oracle.com, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 07/08/2015 03:18 PM, Lengyel, Tamas wrote:
> 
> 
> On Wed, Jul 8, 2015 at 6:22 AM, Razvan Cojocaru
> <rcojocaru@bitdefender.com <mailto:rcojocaru@bitdefender.com>> wrote:
> 
>     Deny register writes if a vm_client subscribed to mov_to_msr or
>     control register write events forbids them. Currently supported for
>     MSR, CR0, CR3 and CR4 events.
> 
>     Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com
>     <mailto:rcojocaru@bitdefender.com>>
>     Acked-by: George Dunlap <george.dunlap@eu.citrix.com
>     <mailto:george.dunlap@eu.citrix.com>>
>     Acked-by: Jan Beulich <jbeulich@suse.com <mailto:jbeulich@suse.com>>
> 
>     ---
>     Changes since V3:
>      - Renamed MEM_ACCESS_FLAG_DENY to VM_EVENT_FLAG_DENY (and fixed
>        the bit shift appropriately).
>      - Moved the DENY vm_event response logic from p2m.c to newly
>        added dedicated files for vm_event handling, as suggested
>        by Tamas Lengyel.
> 
> 
> This looks good to me. It will have to be rebased on staging once the
> other series is merged as couple things will conflict. If this series
> lands first however, the newly added asm/vm_event files lack the
> required license header.
> 
> With that:
> Acked-by: Tamas K Lengyel <tlengyel@novetta.com>

Thanks Tamas!

Are the license headers required? I just tried to make the change as
small as possible, and looking at the other headers (for example in
xen/include/asm-arm), at least half of them have no license header. I'm
guessing this is something we'd now like to start correcting in new patches?


Thanks,
Razvan