All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Carlos L. Torres" <cltorrespr@gmail.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/4] cutils: Add qemu_strtoul() wrapper
Date: Wed, 8 Jul 2015 15:01:47 +0200	[thread overview]
Message-ID: <559D1F3B.5070407@redhat.com> (raw)
In-Reply-To: <cfeecbc71d015ff79e3f3b7f58b0fdc3c1a2eb74.1436317535.git.carlos.torres@rackspace.com>



On 08/07/2015 03:09, Carlos L. Torres wrote:
> +
> +/**
> + * Converts ASCII string to an unsigned long integer.
> + *
> + * If string contains a negative number, value will be converted to
> + * the unsigned representation of the signed value.

Please document overflow here, as it is slightly different between
strtol and strtoul.

Paolo

> + * See qemu_strtol() documentation for more info.
> + */

  reply	other threads:[~2015-07-08 13:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08  1:09 [Qemu-devel] [PATCH 0/4] cutils: Add qemu_strto*l() wrappers Carlos L. Torres
2015-07-08  1:09 ` [Qemu-devel] [PATCH 1/4] cutils: Add qemu_strtol() wrapper Carlos L. Torres
2015-07-08 12:59   ` Paolo Bonzini
2015-07-08  1:09 ` [Qemu-devel] [PATCH 2/4] cutils: Add qemu_strtoul() wrapper Carlos L. Torres
2015-07-08 13:01   ` Paolo Bonzini [this message]
2015-07-08  1:09 ` [Qemu-devel] [PATCH 3/4] cutils: Add qemu_strtoll() wrapper Carlos L. Torres
2015-07-08  1:09 ` [Qemu-devel] [PATCH 4/4] cutils: Add qemu_strtoull() wrapper Carlos L. Torres
2015-07-08 13:02 ` [Qemu-devel] [PATCH 0/4] cutils: Add qemu_strto*l() wrappers Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559D1F3B.5070407@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=cltorrespr@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.