From: Enrico Joerns <ejo@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: i.MX: Add i.MX5 debug functions
Date: Wed, 08 Jul 2015 15:30:42 +0200 [thread overview]
Message-ID: <559D2602.8060001@pengutronix.de> (raw)
In-Reply-To: <1436357910-4785-1-git-send-email-s.hauer@pengutronix.de>
On 07/08/2015 02:18 PM, Sascha Hauer wrote:
> We recently introduced ungate_all_peripherals and SoC specific low
> level UART init functions. Add some more for i.MX5 SoCs.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/mach-imx/include/mach/debug_ll.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/mach-imx/include/mach/debug_ll.h b/arch/arm/mach-imx/include/mach/debug_ll.h
> index ab939b3..f2f4768 100644
> --- a/arch/arm/mach-imx/include/mach/debug_ll.h
> +++ b/arch/arm/mach-imx/include/mach/debug_ll.h
> @@ -75,6 +75,11 @@ static inline void imx51_uart_setup_ll(void)
> __imx_uart_setup_ll(54000000);
> }
>
> +static inline void imx53_uart_setup_ll(void)
> +{
> + __imx_uart_setup_ll(66666666);
> +}
> +
Currently, the patch does not compile when CONFIG_DEBUG_LL is unset.
Seems you forgot to add this line to your patch:
From b0135fa957a0ebe053349f4442b20006ba5509bf Mon Sep 17 00:00:00 2001
From: Enrico Jorns <ejo@pengutronix.de>
Date: Wed, 8 Jul 2015 15:29:02 +0200
Subject: [PATCH] fixup! ARM: i.MX: Add i.MX5 debug functions
---
arch/arm/mach-imx/include/mach/debug_ll.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-imx/include/mach/debug_ll.h
b/arch/arm/mach-imx/include/mach/debug_ll.h
index f2f4768..eceac40 100644
--- a/arch/arm/mach-imx/include/mach/debug_ll.h
+++ b/arch/arm/mach-imx/include/mach/debug_ll.h
@@ -108,6 +108,7 @@ static inline void imx_uart_setup_ll(void __iomem
*uartbase,
}
static inline void imx51_uart_setup_ll(void) {}
+static inline void imx53_uart_setup_ll(void) {}
static inline void imx6_uart_setup_ll(void) {}
#endif /* CONFIG_DEBUG_LL */
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-07-08 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 12:18 [PATCH 1/2] ARM: i.MX: Add i.MX5 debug functions Sascha Hauer
2015-07-08 12:18 ` [PATCH 2/2] ARM: vincell: move to DT probing Sascha Hauer
2015-07-08 13:30 ` Enrico Joerns [this message]
2015-07-13 5:20 ` [PATCH 1/2] ARM: i.MX: Add i.MX5 debug functions Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559D2602.8060001@pengutronix.de \
--to=ejo@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.