Re: [RFC 1/8] m68k: coldfire: unlink FPU presence from MMU activation

[Greg Ungerer <gregungerer@westnet.com.au>]

Hi Yannick,

I think this needs to be two separate patches.
The FPU change is logically one.
The change to the MCF5441x config is another - and it
really needs to be the last one in the series (so that all
the actuall code support is in place first).

Regards
Greg


On 08/07/15 19:51, Yannick GICQUEL wrote:
> m5441x coldfire chips contains a MMU and no FPU.
> This patch allow building this chip with MMU activated.
>
> Signed-off-by: Yannick GICQUEL <yannick.gicquel@gmail.com>
> ---
>   arch/m68k/Kconfig     | 2 +-
>   arch/m68k/Kconfig.cpu | 4 +++-
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
> index 2dd8f63..d704c16 100644
> --- a/arch/m68k/Kconfig
> +++ b/arch/m68k/Kconfig
> @@ -14,7 +14,7 @@ config M68K
>   	select GENERIC_IOMAP
>   	select GENERIC_STRNCPY_FROM_USER if MMU
>   	select GENERIC_STRNLEN_USER if MMU
> -	select FPU if MMU
> +	select FPU if MMU && !COLDFIRE
>   	select ARCH_WANT_IPC_PARSE_VERSION
>   	select ARCH_USES_GETTIMEOFFSET if MMU && !COLDFIRE
>   	select HAVE_FUTEX_CMPXCHG if MMU && FUTEX
> diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
> index 33013df..3661eb4 100644
> --- a/arch/m68k/Kconfig.cpu
> +++ b/arch/m68k/Kconfig.cpu
> @@ -257,6 +257,7 @@ config M54xx
>   config M547x
>   	bool "MCF547x"
>   	select M54xx
> +	select FPU
>   	select MMU_COLDFIRE if MMU
>   	select HAVE_CACHE_CB
>   	select HAVE_MBAR
> @@ -265,6 +266,7 @@ config M547x
>
>   config M548x
>   	bool "MCF548x"
> +	select FPU
>   	select MMU_COLDFIRE if MMU
>   	select M54xx
>   	select HAVE_CACHE_CB
> @@ -274,7 +276,7 @@ config M548x
>
>   config M5441x
>   	bool "MCF5441x"
> -	depends on !MMU
> +	select MMU_COLDFIRE if MMU
>   	select GENERIC_CLOCKEVENTS
>   	select HAVE_CACHE_CB
>   	help
>