diff for duplicates of <559D2CBB.8090502@gonehiking.org> diff --git a/a/1.txt b/N1/1.txt index 0a0b2a0..ebaeecf 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On 07/08/2015 01:12 AM, Frans Klaver wrote: > On Wed, Jul 8, 2015 at 7:45 AM, Christophe JAILLET > <christophe.jaillet@wanadoo.fr> wrote: ->> Le 07/07/2015 19:04, Khalid Aziz a écrit : +>> Le 07/07/2015 19:04, Khalid Aziz a écrit : >>> >>> On 07/07/2015 02:45 AM, Frans Klaver wrote: >>>> @@ -24,8 +24,10 @@ On 07/08/2015 01:12 AM, Frans Klaver wrote: >>>>> match = 1; >>>>> >>>>> for (k = 0; k < ID_STRING_LENGTH; k++) { ->>>>> - if (p_id_string[k] !>>>>> FPT_scamInfo[i].id_string[k]) ->>>>> + if (p_id_string[k] !>>>>> FPT_scamInfo[i].id_string[k]) { +>>>>> - if (p_id_string[k] != +>>>>> FPT_scamInfo[i].id_string[k]) +>>>>> + if (p_id_string[k] != +>>>>> FPT_scamInfo[i].id_string[k]) { >>>>> match = 0; >>>>> + break; >>>>> + } @@ -44,9 +46,10 @@ On 07/08/2015 01:12 AM, Frans Klaver wrote: >>> strncmp would indeed be a better way to clean this up. Also, further down in >>> the same routine: >>> ->>> if (FPT_scamInfo[match].state = ID_UNUSED) { +>>> if (FPT_scamInfo[match].state == ID_UNUSED) { >>> for (k = 0; k < ID_STRING_LENGTH; k++) { ->>> FPT_scamInfo[match].id_string[k] >>> p_id_string[k]; +>>> FPT_scamInfo[match].id_string[k] = +>>> p_id_string[k]; >>> } >>> >>> diff --git a/a/content_digest b/N1/content_digest index 58b7a68..1a0c3d6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,7 +5,7 @@ "ref\0CAH6sp9OmMje3EAVisaToorOQb+j3AWm_RE_UTpXN6eYjFny72w@mail.gmail.com\0" "From\0Khalid Aziz <khalid@gonehiking.org>\0" "Subject\0Re: [PATCH] [SCSI] FlashPoint: optimize string comparison\0" - "Date\0Wed, 08 Jul 2015 13:59:23 +0000\0" + "Date\0Wed, 08 Jul 2015 07:59:23 -0600\0" "To\0Frans Klaver <fransklaver@gmail.com>" " Christophe JAILLET <christophe.jaillet@wanadoo.fr>\0" "Cc\0JBottomley@odin.com" @@ -17,7 +17,7 @@ "On 07/08/2015 01:12 AM, Frans Klaver wrote:\n" "> On Wed, Jul 8, 2015 at 7:45 AM, Christophe JAILLET\n" "> <christophe.jaillet@wanadoo.fr> wrote:\n" - ">> Le 07/07/2015 19:04, Khalid Aziz a \303\203\302\251crit :\n" + ">> Le 07/07/2015 19:04, Khalid Aziz a \303\251crit :\n" ">>>\n" ">>> On 07/07/2015 02:45 AM, Frans Klaver wrote:\n" ">>>>\n" @@ -40,8 +40,10 @@ ">>>>> match = 1;\n" ">>>>>\n" ">>>>> for (k = 0; k < ID_STRING_LENGTH; k++) {\n" - ">>>>> - if (p_id_string[k] !>>>>> FPT_scamInfo[i].id_string[k])\n" - ">>>>> + if (p_id_string[k] !>>>>> FPT_scamInfo[i].id_string[k]) {\n" + ">>>>> - if (p_id_string[k] !=\n" + ">>>>> FPT_scamInfo[i].id_string[k])\n" + ">>>>> + if (p_id_string[k] !=\n" + ">>>>> FPT_scamInfo[i].id_string[k]) {\n" ">>>>> match = 0;\n" ">>>>> + break;\n" ">>>>> + }\n" @@ -60,9 +62,10 @@ ">>> strncmp would indeed be a better way to clean this up. Also, further down in\n" ">>> the same routine:\n" ">>>\n" - ">>> if (FPT_scamInfo[match].state = ID_UNUSED) {\n" + ">>> if (FPT_scamInfo[match].state == ID_UNUSED) {\n" ">>> for (k = 0; k < ID_STRING_LENGTH; k++) {\n" - ">>> FPT_scamInfo[match].id_string[k] >>> p_id_string[k];\n" + ">>> FPT_scamInfo[match].id_string[k] =\n" + ">>> p_id_string[k];\n" ">>> }\n" ">>>\n" ">>>\n" @@ -122,4 +125,4 @@ "the body of a message to majordomo@vger.kernel.org\n" More majordomo info at http://vger.kernel.org/majordomo-info.html -1b0f52e5dcf13feace38b864c93efe64342bd47208f1562fa88d22b14d08ab51 +e9ab909c5bcc24bcde8c45d70c2755f83cedb081e7fa493190fc40a99133e914
diff --git a/a/1.txt b/N2/1.txt index 0a0b2a0..1f46c24 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,7 +1,7 @@ On 07/08/2015 01:12 AM, Frans Klaver wrote: > On Wed, Jul 8, 2015 at 7:45 AM, Christophe JAILLET > <christophe.jaillet@wanadoo.fr> wrote: ->> Le 07/07/2015 19:04, Khalid Aziz a écrit : +>> Le 07/07/2015 19:04, Khalid Aziz a écrit : >>> >>> On 07/07/2015 02:45 AM, Frans Klaver wrote: >>>> @@ -24,8 +24,10 @@ On 07/08/2015 01:12 AM, Frans Klaver wrote: >>>>> match = 1; >>>>> >>>>> for (k = 0; k < ID_STRING_LENGTH; k++) { ->>>>> - if (p_id_string[k] !>>>>> FPT_scamInfo[i].id_string[k]) ->>>>> + if (p_id_string[k] !>>>>> FPT_scamInfo[i].id_string[k]) { +>>>>> - if (p_id_string[k] != +>>>>> FPT_scamInfo[i].id_string[k]) +>>>>> + if (p_id_string[k] != +>>>>> FPT_scamInfo[i].id_string[k]) { >>>>> match = 0; >>>>> + break; >>>>> + } @@ -44,9 +46,10 @@ On 07/08/2015 01:12 AM, Frans Klaver wrote: >>> strncmp would indeed be a better way to clean this up. Also, further down in >>> the same routine: >>> ->>> if (FPT_scamInfo[match].state = ID_UNUSED) { +>>> if (FPT_scamInfo[match].state == ID_UNUSED) { >>> for (k = 0; k < ID_STRING_LENGTH; k++) { ->>> FPT_scamInfo[match].id_string[k] >>> p_id_string[k]; +>>> FPT_scamInfo[match].id_string[k] = +>>> p_id_string[k]; >>> } >>> >>> @@ -98,10 +101,3 @@ entire FPT_scmachid() routine. Thanks, Khalid - - - --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 58b7a68..cf6c43d 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -5,7 +5,7 @@ "ref\0CAH6sp9OmMje3EAVisaToorOQb+j3AWm_RE_UTpXN6eYjFny72w@mail.gmail.com\0" "From\0Khalid Aziz <khalid@gonehiking.org>\0" "Subject\0Re: [PATCH] [SCSI] FlashPoint: optimize string comparison\0" - "Date\0Wed, 08 Jul 2015 13:59:23 +0000\0" + "Date\0Wed, 08 Jul 2015 07:59:23 -0600\0" "To\0Frans Klaver <fransklaver@gmail.com>" " Christophe JAILLET <christophe.jaillet@wanadoo.fr>\0" "Cc\0JBottomley@odin.com" @@ -17,7 +17,7 @@ "On 07/08/2015 01:12 AM, Frans Klaver wrote:\n" "> On Wed, Jul 8, 2015 at 7:45 AM, Christophe JAILLET\n" "> <christophe.jaillet@wanadoo.fr> wrote:\n" - ">> Le 07/07/2015 19:04, Khalid Aziz a \303\203\302\251crit :\n" + ">> Le 07/07/2015 19:04, Khalid Aziz a \303\251crit :\n" ">>>\n" ">>> On 07/07/2015 02:45 AM, Frans Klaver wrote:\n" ">>>>\n" @@ -40,8 +40,10 @@ ">>>>> match = 1;\n" ">>>>>\n" ">>>>> for (k = 0; k < ID_STRING_LENGTH; k++) {\n" - ">>>>> - if (p_id_string[k] !>>>>> FPT_scamInfo[i].id_string[k])\n" - ">>>>> + if (p_id_string[k] !>>>>> FPT_scamInfo[i].id_string[k]) {\n" + ">>>>> - if (p_id_string[k] !=\n" + ">>>>> FPT_scamInfo[i].id_string[k])\n" + ">>>>> + if (p_id_string[k] !=\n" + ">>>>> FPT_scamInfo[i].id_string[k]) {\n" ">>>>> match = 0;\n" ">>>>> + break;\n" ">>>>> + }\n" @@ -60,9 +62,10 @@ ">>> strncmp would indeed be a better way to clean this up. Also, further down in\n" ">>> the same routine:\n" ">>>\n" - ">>> if (FPT_scamInfo[match].state = ID_UNUSED) {\n" + ">>> if (FPT_scamInfo[match].state == ID_UNUSED) {\n" ">>> for (k = 0; k < ID_STRING_LENGTH; k++) {\n" - ">>> FPT_scamInfo[match].id_string[k] >>> p_id_string[k];\n" + ">>> FPT_scamInfo[match].id_string[k] =\n" + ">>> p_id_string[k];\n" ">>> }\n" ">>>\n" ">>>\n" @@ -113,13 +116,6 @@ "entire FPT_scmachid() routine.\n" "\n" "Thanks,\n" - "Khalid\n" - "\n" - "\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Khalid -1b0f52e5dcf13feace38b864c93efe64342bd47208f1562fa88d22b14d08ab51 +dfa21a257d7a2584b7611eec9037117cc8e81bf39cbf5738a09d2d9205e2e3c6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.