From: Chris Metcalf <cmetcalf@ezchip.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tile:Remove unused marcos from the file tilepro.c
Date: Wed, 8 Jul 2015 12:47:22 -0400 [thread overview]
Message-ID: <559D541A.5050504@ezchip.com> (raw)
In-Reply-To: <1436232151-24185-1-git-send-email-xerofoify@gmail.com>
On 07/06/2015 09:22 PM, Nicholas Krause wrote:
> This removes no longer used marcos at the top of the driver
> due tilepro.c due to having no proper values nor never being
> used by this driver code.
>
> Signed-off-by: Nicholas Krause<xerofoify@gmail.com>
> ---
> drivers/net/ethernet/tile/tilepro.c | 13 -------------
> 1 file changed, 13 deletions(-)
I'm not sure what you mean by "no longer used". They are all
potentially usable to enable chunks of code lower down in
the driver, they're just not enabled by default. So, nack.
Also, "no proper values" doesn't make a lot of sense; if you
specify "#define FOO" it implicitly defines it to the empty
string. Regardless, it doesn't matter what value it is
defined to if the only uses are "#ifdef", as is true here.
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
parent reply other threads:[~2015-07-08 16:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1436232151-24185-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559D541A.5050504@ezchip.com \
--to=cmetcalf@ezchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.