From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934991AbbGHQrj (ORCPT ); Wed, 8 Jul 2015 12:47:39 -0400 Received: from mail-am1on0079.outbound.protection.outlook.com ([157.56.112.79]:36404 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934502AbbGHQrh (ORCPT ); Wed, 8 Jul 2015 12:47:37 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none; Message-ID: <559D541A.5050504@ezchip.com> Date: Wed, 8 Jul 2015 12:47:22 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nicholas Krause CC: , Subject: Re: [PATCH] tile:Remove unused marcos from the file tilepro.c References: <1436232151-24185-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1436232151-24185-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BN3PR0401CA0023.namprd04.prod.outlook.com (25.162.159.161) To VI1PR02MB0781.eurprd02.prod.outlook.com (25.162.14.143) X-Microsoft-Exchange-Diagnostics: 1;VI1PR02MB0781;2:e66ikuPYUMuaBrqHl/QiWF+VyNttXzf66kuBFlApgV1GgIbVV6K5gKVc/1MA05+p;3:FtIZ3k+JLi+rVz+I0989clVzKvo4JO/zsJBeQC72LTxh0H6HY2kYVmkLPKfqHSNQeIWoChbyQoRx3iMNoPIfOWGWluwyw7tA4gMfCV8O5vFe6sHbOltCWPSvgDYrG6vhgICdkDZqkqljMd8xpzniMA==;25:S3CCQdsDqxOfghVddxuQr10XJcyhNAWdv0BbgZQi/xGCiYcqtSjDs1Q2Isgxu5nhDv7f9doXhAZvnUwwbPn+j5mStlGtSN+x5RXdxYNKnHFuI7V3v+c+Uu3H6aJapJZgbnIsZarv4QuM3aIyC/ukmwivZ5WTrcgtjEbNKAHaa9bkZun89ZlwZWI3iRtooV2+LSnP+b6C15CZq/3ticDXhS2aROz1iuu8BuaSAu1tELk7Qde7UzdSjJFeIidtk7mf;20:TBmwB1fO9x9MafTlCFh+aAzBkg7osLcSjWDqzh6gV/7vZw8l6KDkBEnNwxHQHcwT2M34g2cVN/IByAhYHkuxB0hdXNltGf1iRLZ1JG6rhBRKzgbTSYc7PxVM2D32n4xyUGlCn2Znj4KNtsJkU0xKACE26X+peQQqBAO5qyiDoL0=;4:oa3tuFpKRvQ6hoLPVB6ExNxLJShWRevHsBtCWfBns/n8D+t1Yvrm6ymIyL5gX2lbMZBDudIHqU+V/pZApom4WV26xhoLicQavk91YwcZUukRzRum6eCsLX0BM7WXV+Blw3IhLiGUze0CgypCWPe0T8crmuJH3+R4bFwW1xvwRAAWkULCNR4u0uOSKQTp25UmZ7koIHVLNuJjfzJiLnhU4rv92aKMb4Zrxq1C4065yrlEAI58gCugvtA9o6IHy7+8WssAxIp3eMQiCogBPk+YLpocsVTPq/ff+MRsLBO8Ry8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB0781; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:VI1PR02MB0781;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB0781; X-Forefront-PRVS: 0631F0BC3D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(377454003)(51704005)(479174004)(24454002)(42186005)(50466002)(83506001)(15975445007)(77096005)(50986999)(1411001)(36756003)(54356999)(65816999)(76176999)(87266999)(46102003)(64126003)(23746002)(33656002)(66066001)(65956001)(87976001)(65806001)(92566002)(80316001)(4001350100001)(19580395003)(77156002)(59896002)(62966003)(122386002)(19580405001)(40100003)(47776003)(5001960100002)(189998001)(110136002)(86362001)(3076002)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR02MB0781;H:[10.7.0.41];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR02MB0781;23:Bz5bKFNLWoIJwvacpz6dLI4MSuL2m9rcs9e2h?= =?Windows-1252?Q?BZZwhSD5bF2V7hMCFr0n3ikG7Pd+ArV7yd+joNuHhjClLcI/6T5TFo0j?= =?Windows-1252?Q?WDMrppS4NJjYe/u5aHLE9t3UkPVovewbkrEUrPg36clpGWo4LHFsLD1k?= =?Windows-1252?Q?x2f9EN/eHMqZ7nSDDgtV9YC94ROjOXbAfSqZQ1XQQo0rfUJhp4/zy30T?= =?Windows-1252?Q?SoCGIi8XVcbdk6GoeSsU9mbZwbFPJS4OUS+wxtuTMprYpJokJZjuKoH7?= =?Windows-1252?Q?CeFZtOZE8z62JLMi+DZkkemKZKAuTRhY/wCckh6PryWtOU+1TOVGmyUC?= =?Windows-1252?Q?03gw7ag5Qdz2nMKGqp6guRjCXCjzU15aTO6CZtYGgXx88Fjoem2XAxjn?= =?Windows-1252?Q?6ZLynegeE6huch+RjK/xZU4ErePvpNXVVYvk0aPVjbztJTzr9sUGbKOm?= =?Windows-1252?Q?KT4e+oWE5aFJwOKXi1YyuKIg1Yrx14HzM7Ld1OkSRn73X1uL/rih5W/j?= =?Windows-1252?Q?uvc3MJfN4RBd0/YTZ7k9jl/mZJwqwkOuTi7g/ReQBCOeSqk9gxgNMCIm?= =?Windows-1252?Q?J63DoRAmcFYyXiLh94J++m3C5IvFpaQ1vaIlalx7VipXZIyEWEbOc5qU?= =?Windows-1252?Q?p2rNqK0dk0bbc0ZqaLetp+kjQ2XEf957I5U58PYJ/9QvvXqVT+jPBvmw?= =?Windows-1252?Q?JsMHpTZPsFyKNoBaQHv1JhoAGDPD1iLeXXF8K8vsopgICjq66j+lLZBD?= =?Windows-1252?Q?gjnh8eGAJNbGSkua+XQTDUYVi0Yw2pk/nJSNeh5llmtXfsqdEjFWntDr?= =?Windows-1252?Q?xZFIG7HQXW9ISr8PdC/ztMGOpWZPu5S8bFp8kz7xNBT+cIlDzsQkRtk7?= =?Windows-1252?Q?JQqNGwNvsPjZGZzk/+XnYidsINYlUeAS7jUeqmIVgxALLPGEUjGO6VQC?= =?Windows-1252?Q?nOQoK56RwMidtC9GXs5wtXOsK+C0WMjG6Uq2BgBgYrqdkVt00XfJu1TF?= =?Windows-1252?Q?PA9nj86JbOX53gshM9rQKlcpe9VHcOByEIZpdmV750DRFLZMlTK7Dg+2?= =?Windows-1252?Q?7neSanRkA3wYE4/Ao8nughvddOFk5Hi2HRK4AbpkNarib4E+RzhJLkPs?= =?Windows-1252?Q?9HN0wjuedIqQ9er29bQDkWCl40osGO2lhq8FuaM2SIUUeFprBOEgm13R?= =?Windows-1252?Q?YDWqm7rmrazIAj7q1c3SXMHgphzbhw=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR02MB0781;5:QrJnNJwyyFHXM65gyXmDFPsLTDJmGGzqOPk9pyidDxVy21ryoGi+aenzILzSF766EhULZev74hfsFviuE7XwcXbKkZUn/gOLIRRrHnz+Ly/2QkFzm+R2G1PtKfKqOoUbbbSFr/bWWkm9kpQNSrA1SQ==;24:+0EqsrB7eTA+jFdrza8bXCB6a3bbfPOeY5MSxhuvmppV/SOKZcPomMHh88cIGfvV6z8/FgmPo0oFE+SGPkoenkiMskh7Ihxb+gBrl5HaS/U=;20:knnJ5Of3tO+UJ4OEO5tqBSsP83qZ75zau3DqLxqGF48zbnxG916ZtiVHXDv9eH3A6xzGta3tP0NW56f4Nh7Uhw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2015 16:47:33.8755 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB0781 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2015 09:22 PM, Nicholas Krause wrote: > This removes no longer used marcos at the top of the driver > due tilepro.c due to having no proper values nor never being > used by this driver code. > > Signed-off-by: Nicholas Krause > --- > drivers/net/ethernet/tile/tilepro.c | 13 ------------- > 1 file changed, 13 deletions(-) I'm not sure what you mean by "no longer used". They are all potentially usable to enable chunks of code lower down in the driver, they're just not enabled by default. So, nack. Also, "no proper values" doesn't make a lot of sense; if you specify "#define FOO" it implicitly defines it to the empty string. Regardless, it doesn't matter what value it is defined to if the only uses are "#ifdef", as is true here. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com