Re: [PATCH 1/2] nouveau/compiler: fix trivial compiler warnings

[Tobias Klausmann <tobias.johannes.klausmann-AqjdNwhu20eELgA04lAiVw@public.gmane.org>]

On 08.07.2015 20:38, Ilia Mirkin wrote:
> Compiler is wrong.

So just "nouveau: ..." then? Anyway, change it to your liking.

> On Wed, Jul 8, 2015 at 2:27 PM, Tobias Klausmann
> <tobias.johannes.klausmann@mni.thm.de> wrote:
>> nouveau_compiler.c: In function ‘main’:
>> nouveau_compiler.c:216:27: warning: ‘code’ may be used uninitialized in
>> this function [-Wmaybe-uninitialized]
>>         printf("%08x ", code[i / 4]);
>>                             ^
>> nouveau_compiler.c:215:4: warning: ‘size’ may be used uninitialized in
>> this function [-Wmaybe-uninitialized]
>>      for (i = 0; i < size; i += 4) {
>>
>> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
>> ---
>>   src/gallium/drivers/nouveau/nouveau_compiler.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/nouveau/nouveau_compiler.c b/src/gallium/drivers/nouveau/nouveau_compiler.c
>> index 8660498..ca128b5 100644
>> --- a/src/gallium/drivers/nouveau/nouveau_compiler.c
>> +++ b/src/gallium/drivers/nouveau/nouveau_compiler.c
>> @@ -144,7 +144,7 @@ main(int argc, char *argv[])
>>      const char *filename = NULL;
>>      FILE *f;
>>      char text[65536] = {0};
>> -   unsigned size, *code;
>> +   unsigned size = 0, *code = NULL;
>>
>>      for (i = 1; i < argc; i++) {
>>         if (!strcmp(argv[i], "-a"))
>> --
>> 2.4.5
>>
>> _______________________________________________
>> Nouveau mailing list
>> Nouveau@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/nouveau

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau