All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, jdike@addtoit.com
Cc: user-mode-linux-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] um: umid: Use strdup to simplify code
Date: Wed, 08 Jul 2015 19:19:47 +0000	[thread overview]
Message-ID: <559D77D3.3030906@nod.at> (raw)
In-Reply-To: <1436382947-13181-1-git-send-email-christophe.jaillet@wanadoo.fr>

Am 08.07.2015 um 21:15 schrieb Christophe JAILLET:
> Replace a malloc+strcpy by an equivalent strdup in order to improve
> readability.

Makes sense!

> Turn a some spaces into a tab to be consistent with the rest of the code.

Do this in an extra patch. One logical change per patch please.

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, jdike@addtoit.com
Cc: user-mode-linux-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] um: umid: Use strdup to simplify code
Date: Wed, 08 Jul 2015 21:19:47 +0200	[thread overview]
Message-ID: <559D77D3.3030906@nod.at> (raw)
In-Reply-To: <1436382947-13181-1-git-send-email-christophe.jaillet@wanadoo.fr>

Am 08.07.2015 um 21:15 schrieb Christophe JAILLET:
> Replace a malloc+strcpy by an equivalent strdup in order to improve
> readability.

Makes sense!

> Turn a some spaces into a tab to be consistent with the rest of the code.

Do this in an extra patch. One logical change per patch please.

Thanks,
//richard

  reply	other threads:[~2015-07-08 19:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 19:15 [PATCH] um: umid: Use strdup to simplify code Christophe JAILLET
2015-07-08 19:15 ` Christophe JAILLET
2015-07-08 19:19 ` Richard Weinberger [this message]
2015-07-08 19:19   ` Richard Weinberger
2015-07-08 19:56   ` [uml-devel] " Jeff Dike
2015-07-08 20:01     ` Richard Weinberger
2015-07-08 22:11       ` Jeff Dike
2015-07-09  5:06 ` [PATCH 1/2] um: umid: Use tab instead of spaces Christophe JAILLET
2015-07-09  5:06   ` Christophe JAILLET
2015-07-09  5:06   ` [PATCH 2/2] um: umid: Use strdup to simplify code Christophe JAILLET
2015-07-09  5:06     ` Christophe JAILLET
2015-07-09  5:06     ` [uml-devel] " Christophe JAILLET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559D77D3.3030906@nod.at \
    --to=richard@nod.at \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jdike@addtoit.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.