All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: stephen@networkplumber.org
Subject: Re: [patch iproute2] iproute2: ipa: show switch id
Date: Wed, 08 Jul 2015 15:29:42 -0600	[thread overview]
Message-ID: <559D9646.8090203@gmail.com> (raw)
In-Reply-To: <1436368098-21358-1-git-send-email-jiri@resnulli.us>

On 7/8/15 9:08 AM, Jiri Pirko wrote:
> We forgot to include this patch somehow. So do it now.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
>   ip/ipaddress.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index 85a81ba..b7b4e3e 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -688,6 +688,14 @@ int print_linkinfo(const struct sockaddr_nl *who,
>   				      b1, sizeof(b1)));
>   	}
>
> +	if (tb[IFLA_PHYS_SWITCH_ID]) {
> +		SPRINT_BUF(b1);
> +		fprintf(fp, "switchid %s ",
> +			hexstring_n2a(RTA_DATA(tb[IFLA_PHYS_SWITCH_ID]),
> +				      RTA_PAYLOAD(tb[IFLA_PHYS_SWITCH_ID]),
> +				      b1, sizeof(b1)));
> +	}
> +
>   	if (tb[IFLA_OPERSTATE])
>   		print_operstate(fp, rta_getattr_u8(tb[IFLA_OPERSTATE]));
>
>

Do Stephen's comments about port-name apply here?
    http://www.spinics.net/lists/netdev/msg322693.html

I was wondering if this should go into -details output rather than the 
default.

  parent reply	other threads:[~2015-07-08 21:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 15:08 [patch iproute2] iproute2: ipa: show switch id Jiri Pirko
2015-07-08 17:18 ` Andy Gospodarek
2015-07-08 21:29 ` David Ahern [this message]
2015-07-09  6:11   ` Jiri Pirko
2015-07-09  1:05 ` Stephen Hemminger
2015-07-09  6:09   ` Jiri Pirko
2015-07-09 22:22     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559D9646.8090203@gmail.com \
    --to=dsahern@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.