All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cory Tusar <cory.tusar@pid1solutions.com>
To: Haikun Wang <haikun.wang@freescale.com>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
	computersforpeace@gmail.com, han.xu@freescale.com
Subject: Re: [PATCH 6/8 v2] mtd: spi-nor: fsl-quadspi: Add QSPI dts node for LS1021A
Date: Wed, 08 Jul 2015 18:49:37 -0400	[thread overview]
Message-ID: <559DA901.3060404@pid1solutions.com> (raw)
In-Reply-To: <1436258300-21261-6-git-send-email-haikun.wang@freescale.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/07/2015 04:38 AM, Haikun Wang wrote:
> Add QSPI dts node for LS1021AQDS and LS1021ATWR boards.
> 
> Signed-off-by: Haikun Wang <haikun.wang@freescale.com>
> ---
> Changes in v2:
> - Rebase
> 
>  arch/arm/boot/dts/ls1021a-qds.dts | 16 ++++++++++++++++
>  arch/arm/boot/dts/ls1021a-twr.dts | 13 +++++++++++++
>  arch/arm/boot/dts/ls1021a.dtsi    | 15 +++++++++++++++
>  3 files changed, 44 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
> index 9c5e16b..15bf07f 100644
> --- a/arch/arm/boot/dts/ls1021a-qds.dts
> +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> @@ -238,3 +238,19 @@
>  &uart1 {
>  	status = "okay";
>  };
> +
> +&qspi {
> +	num-cs = <2>;
> +	bus-num = <0>;
> +	fsl,spi-num-chipselects = <2>;
> +	fsl,spi-flash-chipselects = <0>;

I don't believe the above 4 properties are used by the fsl-quadspi
driver.

> +	status = "okay";
> +
> +	qflash0: s25fl128s@0 {
> +		compatible = "spansion,s25fl128s";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		spi-max-frequency = <20000000>;
> +		reg = <0>;
> +	};
> +};
> diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts
> index a2c591e..b72f6ee 100644
> --- a/arch/arm/boot/dts/ls1021a-twr.dts
> +++ b/arch/arm/boot/dts/ls1021a-twr.dts
> @@ -125,3 +125,16 @@
>  &uart1 {
>  	status = "okay";
>  };
> +
> +&qspi {
> +	num-cs = <2>;

I don't believe the above property is used by the fsl-quadspi driver.

> +	status = "okay";
> +
> +	qflash0: n25q128a13@0 {
> +		compatible = "micron,n25q128a13";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		spi-max-frequency = <20000000>;
> +		reg = <0>;
> +	};
> +};
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index c70bb27..09f1a33 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -127,6 +127,21 @@
>  			big-endian;
>  		};
>  
> +		qspi: quadspi@1550000 {
> +			compatible = "fsl,ls1-qspi";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x0 0x1550000 0x0 0x10000>,
> +				<0x0 0x40000000 0x0 0x4000000>;
> +			reg-names = "QuadSPI", "QuadSPI-memory";
> +			interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> +			clock-names = "qspi_en", "qspi";
> +			clocks = <&platform_clk 1>, <&platform_clk 1>;
> +			big-endian;
> +			amba-base = <0x40000000>;
> +			status = "disabled";
> +		};
> +
>  		esdhc: esdhc@1560000 {
>  			compatible = "fsl,esdhc";
>  			reg = <0x0 0x1560000 0x0 0x10000>;
> 


- -- 
Cory Tusar
Principal
PID 1 Solutions, Inc.


"There are two ways of constructing a software design.  One way is to
 make it so simple that there are obviously no deficiencies, and the
 other way is to make it so complicated that there are no obvious
 deficiencies."  --Sir Charles Anthony Richard Hoare

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlWdqQEACgkQHT1tsfGwHJ+exQCfax9VHUKrButLo7J9wX9PQqiU
FAAAn1jsXCaFdWgtp6i29jsyCX0H18e+
=j0oT
-----END PGP SIGNATURE-----

  reply	other threads:[~2015-07-08 22:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07  8:38 [PATCH 1/8 v3] mtd: spi-nor: fsl-quadspi: Fix qspi irq handler complete exception Haikun Wang
2015-07-07  8:38 ` [PATCH 2/8 v4] mtd: spi-nor: fsl-quadspi: Enable LS1021 support Haikun Wang
2015-07-07  8:38 ` [PATCH 3/8 v2] mtd: spi-nor: fsl-quadspi: Add a variable in struct fsl_qspi_devtype_data to specify platform specail feature Haikun Wang
2015-07-07  8:38 ` [PATCH 4/8 v2] mtd: spi-nor: fsl-quadspi: Wrap writel/readl with qspi_writel/qspi_readl Haikun Wang
2015-07-07  8:38 ` [PATCH 5/8 v5] mtd: spi-nor: fsl-quadspi: Enable support big endian registers Haikun Wang
2015-07-07  8:38 ` [PATCH 6/8 v2] mtd: spi-nor: fsl-quadspi: Add QSPI dts node for LS1021A Haikun Wang
2015-07-08 22:49   ` Cory Tusar [this message]
2015-07-07  8:38 ` [PATCH 7/8 v2] mtd: spi-nor: fsl-quadspi: Update bindings documentation Haikun Wang
2015-07-07  8:38 ` [PATCH 8/8 v2] mtd: spi-nor: fsl-quadspi: Add compatible string "fsl, ls1-qspi" in " Haikun Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559DA901.3060404@pid1solutions.com \
    --to=cory.tusar@pid1solutions.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=haikun.wang@freescale.com \
    --cc=han.xu@freescale.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.