From: "Michel Dänzer" <michel@daenzer.net>
To: j.glisse@gmail.com, dri-devel@lists.freedesktop.org
Cc: "Jérôme Glisse" <jglisse@redhat.com>,
"Thomas Hellstrom" <thellstrom@vmware.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Subject: Re: [PATCH 1/2] drm/ttm: fix object deallocation to properly fill in the page pool.
Date: Thu, 9 Jul 2015 11:41:51 +0900 [thread overview]
Message-ID: <559DDF6F.9010208@daenzer.net> (raw)
In-Reply-To: <1436379397-7897-1-git-send-email-j.glisse@gmail.com>
On 09.07.2015 03:16, j.glisse@gmail.com wrote:
> From: Jérôme Glisse <jglisse@redhat.com>
>
> Current code never allowed the page pool to actualy fill in anyway.
> This fix it, so that we only start freeing page from the pool when
> we go over the pool size.
>
> Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
[...]
> - if (pool->npages_free > _manager->options.max_size) {
> + if (pool->npages_free > _manager->options.max_size)
> npages = pool->npages_free - _manager->options.max_size;
> - /* free at least NUM_PAGES_TO_ALLOC number of pages
> - * to reduce calls to set_memory_wb */
> - if (npages < NUM_PAGES_TO_ALLOC)
> - npages = NUM_PAGES_TO_ALLOC;
> - }
This should be part of patch 2. With that fixed, both patches are
Reviewed-and-Tested-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-07-09 2:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 18:16 [PATCH 1/2] drm/ttm: fix object deallocation to properly fill in the page pool j.glisse
2015-07-08 18:16 ` [PATCH 2/2] drm/ttm: improve uncached page deallocation j.glisse
2015-07-08 18:40 ` Konrad Rzeszutek Wilk
2015-07-08 18:41 ` [PATCH 1/2] drm/ttm: fix object deallocation to properly fill in the page pool Konrad Rzeszutek Wilk
2015-07-09 2:41 ` Michel Dänzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559DDF6F.9010208@daenzer.net \
--to=michel@daenzer.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.glisse@gmail.com \
--cc=jglisse@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.