[PATCH] soc/tegra: pmc: Avoid usage of uninitialized variable

[PATCH] soc/tegra: pmc: Avoid usage of uninitialized variable

[Thierry Reding]

From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Make sure to only drop the reference to the OF node after it's been
successfully obtained.

Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 drivers/soc/tegra/pmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index 1878d4da715d..6b0df8154fa4 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -1043,12 +1043,12 @@ void tegra_pmc_init_tsense_reset(struct tegra_pmc *pmc)
 	u32 value, checksum;
 
 	if (!pmc->soc->has_tsense_reset)
-		goto out;
+		return;
 
 	np = of_find_node_by_name(pmc->dev->of_node, "i2c-thermtrip");
 	if (!np) {
 		dev_warn(dev, "i2c-thermtrip node not found, %s.\n", disabled);
-		goto out;
+		return;
 	}
 
 	if (of_property_read_u32(np, "nvidia,i2c-controller-id", &ctrl_id)) {
-- 
2.4.1

Re: [PATCH] soc/tegra: pmc: Avoid usage of uninitialized variable

[Mikko Perttunen]

Thanks for the fix; sorry for the typo or whatever you can call it :)

This should also go into 4.0 and 4.1.

Cheers,
Mikko.

On 07/09/2015 10:59 AM, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Make sure to only drop the reference to the OF node after it's been
> successfully obtained.
> 
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/soc/tegra/pmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 1878d4da715d..6b0df8154fa4 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -1043,12 +1043,12 @@ void tegra_pmc_init_tsense_reset(struct tegra_pmc *pmc)
>  	u32 value, checksum;
>  
>  	if (!pmc->soc->has_tsense_reset)
> -		goto out;
> +		return;
>  
>  	np = of_find_node_by_name(pmc->dev->of_node, "i2c-thermtrip");
>  	if (!np) {
>  		dev_warn(dev, "i2c-thermtrip node not found, %s.\n", disabled);
> -		goto out;
> +		return;
>  	}
>  
>  	if (of_property_read_u32(np, "nvidia,i2c-controller-id", &ctrl_id)) {
>