All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
	Bart van Assche <bart.vanassche@sandisk.com>,
	linux-scsi@vger.kernel.org, Ewan Milne <emilne@redhat.com>
Subject: Re: [PATCH 3/5] scsi: Add 'access_state' attribute
Date: Thu, 09 Jul 2015 10:43:48 +0200	[thread overview]
Message-ID: <559E3444.2020301@suse.de> (raw)
In-Reply-To: <20150709082217.GA1419@lst.de>

On 07/09/2015 10:22 AM, Christoph Hellwig wrote:
> On Wed, Jul 08, 2015 at 01:09:46PM +0200, Hannes Reinecke wrote:
>> Add an 'access_state' attribute to display the LUN access state.
> 
> Should we just reuse the ALUA values here as they part of the spec
> and map the legacy implemetation values to it?
> 
That's what I've attempted to; only I've displayed them as text,
not as a numeric value.
But sure, the idea was to take the ALUA values and map legacy
implementation onto it.

> I'd also really love to store the access_state variable in
> struct scsi_device so we can perform the checks for it in core code
> instead of the device handlers.
> 
That would be a good idea indeed. I had been pondering the idea of a
revamped multipath integration, where this would be come in handy.

I can easily adapt the patches here.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-07-09  8:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 11:09 [PATCH 0/5] device handler interface update Hannes Reinecke
2015-07-08 11:09 ` [PATCH 1/5] scsi: rescan VPD attributes Hannes Reinecke
2015-07-24 14:38   ` Christoph Hellwig
2015-07-24 14:40     ` Hannes Reinecke
2015-07-24 14:43       ` Christoph Hellwig
2015-07-25 15:42         ` Hannes Reinecke
2015-07-08 11:09 ` [PATCH 2/5] scsi_dh: add 'rescan' callback Hannes Reinecke
2015-07-08 11:09 ` [PATCH 3/5] scsi: Add 'access_state' attribute Hannes Reinecke
2015-07-09  8:22   ` Christoph Hellwig
2015-07-09  8:43     ` Hannes Reinecke [this message]
2015-07-08 11:09 ` [PATCH 4/5] scsi_dh_alua: add 'state' callback function Hannes Reinecke
2015-07-24 14:42   ` Christoph Hellwig
2015-07-25 15:42     ` Hannes Reinecke
2015-07-08 11:09 ` [PATCH 5/5] scsi_dh_rdac: Add 'state' callback Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559E3444.2020301@suse.de \
    --to=hare@suse.de \
    --cc=bart.vanassche@sandisk.com \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.