From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: "Lengyel, Tamas" <tlengyel@novetta.com>
Cc: kevin.tian@intel.com, Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
eddie.dong@intel.com, Ian Jackson <ian.jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Jan Beulich <jbeulich@suse.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
keir@xen.org
Subject: Re: [PATCH v4 3/3] x86/monitor: don't use hvm_funcs directly
Date: Thu, 9 Jul 2015 15:55:18 +0300 [thread overview]
Message-ID: <559E6F36.3030108@bitdefender.com> (raw)
In-Reply-To: <CAD33N+7KdGuHu_DFkpUamB9yeA=cXGDnEphzMkfi1BEurH_T9A@mail.gmail.com>
On 07/09/2015 03:52 PM, Lengyel, Tamas wrote:
> I don't feel very strongly about it, so if you really prefer you can
> keep the code as it is, however this looks somewhat counterintuitive to
> me, especially when you compare the new condition to the old one,
> because
> ...
>
>
> Yea, this patch is not critical. Jan just requested to use a wrapper for
> hvm_funcs in the other patch so I figured I might as well fix it
> everywhere in our code. It's pretty minor stuff.
Well, I think that the patch is a good idea, I was just talking about
changing the function to return a bool_t. Sorry for not being clearer.
Cheers,
Razvan
next prev parent reply other threads:[~2015-07-09 12:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 22:52 [PATCH v4 1/3] x86/monitor: add get_capabilities to monitor_op domctl Tamas K Lengyel
2015-07-08 22:52 ` [PATCH v4 2/3] x86/vm_event: toggle singlestep from vm_event response Tamas K Lengyel
2015-07-08 22:52 ` [PATCH v4 3/3] x86/monitor: don't use hvm_funcs directly Tamas K Lengyel
2015-07-09 6:15 ` Razvan Cojocaru
2015-07-09 8:15 ` Jan Beulich
2015-07-09 12:50 ` Lengyel, Tamas
2015-07-09 12:52 ` Lengyel, Tamas
2015-07-09 12:55 ` Razvan Cojocaru [this message]
2015-07-09 9:05 ` [PATCH v4 1/3] x86/monitor: add get_capabilities to monitor_op domctl Ian Campbell
2015-07-09 12:37 ` Lengyel, Tamas
2015-07-09 13:00 ` Razvan Cojocaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E6F36.3030108@bitdefender.com \
--to=rcojocaru@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tlengyel@novetta.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.