From: Owen Synge <osynge@suse.com>
To: Travis Rhoden <trhoden@redhat.com>
Cc: ceph-devel@vger.kernel.org
Subject: Pentagon Orange redefined in ceph-deploy
Date: Thu, 09 Jul 2015 21:37:20 +0200 [thread overview]
Message-ID: <559ECD70.9080700@suse.com> (raw)
In-Reply-To: <6E87029C-274C-4223-83AA-88CA5B0F59EC@redhat.com>
Dear all,
Their are other details to be discussed, and hopefully lead to
agreement, but lets get to issue #1. The style issues still apply to
ceph and ceph-deploy.
From what you said, in my opinion the "boat anchor" in ceph-deploy is
redefined, as coupling of facade pattern, where all data is available,
to the ssh loop in a connection. This is probably the biggest single
architectural issue in ceph-deploy.
Travis Rhoden stated that the modules are imported as objects as they
are "instantiated", I should check this, this is very good news and
removes many objections to the outcome.
The discussion of point (3) is still worth continuing though in a
separate thread as it is still important enough to require discussion,
but it is of a style and good practice discussion rather than Boat
Anchor problem level.
Many other topics are unaffected.
On 07/09/2015 07:00 PM, Travis Rhoden wrote:
>> (1A) You have to close one facade to start anouther, eg in ceph-deploy
>> > you have to close each connection before connecting to the next server
>> > so making it slow to use as all state has to be gathered.
> concurrency has come up before in ceph-deploy. It has been our explicit goal to make ceph-deploy as simple and *clear* as possible for users, with one of the main purposes to be extremely verbose and essentially *teach* a user how to deploy a Ceph cluster. That’s why it prints everything it does by default, shows every remote command, and prints the output back in order. Concurrency would muddy those waters, though we do all want things to go faster.
>
> It is not necessarily the facade pattern that is the limitation there — it is the implementation within ceph-deploy. We simply do a “for host is hostnames…” loop everywhere — it doesn’t matter what we are using underneath, we are doing one SSH connection at a time.
Best regards
Owen
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-09 19:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 10:08 python facade pattern implementation in ceph and ceph-deploy is bad practice? Owen Synge
2015-07-09 10:46 ` John Spray
2015-07-09 11:59 ` Owen Synge
2015-07-09 12:07 ` Owen Synge
2015-07-09 19:58 ` Travis Rhoden
2015-07-14 8:47 ` Owen Synge
2015-07-17 3:40 ` Travis Rhoden
2015-07-09 16:28 ` Owen Synge
2015-07-09 16:36 ` Owen Synge
2015-07-09 17:00 ` Travis Rhoden
2015-07-09 19:37 ` Owen Synge [this message]
2015-07-09 19:45 ` Pentagon Orange redefined in ceph-deploy Owen Synge
2015-07-10 5:03 ` Travis Rhoden
2015-07-10 8:57 ` Owen Synge
2015-07-14 10:41 ` Difference between convention and enforcement Owen Synge
2015-07-14 11:03 ` Gregory Farnum
2015-07-14 11:54 ` Owen Synge
2015-07-17 5:10 ` Travis Rhoden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559ECD70.9080700@suse.com \
--to=osynge@suse.com \
--cc=ceph-devel@vger.kernel.org \
--cc=trhoden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.