All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@ezchip.com>
To: Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Don Zickus <dzickus@redhat.com>,
	Ulrich Obergfell <uobergfe@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/4] smpboot/watchdog: Fixes and cleanups
Date: Thu, 9 Jul 2015 16:59:07 -0400	[thread overview]
Message-ID: <559EE09B.7090706@ezchip.com> (raw)
In-Reply-To: <1436454992-21462-1-git-send-email-fweisbec@gmail.com>

On 07/09/2015 11:16 AM, Frederic Weisbecker wrote:
> Hi,
>
> The 2nd patch should fix the strange bug we've seen with Chris.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> 	core/watchdog
>
> HEAD: 5e36d90b3ccb0023ad54ac7a2381c132c6b12280
>
> Thanks,
> 	Frederic
> ---
>
> Frederic Weisbecker (4):
>        smpboot: Fix memory leak on error handling
>        smpboot: Make cleanup to mirror setup
>        smpboot: Allow to pass the cpumask on per-cpu thread registration
>        watchdog: Simplify housekeeping affinity with the appropriate mask
>
>
>   include/linux/smpboot.h | 11 ++++++++++-
>   kernel/smpboot.c        | 22 +++++++++-------------
>   kernel/watchdog.c       | 15 +++++----------
>   3 files changed, 24 insertions(+), 24 deletions(-)

You can add my

Reviewed-by: Chris Metcalf <cmetcalf@ezchip.com>

to all four.  There are a couple of typos in the commit message for
patch 2/4: "ressources" and "lets simply" (should be "let's simply").

Glad you figured out what the bug was.  Curious that in your
environment you got a panic rather than an infinite loop waiting
for a timer subsystem pointer to go non-NULL.

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com


  parent reply	other threads:[~2015-07-09 20:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 15:16 [PATCH 0/4] smpboot/watchdog: Fixes and cleanups Frederic Weisbecker
2015-07-09 15:16 ` [PATCH 1/4] smpboot: Fix memory leak on error handling Frederic Weisbecker
2015-07-09 15:16 ` [PATCH 2/4] smpboot: Make cleanup to mirror setup Frederic Weisbecker
2015-07-09 15:16 ` [PATCH 3/4] smpboot: Allow to pass the cpumask on per-cpu thread registration Frederic Weisbecker
2015-07-11 15:17   ` Ulrich Obergfell
2015-07-11 15:23     ` Frederic Weisbecker
2015-07-09 15:16 ` [PATCH 4/4] watchdog: Simplify housekeeping affinity with the appropriate mask Frederic Weisbecker
2015-07-09 20:59 ` Chris Metcalf [this message]
2015-07-11 14:19   ` [PATCH 0/4] smpboot/watchdog: Fixes and cleanups Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559EE09B.7090706@ezchip.com \
    --to=cmetcalf@ezchip.com \
    --cc=akpm@linux-foundation.org \
    --cc=dzickus@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=uobergfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.