From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm: Drop owner assignment from i2c_driver Date: Fri, 10 Jul 2015 14:50:36 +0800 Message-ID: <559F6B3C.8080908@rock-chips.com> References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDA35pyIMTDml6UgMTM6MzYsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4g aTJjX2RyaXZlciBkb2VzIG5vdCBuZWVkIHRvIHNldCBhbiBvd25lciBiZWNhdXNlIGkyY19yZWdp c3Rlcl9kcml2ZXIoKQo+IHdpbGwgc2V0IGl0Lgo+Cj4gU2lnbmVkLW9mZi1ieTogS3J6eXN6dG9m IEtvemxvd3NraSA8ay5rb3psb3dza2lAc2Ftc3VuZy5jb20+Cj4KPiAtLS0KPgo+IFRoZSBjb2Nj aW5lbGxlIHNjcmlwdCB3aGljaCBnZW5lcmF0ZWQgdGhlIHBhdGNoIHdhcyBzZW50IGhlcmU6Cj4g aHR0cDovL3d3dy5zcGluaWNzLm5ldC9saXN0cy9rZXJuZWwvbXNnMjAyOTkwMy5odG1sCj4gLS0t Cj4gICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3BzODYyMi5jICAgICAgICAgICAgIHwgMSAtCj4g ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3B0bjM0NjAuYyAgICAgICAgICAgIHwgMSAtCj4gICBk cml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jIHwgMSAtCj4gICAzIGZp bGVzIGNoYW5nZWQsIDMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2JyaWRnZS9wczg2MjIuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvcHM4NjIyLmMKPiBp bmRleCAxYTY2MDdiZWIyOWYuLmJlODgxZTlmZWY4ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYnJpZGdlL3BzODYyMi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9wczg2 MjIuYwo+IEBAIC02NjgsNyArNjY4LDYgQEAgc3RhdGljIHN0cnVjdCBpMmNfZHJpdmVyIHBzODYy Ml9kcml2ZXIgPSB7Cj4gICAJLnJlbW92ZQkJPSBwczg2MjJfcmVtb3ZlLAo+ICAgCS5kcml2ZXIJ CT0gewo+ICAgCQkubmFtZQk9ICJwczg2MjIiLAo+IC0JCS5vd25lcgk9IFRISVNfTU9EVUxFLAo+ ICAgCQkub2ZfbWF0Y2hfdGFibGUgPSBwczg2MjJfZGV2aWNlcywKPiAgIAl9LAo+ICAgfTsKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9wdG4zNDYwLmMgYi9kcml2ZXJzL2dw dS9kcm0vYnJpZGdlL3B0bjM0NjAuYwo+IGluZGV4IDFiMWJmMjM4NDgxNS4uMGZmYTNhNmEyMDZh IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvcHRuMzQ2MC5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9wdG4zNDYwLmMKPiBAQCAtNDAwLDcgKzQwMCw2IEBAIHN0 YXRpYyBzdHJ1Y3QgaTJjX2RyaXZlciBwdG4zNDYwX2RyaXZlciA9IHsKPiAgIAkucmVtb3ZlCQk9 IHB0bjM0NjBfcmVtb3ZlLAo+ICAgCS5kcml2ZXIJCT0gewo+ICAgCQkubmFtZQk9ICJueHAscHRu MzQ2MCIsCj4gLQkJLm93bmVyCT0gVEhJU19NT0RVTEUsCj4gICAJCS5vZl9tYXRjaF90YWJsZSA9 IHB0bjM0NjBfbWF0Y2gsCj4gICAJfSwKPiAgIH07Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvcm9ja2NoaXBfZHJtX2Rydi5jCj4gaW5kZXggMDFiNTU4ZmUzNjk1Li45YTBjMjkxMTI3MmEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMKPiBA QCAtNTU1LDcgKzU1NSw2IEBAIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHJvY2tjaGlw X2RybV9wbGF0Zm9ybV9kcml2ZXIgPSB7Cj4gICAJLnByb2JlID0gcm9ja2NoaXBfZHJtX3BsYXRm b3JtX3Byb2JlLAo+ICAgCS5yZW1vdmUgPSByb2NrY2hpcF9kcm1fcGxhdGZvcm1fcmVtb3ZlLAo+ ICAgCS5kcml2ZXIgPSB7Cj4gLQkJLm93bmVyID0gVEhJU19NT0RVTEUsCgpCdXQgcm9ja2NoaXAg ZHJtIGlzIHBsYXRmb3JtIGRyaXZlciBub3QgaTJjX2RyaXZlciwgd2h5IHJlbW92ZSBpdHMgLm93 bmVyID8KCi1NYXJrCj4gICAJCS5uYW1lID0gInJvY2tjaGlwLWRybSIsCj4gICAJCS5vZl9tYXRj aF90YWJsZSA9IHJvY2tjaGlwX2RybV9kdF9pZHMsCj4gICAJCS5wbSA9ICZyb2NrY2hpcF9kcm1f cG1fb3BzLAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Fri, 10 Jul 2015 14:50:36 +0800 Subject: [PATCH] drm: Drop owner assignment from i2c_driver In-Reply-To: <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> Message-ID: <559F6B3C.8080908@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?07?10? 13:36, Krzysztof Kozlowski wrote: > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-by: Krzysztof Kozlowski > > --- > > The coccinelle script which generated the patch was sent here: > http://www.spinics.net/lists/kernel/msg2029903.html > --- > drivers/gpu/drm/bridge/ps8622.c | 1 - > drivers/gpu/drm/bridge/ptn3460.c | 1 - > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ps8622.c b/drivers/gpu/drm/bridge/ps8622.c > index 1a6607beb29f..be881e9fef8f 100644 > --- a/drivers/gpu/drm/bridge/ps8622.c > +++ b/drivers/gpu/drm/bridge/ps8622.c > @@ -668,7 +668,6 @@ static struct i2c_driver ps8622_driver = { > .remove = ps8622_remove, > .driver = { > .name = "ps8622", > - .owner = THIS_MODULE, > .of_match_table = ps8622_devices, > }, > }; > diff --git a/drivers/gpu/drm/bridge/ptn3460.c b/drivers/gpu/drm/bridge/ptn3460.c > index 1b1bf2384815..0ffa3a6a206a 100644 > --- a/drivers/gpu/drm/bridge/ptn3460.c > +++ b/drivers/gpu/drm/bridge/ptn3460.c > @@ -400,7 +400,6 @@ static struct i2c_driver ptn3460_driver = { > .remove = ptn3460_remove, > .driver = { > .name = "nxp,ptn3460", > - .owner = THIS_MODULE, > .of_match_table = ptn3460_match, > }, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index 01b558fe3695..9a0c2911272a 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -555,7 +555,6 @@ static struct platform_driver rockchip_drm_platform_driver = { > .probe = rockchip_drm_platform_probe, > .remove = rockchip_drm_platform_remove, > .driver = { > - .owner = THIS_MODULE, But rockchip drm is platform driver not i2c_driver, why remove its .owner ? -Mark > .name = "rockchip-drm", > .of_match_table = rockchip_drm_dt_ids, > .pm = &rockchip_drm_pm_ops, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbbGJGvF (ORCPT ); Fri, 10 Jul 2015 02:51:05 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:34314 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751789AbbGJGu5 (ORCPT ); Fri, 10 Jul 2015 02:50:57 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:S;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: k.kozlowski@samsung.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <17207ec52d1cc2fd2641c0e4aad7b94c> X-DNS-TYPE: 0 Message-ID: <559F6B3C.8080908@rock-chips.com> Date: Fri, 10 Jul 2015 14:50:36 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm: Drop owner assignment from i2c_driver References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年07月10日 13:36, Krzysztof Kozlowski wrote: > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-by: Krzysztof Kozlowski > > --- > > The coccinelle script which generated the patch was sent here: > http://www.spinics.net/lists/kernel/msg2029903.html > --- > drivers/gpu/drm/bridge/ps8622.c | 1 - > drivers/gpu/drm/bridge/ptn3460.c | 1 - > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ps8622.c b/drivers/gpu/drm/bridge/ps8622.c > index 1a6607beb29f..be881e9fef8f 100644 > --- a/drivers/gpu/drm/bridge/ps8622.c > +++ b/drivers/gpu/drm/bridge/ps8622.c > @@ -668,7 +668,6 @@ static struct i2c_driver ps8622_driver = { > .remove = ps8622_remove, > .driver = { > .name = "ps8622", > - .owner = THIS_MODULE, > .of_match_table = ps8622_devices, > }, > }; > diff --git a/drivers/gpu/drm/bridge/ptn3460.c b/drivers/gpu/drm/bridge/ptn3460.c > index 1b1bf2384815..0ffa3a6a206a 100644 > --- a/drivers/gpu/drm/bridge/ptn3460.c > +++ b/drivers/gpu/drm/bridge/ptn3460.c > @@ -400,7 +400,6 @@ static struct i2c_driver ptn3460_driver = { > .remove = ptn3460_remove, > .driver = { > .name = "nxp,ptn3460", > - .owner = THIS_MODULE, > .of_match_table = ptn3460_match, > }, > }; > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index 01b558fe3695..9a0c2911272a 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -555,7 +555,6 @@ static struct platform_driver rockchip_drm_platform_driver = { > .probe = rockchip_drm_platform_probe, > .remove = rockchip_drm_platform_remove, > .driver = { > - .owner = THIS_MODULE, But rockchip drm is platform driver not i2c_driver, why remove its .owner ? -Mark > .name = "rockchip-drm", > .of_match_table = rockchip_drm_dt_ids, > .pm = &rockchip_drm_pm_ops,